[issue24408] tkinter.font.Font.measure() broken in 3.5

Roundup Robot added the comment: New changeset 8e90f3ffa784 by Serhiy Storchaka in branch '2.7': Issue #24408: Fixed test for tkinter.Font on OS X. https://hg.python.org/cpython/rev/8e90f3ffa784 New changeset 014ee2df443a by Serhiy Storchaka in branch '3.4': Issue #24408: Fixed test for

[issue24408] tkinter.font.Font.measure() broken in 3.5

Serhiy Storchaka added the comment: Thank you Ned and Martin. -- resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24408

[issue24408] tkinter.font.Font.measure() broken in 3.5

Roundup Robot added the comment: New changeset 20c9290a5de4 by Ned Deily in branch '2.7': Issue #24408: Prevent test_font failures with non-ascii font names. https://hg.python.org/cpython/rev/20c9290a5de4 -- ___ Python tracker rep...@bugs.python.org

[issue24408] tkinter.font.Font.measure() broken in 3.5

Martin Panter added the comment: Here is a patch to decouple the families() and Font.actual(family) tests as I suggested. Ned, can you confirm if this works on the failing OS X setup? I expect it should be fine. -- stage: needs patch - patch review Added file:

[issue24408] tkinter.font.Font.measure() broken in 3.5

Ned Deily added the comment: Test fails on OS X (10.10) with Cocoa Tk 8.6(.4) and 8.5(.18): == FAIL: test_families (test_tkinter.test_font.FontTest) --

[issue24408] tkinter.font.Font.measure() broken in 3.5

Martin Panter added the comment: Some quick googling suggests this “.Helvetica Neue DeskInterface” font is real, and because it begins with a full stop it may be normally hidden from the normal list of fonts. Perhaps the test could be modified to just check the two functions separately: *

[issue24408] tkinter.font.Font.measure() broken in 3.5

Changes by Serhiy Storchaka storch...@gmail.com: -- resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24408 ___

[issue24408] tkinter.font.Font.measure() broken in 3.5

Roundup Robot added the comment: New changeset 7e2a7f3fecdf by Serhiy Storchaka in branch '3.4': Issue #24408: Added more tkinter.Font tests. https://hg.python.org/cpython/rev/7e2a7f3fecdf New changeset 24bb564469b4 by Serhiy Storchaka in branch '3.5': Issue #24408: Added more tkinter.Font

[issue24408] tkinter.font.Font.measure() broken in 3.5

Martin Panter added the comment: Thanks for the prompt fix! The patch with the tests looks good. I left a query about the existing code. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24408

[issue24408] tkinter.font.Font.measure() broken in 3.5

New submission from Martin Panter: import tkinter, tkinter.font tk = tkinter.Tk() tkinter.font.nametofont(TkHeadingFont).measure(string) Traceback (most recent call last): File stdin, line 1, in module File /home/proj/python/cpython/Lib/tkinter/font.py, line 154, in measure return

[issue24408] tkinter.font.Font.measure() broken in 3.5

Changes by Serhiy Storchaka storch...@gmail.com: -- assignee: - serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24408 ___ ___

[issue24408] tkinter.font.Font.measure() broken in 3.5

Serhiy Storchaka added the comment: Thank you for your report Martin. Unfortunately tests for tkinter.Font are almost not existing. Here is a patch that adds more tests (it should be applied to all versions). -- keywords: +patch stage: needs patch - patch review Added file:

[issue24408] tkinter.font.Font.measure() broken in 3.5

Roundup Robot added the comment: New changeset fb05c1355a90 by Serhiy Storchaka in branch '3.5': Issue #24408: Fixed AttributeError in measure() and metrics() methods of https://hg.python.org/cpython/rev/fb05c1355a90 New changeset 0dd70c2c44b4 by Serhiy Storchaka in branch 'default': Issue