[issue2445] Use The CygwinCCompiler Under Cygwin

[Steve Dower]

Steve Dower  added the comment:

Distutils is now deprecated (see PEP 632) and all tagged issues are being 
closed. From now until removal, only release blocking issues will be considered 
for distutils.

If this issue does not relate to distutils, please remove the component and 
reopen it. If you believe it still requires a fix, most likely the issue should 
be re-reported at https://github.com/pypa/setuptools

--
nosy: +steve.dower
resolution: accepted -> out of date
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2445] Use The CygwinCCompiler Under Cygwin

[Erik Bray]

Change by Erik Bray :


--
pull_requests: +4099
stage: commit review -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2445] Use The CygwinCCompiler Under Cygwin

[Mark Lawrence]

Changes by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2445] Use The CygwinCCompiler Under Cygwin

[David Stanek]

Changes by David Stanek :


--
nosy:  -dstanek

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2445] Use The CygwinCCompiler Under Cygwin

[Christian Heimes]

Changes by Christian Heimes :


--
nosy:  -christian.heimes

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2445] Use The CygwinCCompiler Under Cygwin

[Erik Bray]

Erik Bray added the comment:

I have confirmed Masayuki's patch (3.4-distutils-shlibext.patch) fixes a few 
build issues on Cygwin.

At its core, what it's fixing is allowing UnixCCompiler.find_library_file to 
find import libraries on Cygwin.  

That in turn is necessary for --with-system-ffi to work, which is currently 
needed; on Cygwin64 at least the ffi compile as part of _ctypes fails (a 
separate issue to be addressed separately).  But in the meantime making 
--with-system-ffi work again goes a long way.

It should be noted there is a patch at #18654 to make the CygwinCCompiler class 
work again, and switch to using it to handle Cygwin-specific build issues as 
origially intended.  I intend to review that ticket and spend some time on it, 
but it's more complex and not necessarily the simplest way forward.

In the meantime this one-line patch accomplishes a fair bit.

--
nosy: +erik.bray
stage: patch review -> commit review
versions: +Python 3.6 -Python 2.7, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2445] Use The CygwinCCompiler Under Cygwin

[Masayuki Yamamoto]

Masayuki Yamamoto added the comment:

CygwinCCompiler seems legacy code.
In v3.4 latest rivision, Distutils has made to work that is a patching to 
UnixCCompiler.
So, I have a think that doesn't need to use CygwinCCompiler to build on Cygwin.
I have upload a patch for UnixCCompiler.  The patch has modified from 
http://cygwin.org package.

Other big issues and patches for build on Cygwin:
#21085, #13756 -- compile error
#14598, #21124 -- C extension module

--
nosy: +masamoto
Added file: http://bugs.python.org/file39141/3.4-distutils-shlibext.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2445
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2445] Use The CygwinCCompiler Under Cygwin

[Terry J. Reedy]

Changes by Terry J. Reedy tjre...@udel.edu:


--
stage:  - patch review
versions: +Python 3.4, Python 3.5 -Python 3.1, Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2445
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2445] Use The CygwinCCompiler Under Cygwin

[Mark Lawrence]

Mark Lawrence added the comment:

From msg194383 issues #18633, #18634 and #18654 are linked to this so is 
anybody up for providing a patch so that we can take this forward.  See also 
#4032.

--
nosy: +BreamoreBoy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2445
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2445] Use The CygwinCCompiler Under Cygwin

[Roumen Petrov]

Roumen Petrov added the comment:

Hi, 
Now issue18654 modernize mingwcygwin compiler classes contain enhancement 
that could be reused by this issue: patch 
0007-MINGW-compiler-cygwin-provides-its-own-C-runtime.patch
 from archive , i.e. lets avoid change in get_msvcr() that return. Mingw is 
also impacted but is addresses in another patches.  As separate patch is 
'compiler customization' -  more advanced version then proposed by Jeevan 
Varshney (jayvee)

A separate issue18634 find import library address .dll.a suffix based on 
existing distutil functionality.

Also issue18633 Mingw32CCompiler as default compiler for mingw* build adds 
same fixes from unix compiler class into Cygwin one - ref '# Chop off the drive'

So with above I think that cygwin compiler could be switched back from unix to 
own.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2445
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2445] Use The CygwinCCompiler Under Cygwin

[Éric Araujo]

Changes by Éric Araujo mer...@netwok.org:


--
nosy: +eric.araujo
versions: +Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2445
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2445] Use The CygwinCCompiler Under Cygwin

[Bill Janssen]

Bill Janssen bill.jans...@gmail.com added the comment:

Shouldn't the import library name end with .lib?  I've run up against this 
building PyLucene with MinGW.  There seems to be code to figure this out 
already in CygwinCCompiler, but it's commented out (and arguably incomplete).

--
nosy: +janssen

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2445
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2445] Use The CygwinCCompiler Under Cygwin

[Tarek Ziadé]

Changes by Tarek Ziadé ziade.ta...@gmail.com:


--
assignee:  - tarek
nosy: +tarek
versions: +Python 2.7, Python 3.1 -Python 2.6, Python 3.0

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2445
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2445] Use The CygwinCCompiler Under Cygwin

[Roumen Petrov]

Roumen Petrov [EMAIL PROTECTED] added the comment:

May be check for compiler.compiler_type (from sysconfig.py ) has to be
replaced with a check for descendant classes of UnixCCompiler, i.e. to
include mingw32 too ?

Also CygwinCCompiler __init__ has to be reviewed too. As example :
-
# Hard-code GCC because that's what this is all about.
# XXX optimization, warnings etc. should be customizable.
self.set_executables(compiler='gcc -mcygwin -O -Wall',
.
-
May override in unexpected way settings from customize_compiler.

I thin that proposed modification in sysconfig.py with removing(or
replacing)  of self.set_executables from CygwinCCompiler __init__  will
help me for issue3871 (cross building python for mingw32 with distutils). 

As example I will remove a hack in the setup.py:
---
@@ -196,8 +196,26 @@
 if compiler is not None:
 (ccshared,cflags) =
sysconfig.get_config_vars('CCSHARED','CFLAGS')
 args['compiler_so'] = compiler + ' ' + ccshared + ' ' + cflags
+
+# FIXME: Is next correct ?
+# To link modules we need LDSHARED passed to setup.py otherwise
+# distutils will use linker from build system if cross-compiling.
+linker_so = os.environ.get('LDSHARED')
+if linker_so is not None:
+args['linker_so'] = linker_so
+
 self.compiler.set_executables(**args)
---
Thanks to Hirokazu who point me, in an another thread, that cygwin build
don't use CygwinCCompiler.

--
nosy: +rpetrov

___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2445
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2445] Use The CygwinCCompiler Under Cygwin

[Roumen Petrov]

Roumen Petrov [EMAIL PROTECTED] added the comment:

P.S. : about: static_lib_extension = .dll.a - it is suffix for import
library  and unixccompiler.py.diff patch from issue1706863 propose 
dylib_lib_extension = .dll.a .

___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2445
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2445] Use The CygwinCCompiler Under Cygwin

[Roumen Petrov]

Roumen Petrov [EMAIL PROTECTED] added the comment:

I forgot  an another issue in CygwinCCompiler __init__:
if gcc isn't version 2.91.57 then method will set dll_libraries to
result of get_msvcr(), but the result may be is None. In this case link
method fail on the line libraries.extend(self.dll_libraries).

___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2445
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2445] Use The CygwinCCompiler Under Cygwin

[Hirokazu Yamamoto]

Hirokazu Yamamoto [EMAIL PROTECTED] added the comment:

# I found this infomation via svn blame

According to issue403947, cygwin once used CygwinCCompiler, and problem
was there, swiched to UnixCCompier. (r19674)

If this issue is not solved yet, maybe it's not good to go back to
CygwinCCompiler. (maybe)

--
nosy: +ocean-city

___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2445
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2445] Use The CygwinCCompiler Under Cygwin

[Jeevan Varshney]

Jeevan Varshney [EMAIL PROTECTED] added the comment:

The following will also let environment variables be passed to the
CygwinCCompiler.

--- orig/sysconfig.py   2008-05-19 00:26:03.953125000 -0700
+++ copy/sysconfig.py   2008-05-19 00:14:51.609375000 -0700
@@ -145,7 +145,7 @@
 Mainly needed on Unix, so we can plug in the information that
 varies across Unices and is stored in Python's Makefile.
 
-if compiler.compiler_type == unix:
+if compiler.compiler_type in (unix, cygwin):
 (cc, cxx, opt, cflags, ccshared, ldshared, so_ext) = \
 get_config_vars('CC', 'CXX', 'OPT', 'CFLAGS',
 'CCSHARED', 'LDSHARED', 'SO')

--
nosy: +jayvee

__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2445
__
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2445] Use The CygwinCCompiler Under Cygwin

[David Stanek]

Changes by David Stanek [EMAIL PROTECTED]:


--
type:  - compile error

__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2445
__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2445] Use The CygwinCCompiler Under Cygwin

[Christian Heimes]

Christian Heimes [EMAIL PROTECTED] added the comment:

The patch contains lots of unrelated changes. Can you please provide a
clean patch and some doc updates? The rest looks fine to me.

--
nosy: +tiran
priority:  - high
resolution:  - accepted
versions: +Python 3.0

__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2445
__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2445] Use The CygwinCCompiler Under Cygwin

[David Stanek]

David Stanek [EMAIL PROTECTED] added the comment:

As Christian suggested I removed the unrelated svn:ignore changes.

Added file: http://bugs.python.org/file9804/cygwin-smaller.diff

__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2445
__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2445] Use The CygwinCCompiler Under Cygwin

[David Stanek]

Changes by David Stanek [EMAIL PROTECTED]:


Removed file: http://bugs.python.org/file9803/cygwin.diff

__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2445
__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com