[issue24476] Statically link vcruntime140.dll
Steve Dower added the comment: Fixed this, and forgot I had a bug open for it so I didn't reference it from the commit. -- resolution: - fixed stage: - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24476 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24476] Statically link vcruntime140.dll
Steve Dower added the comment: Reopening this because we need to update distutils to pass the same options or built wheels won't work on machines where the full VC runtime isn't installed. -- resolution: fixed - stage: resolved - status: closed - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24476 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24476] Statically link vcruntime140.dll
Paul Moore added the comment: Cool. Easier distribution is good. Better compatibility with GPL requirements (depending only on system facilities) is probably helpful for the general community, too. Embedding in C++ built with a different version of the compiler is always going to be a fun exercise - I can't see this change as making things worse, even if it doesn't end up helping either. I'm guessing that this specific change won't make much difference to embedding in general - it's the move to the universal CRT that mitigates the worst of the don't mix C runtimes issues, rather than this specific change? Anyway, it's all steps in a positive direction, so that's good. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24476 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24476] Statically link vcruntime140.dll
Steve Dower added the comment: it's the move to the universal CRT that mitigates the worst of the don't mix C runtimes issues, rather than this specific change? Correct -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24476 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24476] Statically link vcruntime140.dll
Changes by Steve Dower steve.do...@microsoft.com: -- resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24476 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24476] Statically link vcruntime140.dll
Roundup Robot added the comment: New changeset 56ea535a8047 by Steve Dower in branch '3.5': Issue 24476: Statically links vcruntime140.dll and removes it from the installer https://hg.python.org/cpython/rev/56ea535a8047 New changeset c0827842102e by Steve Dower in branch 'default': Issue 24476: Statically links vcruntime140.dll and removes it from the installer https://hg.python.org/cpython/rev/c0827842102e -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24476 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24476] Statically link vcruntime140.dll
Zachary Ware added the comment: As long as a clean (updated) install of Vista, 7, 8, or 10 can download the installer, run it, and run Python without having to do anything else, I'm good with it. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24476 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24476] Statically link vcruntime140.dll
New submission from Steve Dower: It's possible to statically link the vcruntime140.dll dependency without statically linking the entire CRT, which will save us from having to redistribute the file (meaning the entire CRT dependency is now system components). Patch to follow, and I'm very +1 on this, but didn't want to skip the chance for people to raise concerns or questions. -- assignee: steve.dower components: Windows messages: 245511 nosy: paul.moore, steve.dower, tim.golden, zach.ware priority: normal severity: normal stage: patch review status: open title: Statically link vcruntime140.dll type: behavior versions: Python 3.5, Python 3.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24476 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24476] Statically link vcruntime140.dll
Changes by Steve Dower steve.do...@microsoft.com: -- keywords: +patch Added file: http://bugs.python.org/file39742/24476_1.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24476 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24476] Statically link vcruntime140.dll
Paul Moore added the comment: +1 from me on this. Are there any specific technical implications (in terms of ease of interoperability, ability to use a different compiler to build Python, or whatever)? Whether there are or not, I'm still in favour - I think it's a good thing anyway on general principles. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24476 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24476] Statically link vcruntime140.dll
Steve Dower added the comment: There may be some potential issues when hosting Python in a C++ app built with a later version of MSVC, since vcruntime140.dll is predominantly initialization and exceptions for C++. I can't think of anything specific here though, and it seems likely that the host's initialization code would apply for the host. The C Runtime doesn't rely on anything initialized here as far as I know - it's only the C++ libraries. Shouldn't be any other implications other than slightly easier distribution and slightly larger file sizes. (Haven't actually checked how much larger, but it is no more than 10s of KB which I consider acceptable.) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24476 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
