[issue24520] Stop using deprecated floating-point environment functions on FreeBSD

STINNER Victor added the comment: > @koobs: sorry, 3.4 now only accept security fixes :-p I wrote a table giving the status of each Python branch to know which ones still accept bugfixes or not: https://docs.python.org/devguide/#status-of-python-branches -- resolution: -> fixed

[issue24520] Stop using deprecated floating-point environment functions on FreeBSD

Stefan Krah added the comment: 1) Feedback whether the compiler used on FreeBSD recognizes FENV_ACCESS. 2) If not, an indication why the man page mentions it. -- ___ Python tracker

[issue24520] Stop using deprecated floating-point environment functions on FreeBSD

STINNER Victor added the comment: Andrew Turner: "Can this be applied?" koobs: "What remains to be done/identified/answers here to make progress?" *I* don't understand if replacing fpsetmask() with fedisableexcept() is enough, or if we also need to starting putting "#pragma STDC FENV_ACCESS

[issue24520] Stop using deprecated floating-point environment functions on FreeBSD

Stefan Krah added the comment: Thanks, then the patch looks good to me. -- ___ Python tracker ___ ___

[issue24520] Stop using deprecated floating-point environment functions on FreeBSD

Andrew Turner added the comment: I think this patch is correct. Clang, as shipped by FreeBSD, doesn't support FENV_ACCESS. It raises the following warning: fenv_test.c:2:14: warning: pragma STDC FENV_ACCESS ON is not supported, ignoring pragma [-Wunknown-pragmas] #pragma STDC FENV_ACCESS ON

[issue24520] Stop using deprecated floating-point environment functions on FreeBSD

koobs added the comment: This issue is becoming increasingly important as FreeBSD 11.0-RELEASE time nears. What remains to be done/identified/answers here to make progress? -- versions: +Python 2.7, Python 3.5 ___ Python tracker

[issue24520] Stop using deprecated floating-point environment functions on FreeBSD

Roundup Robot added the comment: New changeset 76f35f35be50 by Victor Stinner in branch '3.5': Replace fpgetmask() with fedisableexcept() https://hg.python.org/cpython/rev/76f35f35be50 New changeset 6134d9ecab60 by Victor Stinner in branch 'default': Merge 3.5 (issue #24520)

[issue24520] Stop using deprecated floating-point environment functions on FreeBSD

STINNER Victor added the comment: "I expect the man page mentions it because it is mentioned in the standard. In the bugs section it does say the pragma is unimplemented." Ah ah, funnny. Sorry, I was confused by the manual page. I pushed your patch to Python 2.7, 3.5 and default (3.6)

[issue24520] Stop using deprecated floating-point environment functions on FreeBSD

Andrew Turner added the comment: Can this be applied? -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue24520] Stop using deprecated floating-point environment functions on FreeBSD

STINNER Victor added the comment: It looks like fpsetmask() was deprecated since many years, and that fedisableexcept() is available since FreeBSD 5.3. Since we try to support FreeBSD 9, it's fine to drop support of FreeBSD < 5.3. I'm concerned by the "CAVEATS" section below. Should we put

[issue24520] Stop using deprecated floating-point environment functions on FreeBSD

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___

[issue24520] Stop using deprecated floating-point environment functions on FreeBSD

Stefan Krah added the comment: Regarding volatile: gcc/clang seem to honor *some* changes to the control word. At least in libmpdec both compilers have always left the settings 80bit-prec/ROUND_CHOP intact, even though it's not the default. Let's rewrite Python in asm to avoid these issues. :)

[issue24520] Stop using deprecated floating-point environment functions on FreeBSD

Stefan Krah added the comment: In theory we should set FENV_ACCESS whenever the control word is changed (C99): "If part of a program tests floating-point status flags, sets floating-point control modes, or runs under non-default mode settings, but was translated with the state for the

[issue24520] Stop using deprecated floating-point environment functions on FreeBSD

STINNER Victor added the comment: FYI in Python/pytime.c, I put a lot of "volatile double" when tests started to fail on some platforms. It's inefficient, but it's easier than teaching how to disable optimizations on each different compiler :-p --

[issue24520] Stop using deprecated floating-point environment functions on FreeBSD

Stefan Krah added the comment: Ok, clang does not support it either: https://llvm.org/bugs/show_bug.cgi?id=10409 -- ___ Python tracker ___

[issue24520] Stop using deprecated floating-point environment functions on FreeBSD

STINNER Victor added the comment: Sorry, I don't understand if we should apply or not the patch :-/ -- ___ Python tracker ___

[issue24520] Stop using deprecated floating-point environment functions on FreeBSD

Changes by Terry J. Reedy tjre...@udel.edu: -- nosy: +mark.dickinson ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24520 ___ ___ Python-bugs-list

[issue24520] Stop using deprecated floating-point environment functions on FreeBSD

Changes by Ed Maste carpedd...@gmail.com: -- nosy: +emaste ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24520 ___ ___ Python-bugs-list mailing

[issue24520] Stop using deprecated floating-point environment functions on FreeBSD

Changes by koobs koobs.free...@gmail.com: -- keywords: +needs review nosy: +koobs ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24520 ___ ___

[issue24520] Stop using deprecated floating-point environment functions on FreeBSD

New submission from Andrew Turner: The attached patch moves to use the fenv functions on FreeBSD to control the floating-point environment. This will be needed as I don't expect FreeBSD will have these functions on arm64. I would expect a similar change should be applied to any supported