[issue24539] StreamReaderProtocol.eof_received() should return True to keep the transport open

2017-12-20 Thread Andrew Svetlov 

Andrew Svetlov  added the comment:

Done two years ago.

--
nosy: +asvetlov
resolution:  -> fixed
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24539] StreamReaderProtocol.eof_received() should return True to keep the transport open

2015-10-31 Thread Aymeric Augustin 

Aymeric Augustin added the comment:

This change appears to have caused a non-obvious regression in `websockets`: 
https://github.com/aaugustin/websockets/issues/76

Perhaps I was relying on an implementation detail but that's annoying 
nonetheless.

--
nosy: +aymeric.augustin

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24539] StreamReaderProtocol.eof_received() should return True to keep the transport open

2015-10-31 Thread STINNER Victor 

STINNER Victor added the comment:

"Victor, is there a reason this issue is still open?  Is it because of the 
warnings question?  Maybe that should be a new issue?"

I just merged from Github to CPython. I don't know if something remains to do 
in this issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24539] StreamReaderProtocol.eof_received() should return True to keep the transport open

2015-10-31 Thread R. David Murray 

R. David Murray added the comment:

Well, asyncio was still provisional, so annoyances like this were bound to 
happen occasionally.

Victor, is there a reason this issue is still open?  Is it because of the 
warnings question?  Maybe that should be a new issue?

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24539] StreamReaderProtocol.eof_received() should return True to keep the transport open

2015-10-31 Thread Guido van Rossum 

Guido van Rossum added the comment:

Well, the warning points to a deeper issue -- the fix doesn't work for TLS
connections. Also, the upstream issue (
https://github.com/python/asyncio/issues/251) is still open because there's
no test for this behavior.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24539] StreamReaderProtocol.eof_received() should return True to keep the transport open

2015-10-31 Thread R. David Murray 

R. David Murray added the comment:

Ah, I thought Victor was saying he'd done the unit test; I guess he just meant 
he'd done the merge.

--
stage:  -> needs patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24539] StreamReaderProtocol.eof_received() should return True to keep the transport open

2015-07-24 Thread Roundup Robot 

Roundup Robot added the comment:

New changeset fc1d40a706e7 by Victor Stinner in branch '3.4':
asyncio: sync with github
https://hg.python.org/cpython/rev/fc1d40a706e7

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24539
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24539] StreamReaderProtocol.eof_received() should return True to keep the transport open

2015-07-24 Thread STINNER Victor 

STINNER Victor added the comment:

 but it still needs a unittest and merging into CPython 3.4 and up.

I did this part.

By the way, running unit tests now logs two warnings on SSL tests, because 
returning True has no effect on SSL. We may just remove the warning at runtime 
and ensure that it's well documented instead. What do you think?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24539
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24539] StreamReaderProtocol.eof_received() should return True to keep the transport open

2015-07-14 Thread Guido van Rossum 

Guido van Rossum added the comment:

I've added the return True from eof_received() to the asyncio repo 
(https://github.com/python/asyncio/commit/ce3ad816a2ef9456b4b1c26b99dfc85ea1236811),
 but it still needs a unittest and merging into CPython 3.4 and up.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24539
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24539] StreamReaderProtocol.eof_received() should return True to keep the transport open

2015-07-04 Thread Drekin 

Drekin added the comment:

I've also been hit by this issue, see 
https://mail.python.org/pipermail/python-list/2015-July/693496.html and the 
following thread. I've spent some time trying to find where the problem is, and 
just after I found out it's about eof_received() returning None, I could found 
this issue. :-)

--
nosy: +Drekin

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24539
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24539] StreamReaderProtocol.eof_received() should return True to keep the transport open

2015-06-30 Thread Guido van Rossum 

New submission from Guido van Rossum:

See https://github.com/python/asyncio/issues/251. I'm on vacation and may or 
may not find the time to actually fix this (it needs a unittest written).

--
components: asyncio
messages: 245986
nosy: gvanrossum, haypo, yselivanov
priority: normal
severity: normal
status: open
title: StreamReaderProtocol.eof_received() should return True to keep the 
transport open
versions: Python 3.4, Python 3.5, Python 3.6

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24539
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com