[issue2454] sha and md5 fixer

2019-09-25 Thread Christian Heimes 


Christian Heimes  added the comment:

The issue is already fixed. Python 3.7+ no longer import the md5 module 
directly.

--
nosy: +christian.heimes
resolution:  -> out of date
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2454] sha and md5 fixer

2012-11-23 Thread Meador Inge 

Meador Inge added the comment:

 I'm not sure how much this is needed considering hashlib has been around, 
 since 2.5.
 I hope people aren't having to port from before then.

Martin alluded to that when he opened the issue saying this wasn't necessary, 
but a nice
to have.  However, it has been over four years since the issue was opened.  
Maybe it
should just be closed.  I don't really have an opinion either way.

Martin, are you still interested in this?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2454
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2454] sha and md5 fixer

2012-11-23 Thread Gregory P. Smith 

Gregory P. Smith added the comment:

Any code conversion is useful. This will help with old libraries and is
even good for just updating old 2.4 code to 2.7 best practices.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2454
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2454] sha and md5 fixer

2012-11-22 Thread Benjamin Peterson 

Benjamin Peterson added the comment:

I'm not sure how much this is needed considering hashlib has been around, since 
2.5. I hope people aren't having to port from before then.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2454
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2454] sha and md5 fixer

2012-11-21 Thread Meador Inge 

Meador Inge added the comment:

Attached is a refreshed patch that works for all active branches.  The only 
real change from the original is Éric's suggestion to s/hash/hashlib/.  The 'u' 
prefix isn't an issue any longer because of PEP 414.

Benjamin, does the attached look OK to you?  If so, then I will commit it.

--
assignee: benjamin.peterson - meador.inge
versions: +Python 2.7, Python 3.3, Python 3.4
Added file: http://bugs.python.org/file28070/issue2454-2.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2454
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2454] sha and md5 fixer

2012-11-09 Thread Ezio Melotti 

Ezio Melotti added the comment:

What's the status of this?

--
nosy: +ezio.melotti

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2454
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2454] sha and md5 fixer

2012-11-09 Thread Meador Inge 

Meador Inge added the comment:

I haven't touched the patch since I attached it.  I will refresh it today with 
the feedback given.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2454
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2454] sha and md5 fixer

2011-01-03 Thread Antoine Pitrou 

Changes by Antoine Pitrou pit...@free.fr:


--
assignee: collinwinter - benjamin.peterson

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2454
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2454] sha and md5 fixer

2010-07-24 Thread Mark Lawrence 

Mark Lawrence breamore...@yahoo.co.uk added the comment:

Can this be committed please.  In msg110796 I over-emphasised the technical 
aspects, the patch is actually against 2to3.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2454
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2454] sha and md5 fixer

2010-07-24 Thread Éric Araujo 

Éric Araujo mer...@netwok.org added the comment:

Minor nit: I suggest naming the fixer fix_hashlib, since the name fix_hash 
could easily be understood as something fixing __hash__ (even if such a fix is 
impossible for a machine to do).

This fix could also go into fix_imports, but it’s useful as a standalone fixer 
e.g. to run on code that drops 2.5 compatibility.

--
nosy: +merwok

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2454
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2454] sha and md5 fixer

2010-07-19 Thread Mark Lawrence 

Mark Lawrence breamore...@yahoo.co.uk added the comment:

The patch looks clean to me although I don't feel qualified to comment on the 
technical aspects.  I've tested it on Windows Vista 32 bit against the 2.7 and 
3.1 maintainance releases and py3k.  The 2.7 run was fine, both 3.x runs failed.

  File c:\release31-maint\lib\lib2to3\fixes\fix_hash.py, line 27
md5: umd5,
^
SyntaxError: invalid syntax

I've stared at the code until I'm blue in the face and can't see what's wrong, 
I'm sure someone else will spot the problem in seconds.

I also noticed a small typo in the rst file modules where deprecated
should read modules were deprecated.

--
nosy: +BreamoreBoy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2454
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2454] sha and md5 fixer

2010-07-19 Thread Dave Malcolm 

Dave Malcolm dmalc...@redhat.com added the comment:

The 'u' prefix went away in Python 3, use an unadorned '' or  for a unicode 
value.

$ python3
Python 3.1.2 (r312:79147, May 25 2010, 12:21:57) 
[GCC 4.4.3 20100422 (Red Hat 4.4.3-18)] on linux2
Type help, copyright, credits or license for more information.
 ufoo
  File stdin, line 1
ufoo
 ^
SyntaxError: invalid syntax

--
nosy: +dmalcolm

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2454
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2454] sha and md5 fixer

2010-07-19 Thread Mark Lawrence 

Mark Lawrence breamore...@yahoo.co.uk added the comment:

I've successfully rerun the tests for 3.x having stripped the 'u' prefix.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2454
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2454] sha and md5 fixer

2010-01-31 Thread Meador Inge 

Meador Inge mead...@gmail.com added the comment:

Attached a patch that provides a (sha | md5) - hashlib fixer, covering test 
cases, and updated documentation.

--
keywords: +patch
nosy: +minge
Added file: http://bugs.python.org/file16079/issue-2454.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2454
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2454] sha and md5 fixer

2010-01-31 Thread Brian Curtin 

Changes by Brian Curtin cur...@acm.org:


--
components:  -2to3 (2.x to 3.0 conversion tool)
stage:  - patch review
type:  - behavior

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2454
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2454] sha and md5 fixer

2010-01-31 Thread Martin v . Löwis 

Changes by Martin v. Löwis mar...@v.loewis.de:


--
components: +2to3 (2.x to 3.0 conversion tool)

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2454
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2454] sha and md5 fixer

2009-02-10 Thread Daniel Diniz 

Changes by Daniel Diniz aja...@gmail.com:


--
nosy: +benjamin.peterson

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2454
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2454] sha and md5 fixer

2008-12-08 Thread Armin Ronacher 

Changes by Armin Ronacher [EMAIL PROTECTED]:


--
nosy: +aronacher

___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2454
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2454] sha and md5 fixer

2008-04-08 Thread Collin Winter 

Changes by Collin Winter [EMAIL PROTECTED]:


--
priority:  - normal

__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2454
__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2454] sha and md5 fixer

2008-03-21 Thread Benjamin Peterson 

Changes by Benjamin Peterson [EMAIL PROTECTED]:


--
title: md5 fixer - sha and md5 fixer

__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2454
__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com