[issue24683] Type confusion in json encoding

paul added the comment: Sorry, I wasn't clear enough. This POC is a proof that the original bug can be used for EIP control. I just checked and it works as advertised on 2.7 revision: https://hg.python.org/cpython/rev/2d39777f3477 - it's a parent of

[issue24683] Type confusion in json encoding

Serhiy Storchaka added the comment: The same result on 2.7 branch: $ ./python ../cpython/eip.py Traceback (most recent call last): File "../cpython/eip.py", line 21, in e = j.make_encoder(markers, None, enc, 4, "ks", "is", False, True, True) TypeError: make_encoder() argument 1 must be

[issue24683] Type confusion in json encoding

paul added the comment: Can you try on 2.7 branch? -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue24683] Type confusion in json encoding

Serhiy Storchaka added the comment: I can't reproduce your example paul. $ ./python eip.py Traceback (most recent call last): File "eip.py", line 21, in e = j.make_encoder(markers, None, enc, 4, "ks", "is", False, True, True) TypeError: make_encoder() argument 1 must be dict or None,

[issue24683] Type confusion in json encoding

paul added the comment: Proof of EIP control. -- Added file: http://bugs.python.org/file41719/eip.py ___ Python tracker ___

[issue24683] Type confusion in json encoding

paul added the comment: GDB dump of running ./python eip.py ___ eax:37A317DD ebx:B7A54268 ecx:BFFFE22C edx:11223344 eflags:00010217 esi:B7A61060 edi:B7AA6714 esp:BFFFE20C ebp:B7A317DC eip:11223344

[issue24683] Type confusion in json encoding

Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com: -- nosy: +Arfrever ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24683 ___

[issue24683] Type confusion in json encoding

paul added the comment: resolution: not a bug ^ because of private API? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24683 ___ ___

[issue24683] Type confusion in json encoding

Roundup Robot added the comment: New changeset b3d0bf112f70 by Serhiy Storchaka in branch '3.4': Issue #24683: Fixed crashes in _json functions called with arguments of https://hg.python.org/cpython/rev/b3d0bf112f70 New changeset ef4d09399b99 by Serhiy Storchaka in branch '3.5': Issue #24683:

[issue24683] Type confusion in json encoding

Roundup Robot added the comment: New changeset 0a1266ef1b5d by Serhiy Storchaka in branch '2.7': Issue #24683: Fixed a crash in _json.make_encoder() called with non-dict 1st argument. https://hg.python.org/cpython/rev/0a1266ef1b5d -- ___ Python

[issue24683] Type confusion in json encoding

Serhiy Storchaka added the comment: Thank you for your report paul. Thanks for review Raymond. -- resolution: - not a bug stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org

[issue24683] Type confusion in json encoding

Serhiy Storchaka added the comment: There is similar issue with key_separator and item_separator in 3.x. They are used with _PyAccu_Accumulate that performs a type check only in assert(). Here is a patch. -- keywords: +patch stage: needs patch - patch review versions: +Python 2.7,

[issue24683] Type confusion in json encoding

Raymond Hettinger added the comment: Patch LGTM. -- nosy: +rhettinger ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24683 ___ ___ Python-bugs-list

[issue24683] Type confusion in json encoding

STINNER Victor added the comment: I don't understand the issue. Can you elaborate? What is your code? What is the current result? What is the expected result? What is your platform? What is your Python version? etc. -- nosy: +haypo ___ Python

[issue24683] Type confusion in json encoding

paul added the comment: Sorry, I uploaded a test case. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24683 ___ ___ Python-bugs-list mailing

[issue24683] Type confusion in json encoding

New submission from paul: on-35dm-i386-linux-gnu.so`encoder_listencode_list(s=0xb6f90394, acc=0xbfc42c28, seq=0xb6f2361c, indent_level=1) + 655 at _json.c:1800 # frame #2: 0xb6e4366d _json.cpython-35dm-i386-linux-gnu.so`encoder_listencode_obj(s=0xb6f90394, acc=0xbfc42c28, obj=0xb6f2361c,

[issue24683] Type confusion in json encoding

Changes by Serhiy Storchaka storch...@gmail.com: -- assignee: - serhiy.storchaka components: +Extension Modules nosy: +serhiy.storchaka stage: - needs patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24683

[issue24683] Type confusion in json encoding

Changes by paul paw...@gmail.com: Added file: http://bugs.python.org/file39975/json_markers.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24683 ___ ___

[issue24683] Type confusion in json encoding

Ronald Oussoren added the comment: In encoder_init (the __init__ for _json.Encoder) s-marker is set to an argument of __init__, without any kind of type check, it can therefore be an arbitrary object. encoder_listencode_obj (and other functions) then use s-markers with the concrete API for