[issue24744] Lack of type checks in pkgutil.walk_packages and friends

R. David Murray added the comment: Thanks, Sanyam. -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker ___

[issue24744] Lack of type checks in pkgutil.walk_packages and friends

R. David Murray added the comment: New changeset b9c3da5c89c66dcccf382e8f196746da2a06d4cc by R. David Murray (Sanyam Khurana) in branch 'master': bpo-24744: Raises error in pkgutil.walk_packages if path is str (#1926)

[issue24744] Lack of type checks in pkgutil.walk_packages and friends

R. David Murray added the comment: In thinking about merging this, I realize something I should have thought about earlier: we are proposing to raise an error where none was previously raised. Now, any code that would hit this would be broken, but nonetheless, by our backward compatibility

[issue24744] Lack of type checks in pkgutil.walk_packages and friends

Sanyam Khurana added the comment: I've updated the PR with required changes along with the test. Please have a look and let me know if any changes are needed. -- ___ Python tracker

[issue24744] Lack of type checks in pkgutil.walk_packages and friends

R. David Murray added the comment: As I mentioned on the PR I think it should be a ValueError, and that the PR also needs tests. -- ___ Python tracker

[issue24744] Lack of type checks in pkgutil.walk_packages and friends

Changes by Sanyam Khurana : -- pull_requests: +2006 ___ Python tracker ___ ___

[issue24744] Lack of type checks in pkgutil.walk_packages and friends

Sanyam Khurana added the comment: Hi r.david.murray, What error do you think should be raised in this case, when path is an instance of str? I'll issue a PR once I know what end results are expected. -- nosy: +CuriousLearner ___ Python tracker

[issue24744] Lack of type checks in pkgutil.walk_packages and friends

New submission from Cal Leeming: The documentation states that pkgutil.walk_packages() path must be None or a list of paths [1]. After passing in a string, the result was a blank list rather than a type error or automatic conversion to a list. If this method is documented that it must only

[issue24744] Lack of type checks in pkgutil.walk_packages and friends

R. David Murray added the comment: Well, normally no, we don't use type checks. On the other hand, having it produce an incorrect result rather than an error of *some* sort is not so good (the problem is that it is ultimately calling map(func, path), and map happily iterates the string