[issue24750] IDLE: Cosmetic improvements for main window

Terry J. Reedy added the comment: Applied as 288e97680d84 (with # -> * typo): first ttk widgets. Issue *24750: Switch all scrollbars in IDLE to ttk versions. Where needed, add minimal tests to cover changes. -- resolution: -> fixed stage: commit review -> resolved status: open ->

[issue24750] IDLE: Cosmetic improvements for main window

Changes by Terry J. Reedy : Added file: http://bugs.python.org/file43327/ttk-scrollbar.diff ___ Python tracker ___

[issue24750] IDLE: Cosmetic improvements for main window

Terry J. Reedy added the comment: Revised plan: use ttk in 3.6 and only 3.6. I will revise scroll patch for new file names, retest, and apply if good. -- assignee: -> terry.reedy stage: needs patch -> commit review versions: -Python 3.5 ___

[issue24750] IDLE: Cosmetic improvements for main window

Roundup Robot added the comment: New changeset ff31af003c35 by Terry Jan Reedy in branch '2.7': Issue #24750: Improve appearance of IDLE editor window status bar. https://hg.python.org/cpython/rev/ff31af003c35 New changeset ecb74f61a5d4 by Terry Jan Reedy in branch '3.4': Issue #24750: Improve

[issue24750] IDLE: Cosmetic improvements for main window

Terry J. Reedy added the comment: Leaving open for now for scrollbar upgrade. -- ___ Python tracker ___ ___

[issue24750] IDLE: Cosmetic improvements for main window

Mark Roseman added the comment: Sounds like this one should be ready to review and incorporate. As a reminder, mainwin3.patch, which should work on Tk 8.4+, gets rid of the highlightthickness around the text widget in the editor, the sunken line/column effect in the status bar, and adds a

[issue24750] IDLE: Cosmetic improvements for main window

Serhiy Storchaka added the comment: Oh, I were wrong. 8.4 still is supported in 3.5. The support of 8.3 was dropped. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24750 ___

[issue24750] IDLE: Cosmetic improvements for main window

Mark Roseman added the comment: I'm attaching mainwin3.patch, which is a subset of the previous patches, modified to not use ttk. It gets rid of the highlightthickness, the sunken line/column effect, and adds a thin separator below the text widget. -- Added file:

[issue24750] IDLE: Cosmetic improvements for main window

Terry J. Reedy added the comment: Back to Editor Windows: I have a new idea for the status bar First: move ln, col to the left, replace the label with a label + entry box. If someone edits the line number and hits return (or just leaves the box?), jump to the line. Treat negative numbers as

[issue24750] IDLE: Cosmetic improvements for main window

Serhiy Storchaka added the comment: Ah, ttk detection doesn't work this way. ImportError is not raised on import, and TclError is raised instead on widget creation. Here is a patch for 3.4 that is compatible with 8.4 (tested). @scroll.diff LGTM for 3.5+. -- Added file:

[issue24750] IDLE: Cosmetic improvements for main window

Terry J. Reedy added the comment: Minor nit: you import 'ttkcompat' and add 'compat'. On to the new 'compat': the only doc for .setup_master is the docstring If master is not None, itself is returned. If master is None, the default master is returned if there is one, otherwise a new

[issue24750] IDLE: Cosmetic improvements for main window

Mark Roseman added the comment: While I think this approach would largely be a bad idea for an IDLE-sized application, where I think it definitely would be useful is in something very restricted like the tkSimpleDialog code. To improve the various little 'askstring', 'askinteger' etc.

[issue24750] IDLE: Cosmetic improvements for main window

Terry J. Reedy added the comment: Keep in mind that most option substitution would be at the file rather than widget level. The scrollbar switching would be for something like editor windows, which are basically generic. For the option dialog, we would copy ConfigDialog.py to, say,

[issue24750] IDLE: Cosmetic improvements for main window

Serhiy Storchaka added the comment: I would use optional import to support Tcl/Tk older than 8.5 in Python 3.4 and 2.7. try: from tkinter.ttk import Scrollbar except ImportError: pass -- nosy: +serhiy.storchaka ___ Python tracker

[issue24750] IDLE: Cosmetic improvements for main window

Serhiy Storchaka added the comment: Yes, but setting the highlightthickness option can be optional too. self.scrollbarView = Scrollbar(frameText, orient=VERTICAL, takefocus=FALSE) try: self.scrollbarView['highlightthickness'] = 0 except

[issue24750] IDLE: Cosmetic improvements for main window

Terry J. Reedy added the comment: That does not work. ttk widgets are not drop-in replacements for their predecessors. The problem is illustrated by these lines from the TextViewer patch -self.scrollbarView = Scrollbar(frameText, orient=VERTICAL, -

[issue24750] IDLE: Cosmetic improvements for main window

Raymond Hettinger added the comment: The last version of the patch works well for me and has a nice, elegant look. -- nosy: +rhettinger ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24750

[issue24750] IDLE: Cosmetic improvements for main window

Terry J. Reedy added the comment: Mark: Serhiy is asking that we not make the change to maintenance releases, 2.7 and 3.4, without further discussion and agreement. He is correct to do so. I reread PEP 434 and it specifically says The PEP would apply to ..., but not necessarily to possible

[issue24750] IDLE: Cosmetic improvements for main window

Terry J. Reedy added the comment: On Idle-sig, in 'ttk appearance' Mark posted before and after screenshots of Preferences Font tab for Windows, Linux, and Mac http://www.tkdocs.com/images/idle_cfgfont_ttk.png Glyph, who I never knew read Idle-sig, calls the after shots great (I think he has a

[issue24750] IDLE: Cosmetic improvements for main window

Mark Roseman added the comment: Serhiy, I appreciate what you're saying, but special casing to handle both ttk and non-ttk cases seems not feasible given the amount of resources available to enhance/maintain IDLE. Additionally, part of the rationale for making these changes is to simplify the

[issue24750] IDLE: Cosmetic improvements for main window

Mark Roseman added the comment: I'll raise the practical matter that ActiveState no longer distributes 8.4.x as part of its Community edition ActiveTcl, though I presume it would be available as part of its for-fee Business version. Therefore if someone wants to use Python on 10.5, it would

[issue24750] IDLE: Cosmetic improvements for main window

Mark Roseman added the comment: Ned, quick question... if there is a tcl/tk 8.5.x on the system, will the 32 bit prebuilt distros link with it, or only with a 8.4.x version? -- ___ Python tracker rep...@bugs.python.org

[issue24750] IDLE: Cosmetic improvements for main window

Terry J. Reedy added the comment: For years there have been people who want to remove Idle from the stdlib for all distributions, not just the OS 10.5 release. Even Guido is now having thoughts along this line. One of the reasons is appearance. Not improving that will make it more likely

[issue24750] IDLE: Cosmetic improvements for main window

Ned Deily added the comment: Ned, Mark will be opening several appearance issues (see ttk thread on Idle list). Do you want to be routinely added as nosy to comment? No, that's not necessary or desirable. At the moment, I don't think I have much bandwidth or expertise to contribute to

[issue24750] IDLE: Cosmetic improvements for main window

Terry J. Reedy added the comment: ttk is not available with 8.4 (except maybe with the tile extension, but I believe some changes were made before it was incorporated in 8.4 as ttk). As I mentioned on the ttk thread on idle-sig, it was agreed in a pydev discusion a couple of years ago or so

[issue24750] IDLE: Cosmetic improvements for main window

Mark Roseman added the comment: Sounds good. To clarify, (2) refers to not the overall window, but just around the text widget. Both regarding this and the comments regarding status bar (4), things look really good now on Windows. The changes I've made are barely perceptible there, but

[issue24750] IDLE: Cosmetic improvements for main window

Mark Roseman added the comment: Great. Sent in the contributor agreement Monday so I assume it should percolate through soon. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24750 ___

[issue24750] IDLE: Cosmetic improvements for main window

Terry J. Reedy added the comment: Looks fine on Windows. Now to be picky: Is it possible to move 'Col:' to the left, leaving space to the right, so that 'Col:' does not move when going from 9 to 10? Ditto for 'Ln:'? -- ___ Python tracker

[issue24750] IDLE: Cosmetic improvements for main window

Mark Roseman added the comment: The attached mainwin.patch implements these few small changes (except for removing the Mac grow box space); checked active/inactive on Mac, Windows, Linux. -- keywords: +patch Added file: http://bugs.python.org/file40070/mainwin.patch

[issue24750] IDLE: Cosmetic improvements for main window

Terry J. Reedy added the comment: I added a dependency to gracefully exit when no ttk. Mark: If you have not yet, please sign PSF Contributor Agreement before submitting further patches. https://www.python.org/psf/contrib/ https://www.python.org/psf/contrib/contrib-form/ I now see what you

[issue24750] IDLE: Cosmetic improvements for main window

Terry J. Reedy added the comment: I patched the other scrollbars for 3.4 and verified the expected appearance change. For 2.7, with 8.5.15, I so not see any difference. Is this what I should expect on Windows? Did ttk.Scrollbar only use the Win7 scrollbar in 8.6? --

[issue24750] IDLE: Cosmetic improvements for main window

Mark Roseman added the comment: The mainwin2.patch keeps the width of the fields constant. Thanks! -- Added file: http://bugs.python.org/file40071/mainwin2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24750

[issue24750] IDLE: Cosmetic improvements for main window

Terry J. Reedy added the comment: I assume that change should be apparent on 2.7 with other system, but I'd like to make sure that I have not missed anything. I am otherwise ready to commit these. -- Added file: http://bugs.python.org/file40075/@scroll.diff

[issue24750] IDLE: Cosmetic improvements for main window

Terry J. Reedy added the comment: Hmm, the problem with maxsize = constant is occasionally losing a trailing digit or two. For instance, if one enters 8**, one might be interested in the number of digits and put cursor at end of wrapped line. But trailing 7 of 2007 is missing. Is there

[issue24750] IDLE: Cosmetic improvements for main window

Changes by Terry J. Reedy tjre...@udel.edu: Added file: http://bugs.python.org/file40074/@scroll27.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24750 ___

[issue24750] IDLE: Cosmetic improvements for main window

New submission from Mark Roseman: The screen shot shows the current version of the main IDLE window, with the little pics at the bottom indicating what it looks like when the window loses focus. A few entirely cosmetic changes I'd like to make here: 1. Swap scrollbar for ttk scrollbar; this

[issue24750] IDLE: Cosmetic improvements for main window

Terry J. Reedy added the comment: Ned, Mark will be opening several appearance issues (see ttk thread on Idle list). Do you want to be routinely added as nosy to comment? Mark: The description and labeling of the screenshot is a bit off. For Windows, the full window is inactive ([ x ] is not