[issue24766] Subclass of property doesn't preserve instance __doc__ when using doc= argument

Irit Katriel added the comment: Reproduced on 3.11. -- nosy: +iritkatriel versions: +Python 3.11 -Python 3.5, Python 3.6 ___ Python tracker ___

[issue24766] Subclass of property doesn't preserve instance __doc__ when using doc= argument

Changes by Erik Bray : -- pull_requests: +2546 ___ Python tracker ___ ___

[issue24766] Subclass of property doesn't preserve instance __doc__ when using doc= argument

Erik Bray added the comment: Thanks for the updated patch. LGTM. -- ___ Python tracker ___ ___

[issue24766] Subclass of property doesn't preserve instance __doc__ when using doc= argument

Berker Peksag added the comment: test_property_decorator_doc_writable fix has already been committed in cc1aa0e88626. Here's an updated patch: * Synced with the default branch * Adapted the test from duplicate issue 25757 (written by Torsten Landschoff) -- nosy: +berker.peksag,

[issue24766] Subclass of property doesn't preserve instance __doc__ when using doc= argument

Erik Bray added the comment: Actually, of course that test would fail when run repeatedly--it sets the property docstring from 'Eggs' to 'Spam' on the first run, but then doesn't set it back to its original value. Since the PropertyWritableDocs class used in that test is module-level it

[issue24766] Subclass of property doesn't preserve instance __doc__ when using doc= argument

Erik Bray added the comment: Attached an additional patch to test_property_decorator_doc_writable so that it can pass on repeated runs. -- Added file: http://bugs.python.org/file40504/property-doc-test2.patch ___ Python tracker

[issue24766] Subclass of property doesn't preserve instance __doc__ when using doc= argument

Ethan Furman added the comment: Thanks for checking that out, Erik. I was hoping it was a testing issue, but I ran out of time to verify. -- ___ Python tracker

[issue24766] Subclass of property doesn't preserve instance __doc__ when using doc= argument

Changes by Ethan Furman : -- nosy: -larry ___ Python tracker ___ ___ Python-bugs-list

[issue24766] Subclass of property doesn't preserve instance __doc__ when using doc= argument

Ethan Furman added the comment: ethan@code:~/source/python/issue25147$ ./python -m test.regrtest -R3:3 test_property [1/1] test_property Eggs # from print() inside test beginning 6 repetitions 123456 Spam # the new value from the previous run seems stuck test test_property failed --

[issue24766] Subclass of property doesn't preserve instance __doc__ when using doc= argument

Erik Bray added the comment: Sorry for the hold up. Attached is another diff providing a test. I think this is all that's really needed (since this is just a special case of the issue already tested for in this particular test class. -- Added file:

[issue24766] Subclass of property doesn't preserve instance __doc__ when using doc= argument

Ethan Furman added the comment: Larry, can we get this into 3.5? I'll create a pull-request in a couple days. -- nosy: +larry ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24766 ___

[issue24766] Subclass of property doesn't preserve instance __doc__ when using doc= argument

Changes by Serhiy Storchaka storch...@gmail.com: -- nosy: +r.david.murray ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24766 ___ ___

[issue24766] Subclass of property doesn't preserve instance __doc__ when using doc= argument

Changes by Ethan Furman et...@stoneleaf.us: -- nosy: +ethan.furman ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24766 ___ ___ Python-bugs-list

[issue24766] Subclass of property doesn't preserve instance __doc__ when using doc= argument

Ethan Furman added the comment: Looks good so far. Let's get some tests in place. -- stage: - test needed type: - behavior versions: +Python 3.5, Python 3.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24766

[issue24766] Subclass of property doesn't preserve instance __doc__ when using doc= argument

New submission from Erik Bray: This issue is directly related to http://bugs.python.org/issue5890, the solution to which I think was incomplete. The examples below use a trivial subclass of property (but apply as well to a less trivial one): class myproperty(property): pass ... When using