[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

Roundup Robot added the comment: New changeset fca720360f87f6dd2cd2030f7f98f689809c45d9 by Vinay Sajip in branch '3.5': Fixes #24875: pip can now be installed in a venv with --system-site-packages. https://github.com/python/cpython/commit/fca720360f87f6dd2cd2030f7f98f689809c45d9 --

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

Roundup Robot added the comment: New changeset fca720360f87f6dd2cd2030f7f98f689809c45d9 by Vinay Sajip in branch '3.6': Fixes #24875: pip can now be installed in a venv with --system-site-packages. https://github.com/python/cpython/commit/fca720360f87f6dd2cd2030f7f98f689809c45d9 New changeset

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

Roundup Robot added the comment: New changeset fca720360f87f6dd2cd2030f7f98f689809c45d9 by Vinay Sajip in branch 'master': Fixes #24875: pip can now be installed in a venv with --system-site-packages. https://github.com/python/cpython/commit/fca720360f87f6dd2cd2030f7f98f689809c45d9 New

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

Roundup Robot added the comment: New changeset 1bf1d36463b4 by Vinay Sajip in branch '3.5': Fixes #24875: pip can now be installed in a venv with --system-site-packages. https://hg.python.org/cpython/rev/1bf1d36463b4 New changeset 7d4701b4210f by Vinay Sajip in branch '3.6': Fixes #24875:

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

Mark Haase added the comment: Oh, sorry! I didn't realize you were a core dev or I would have replied sooner. Thank you for looking into this issue. -- ___ Python tracker

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

Vinay Sajip added the comment: > Any idea how we get a CPython dev to look at this patch? Well, I'm one of them, so ... :-) I will commit it soon, given that Thomas Nyberg has also given his feedback. It was just waiting for your comments ... --

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

Mark Haase added the comment: Vinay, thanks for the patch! I just tested it on my Ubuntu 16.04.1 box with Python 3.5.2 and it works perfectly. Your patch is cleaner than mine, too. Any idea how we get a CPython dev to look at this patch? -- ___

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

Vinay Sajip added the comment: Patch uploaded herewith. -- assignee: -> vinay.sajip stage: -> patch review Added file: http://bugs.python.org/file46283/issue-24875-01.diff ___ Python tracker

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

Thomas Nyberg added the comment: Hi Vinay, You should probably upload a patch with the changes you made (however trivial) if you want that version considered. Makes it easier to comment and can then point to it for others to consider. Cheers, Thomas --

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

Vinay Sajip added the comment: I see why I couldn't reproduce the problem - there's no pip installed in the site-packages of the Pythons I was testing with, so the problem didn't show up. Mark, can you apply the version of EnvBuilder.create that I posted in a message above and see if that

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

Mark Haase added the comment: Hey Thomas and Vinay, thanks for looking into this. Although I discovered this problem on my MacOS laptop 6 months ago, today I also reproduced this issue on my Ubuntu desktop. ``` /home/mhaase/Downloads $ mkdir temp /home/mhaase/Downloads $ cd temp

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

Vinay Sajip added the comment: Just a sanity check ... I can't reproduce the issue with the latest versions of Python (I haven't made any changes to the venv code): On Python 3.5: vinay@ubuntu:~/projects/python/3.5$ ./python Python 3.5.3rc1+ (3.5:d9a64d00a439, Jan 13 2017, 10:26:23) [GCC

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

Thomas Nyberg added the comment: Hi Vinay, I just checked and yes that code works fine on my end (debian 8 box). Personally, I think either this or Mark's second patch would be fine. Cheers, Thomas -- ___ Python tracker

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

Vinay Sajip added the comment: It seems simpler to do it all in EnvBuilder.create: def create(self, env_dir): """ Create a virtual environment in a directory. :param env_dir: The target directory to create an environment in. """ env_dir =

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

Changes by Thomas Nyberg : Removed file: http://bugs.python.org/file46250/venv_site_packages.patch ___ Python tracker ___

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

Thomas Nyberg added the comment: Hi Mark Haase, I've gone through both of your patches and they both work for me as they should. I'm not sure why the first one isn't working for you, since it works for me. That one seems like it's solving the problem the "right" way. In any case, the second

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

Thomas Nyberg added the comment: Now that I look over this thread again, I realize that my patch ended up basically evolving to being extremely similar to Mark Haase's. The only thing that I don't understand though is that he says that his shebangs are somehow messed up. For me the shebangs

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

Thomas Nyberg added the comment: I'm attaching a small patch (against the current hg master branch) that I believe solves the problem, however, I think it was quite hacky. Here is a walk-through of the logic. 1) If '--system-site-packages' is requested, then it is overrided initially in the

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

Changes by Jan Gosmann : -- nosy: +jgosmann ___ Python tracker ___ ___

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

Mark added the comment: I have the same problem on a standard installation of Python 3.5 (on OS X via Homebrew). This bug is almost a year old, and it is a doozy: it utterly defeats the purpose of --system-site-packages. In the hope of getting some momentum going, I tried out the option

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

Alex Champandard added the comment: I agree this makes --system-site-packages a useless option unless it's fixed. We just had many beginners install pyvenv's and get very confused because of this. Passing ensurepip a new option to force it to install within a venv I think would work. What

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

Vinay Sajip added the comment: I don't believe this is a pyvenv bug: pyvenv invokes bin/python -Im ensurepip --upgrade --default-pip -v which then terminates with Requirement already up-to-date: pip in /usr/lib/python3.4/site-packages as you can see from the console output. So the problem

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

Donald Stufft added the comment: You probably need to either pass --ignore-installed to pip when invoking it inside of venv, or you need to disable system_site_packages (internally to venv) until after pip is installed. -- ___ Python tracker

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

Changes by STINNER Victor : -- nosy: +vinay.sajip ___ Python tracker ___ ___

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

Georges Racinet added the comment: Hi, I have the same symptoms and noticed by accident that you can somewhat workaround it by running pyvenv twice: pyvenv /path/to/env && pyvenv --system-site-packages /path/to/env The first provides pip, the second does not destroy it. At least this works

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

New submission from Nicolas Demarchi: When Envbuilder creates a new virtualenv with system_site_packages=True, in the process of installing pip itself it actually doesn't install it inside the virtualenv because it is already there in the system. However when you do it manually using