[issue25112] Windows installer assigns non-existent icons to Python file types

Changes by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue25112] Windows installer assigns non-existent icons to Python file types

Roundup Robot added the comment: New changeset 4d0d987bf6a8 by Steve Dower in branch '3.5': Issues #25112: py.exe launcher is missing icons https://hg.python.org/cpython/rev/4d0d987bf6a8 -- nosy: +python-dev ___ Python tracker

[issue25112] Windows installer assigns non-existent icons to Python file types

Steve Dower added the comment: The file associations are actually part of the launcher, which *technically* is independent of the Python install it is bundled with. So it doesn't have any references to the Python install directory, and double-clicking Python files with shebang lines will work

[issue25112] Windows installer assigns non-existent icons to Python file types

Mark Mikofski added the comment: +1 I just wasted at least an hour on this. :( should have checked bugs first. Google says nothing, so I thought I was going crazy. I saw that py.exe had only one icon and that Python.File had c:\windows\py.exe, 1 while Python.CompiledFile had

[issue25112] Windows installer assigns non-existent icons to Python file types

Thijs van Dien added the comment: Thanks for the update. I'm not sure why the proper assignment of icons now depends on the installation of the Python launcher (py.exe). The icons are installed in the DLLs directory just like before. Perhaps I'm not familiar enough with the purpose of the

[issue25112] Windows installer assigns non-existent icons to Python file types

Thijs van Dien added the comment: On the other hand, if the launcher is somehow strictly necessary, then why is it optional? -- ___ Python tracker ___

[issue25112] Windows installer assigns non-existent icons to Python file types

New submission from Thijs van Dien: Whenever the Python launcher is selected, the installer sets the icon for common Python file extensions, i.e. .py, .pyc, .pyo, .pyw, .pyz and .pyzw. Formerly (under Python 3.4) the icons were located in DLLs in the Python installation directory. The new

[issue25112] Windows installer assigns non-existent icons to Python file types

Steve Dower added the comment: That is indeed what happened. The resource file for the launcher was not updated (or the update got lost... I was fairly sure I did it) Attached patch fixes it. -- assignee: -> steve.dower keywords: +patch stage: -> patch review Added file: