[issue25287] test_crypt fails on OpenBSD

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25287] test_crypt fails on OpenBSD

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 04c0a4038e8764f742de8505600b8ee97ee50776 by Serhiy Storchaka in 
branch '2.7':
[2.7] bpo-25287: Backport new tests for crypt and skip test_crypt on OpenBSD. 
(GH-4111). (#4112)
https://github.com/python/cpython/commit/04c0a4038e8764f742de8505600b8ee97ee50776


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25287] test_crypt fails on OpenBSD

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
pull_requests: +4082

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25287] test_crypt fails on OpenBSD

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset f52dff611cff2fb9e90340b4787eda50ab2d40c6 by Serhiy Storchaka in 
branch '3.6':
bpo-25287: Backport new tests for crypt and skip test_crypt on OpenBSD. (#4111)
https://github.com/python/cpython/commit/f52dff611cff2fb9e90340b4787eda50ab2d40c6


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25287] test_crypt fails on OpenBSD

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
pull_requests: +4081
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25287] test_crypt fails on OpenBSD

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

issue31664 fixes test_crypt in 3.7. In other versions the test should be just 
skipped on OpenBSD. Blowfish is the only method supported on OpenBSD, but it 
was not supported by the Python's crypt module.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25287] test_crypt fails on OpenBSD

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
nosy: +davin

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25287] test_crypt fails on OpenBSD

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

I have an OpenBSD VM.

--
components: +Library (Lib)
nosy: +jafo, serhiy.storchaka
resolution: out of date -> 
stage: resolved -> 
status: closed -> open
type:  -> behavior
versions: +Python 3.7 -Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25287] test_crypt fails on OpenBSD

[STINNER Victor]

STINNER Victor added the comment:

There is no more OpenBSD buildbot. I have no OpenBSD VM. I just close this old 
issue.

--
resolution:  -> out of date
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25287] test_crypt fails on OpenBSD

[Cédric Krier]

Changes by Cédric Krier :


--
nosy: +ced

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25287] test_crypt fails on OpenBSD

[STINNER Victor]

STINNER Victor added the comment:

Hum, the test now fails differently :-(

==
FAIL: test_methods (test.test_crypt.CryptTestCase)
--
Traceback (most recent call last):
  File 
"/home/python-builds/3.x.borja-openbsd-x86/build/Lib/test/test_crypt.py", line 
29, in test_methods
self.assertTrue(len(crypt.methods) >= 1)
AssertionError: False is not true

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25287] test_crypt fails on OpenBSD

[Roundup Robot]

Roundup Robot added the comment:

New changeset 4da7edbf78d4 by Victor Stinner in branch 'default':
Issue #25287: Don't add crypt.METHOD_CRYPT to crypt.methods if it's not
https://hg.python.org/cpython/rev/4da7edbf78d4

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25287] test_crypt fails on OpenBSD

[STINNER Victor]

New submission from STINNER Victor:

It looks like crypt.crypt('', crypt.METHOD_CRYPT) returns None. This method 
must be excluded from crypt.methods. Attached patch should fix the issue, but I 
didn't try it on OpenBSD.

Python 3.4-3.6 is affect, Python 2.7 is not affect (crypt.methods was 
introduced in Python 3).

http://buildbot.python.org/all/builders/x86%20OpenBSD%203.5/builds/186/steps/test/logs/stdio

test_saltedcrypt (test.test_crypt.CryptTestCase) ... ERROR

==
ERROR: test_saltedcrypt (test.test_crypt.CryptTestCase)
--
Traceback (most recent call last):
  File 
"/home/python-builds/3.5.borja-openbsd-x86/build/Lib/test/test_crypt.py", line 
23, in test_saltedcrypt
self.assertEqual(len(pw), method.total_size)
TypeError: object of type 'NoneType' has no len()

--

--
files: crypt_openbsd.patch
keywords: patch
messages: 251998
nosy: haypo
priority: normal
severity: normal
status: open
title: test_crypt fails on OpenBSD
versions: Python 3.4, Python 3.5, Python 3.6
Added file: http://bugs.python.org/file40639/crypt_openbsd.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25287] test_crypt fails on OpenBSD

[STINNER Victor]

Changes by STINNER Victor :


--
nosy: +rpointel

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com