[issue25404] ssl.SSLcontext.load_dh_params() does not handle unicode filenames properly

[Christian Heimes]

Change by Christian Heimes :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25404] ssl.SSLcontext.load_dh_params() does not handle unicode filenames properly

[Christian Heimes]

Christian Heimes  added the comment:


New changeset 6e8f395001b026daea047cf225dcca5a973ae824 by Christian Heimes in 
branch '2.7':
bpo-25404: SSLContext.load_dh_params() non-ASCII path (GH-3459)
https://github.com/python/cpython/commit/6e8f395001b026daea047cf225dcca5a973ae824


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25404] ssl.SSLcontext.load_dh_params() does not handle unicode filenames properly

[Christian Heimes]

Changes by Christian Heimes :


--
keywords: +patch
pull_requests: +3453

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25404] ssl.SSLcontext.load_dh_params() does not handle unicode filenames properly

[Christian Heimes]

Changes by Christian Heimes :


--
assignee:  -> christian.heimes
keywords:  -patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25404] ssl.SSLcontext.load_dh_params() does not handle unicode filenames properly

[Christian Heimes]

Christian Heimes added the comment:

Patch welcome :)

--
assignee: christian.heimes -> 
keywords: +easy (C)

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25404] ssl.SSLcontext.load_dh_params() does not handle unicode filenames properly

[Christian Heimes]

Changes by Christian Heimes :


--
assignee:  -> christian.heimes
components: +SSL
nosy: +christian.heimes

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25404] ssl.SSLcontext.load_dh_params() does not handle unicode filenames properly

[Christian Heimes]

Changes by Christian Heimes :


--
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25404] ssl.SSLcontext.load_dh_params() does not handle unicode filenames properly

[Michael Schlenker]

Michael Schlenker added the comment:

Yes, the workaround works.

Would be nice if this could be fixed in a 2.7.11...

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25404] ssl.SSLcontext.load_dh_params() does not handle unicode filenames properly

[STINNER Victor]

STINNER Victor added the comment:

Right. The workaround is to encode manually the filename:

filename = filename.encode(sys.getfilesystemencoding())

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25404] ssl.SSLcontext.load_dh_params() does not handle unicode filenames properly

[STINNER Victor]

Changes by STINNER Victor :


--
components: +Unicode, Windows
nosy: +ezio.melotti, haypo, paul.moore, steve.dower, tim.golden, zach.ware

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25404] ssl.SSLcontext.load_dh_params() does not handle unicode filenames properly

[Michael Schlenker]

New submission from Michael Schlenker:

The load_dh_params() method of SSLContext does not properly handle unicode 
filenames on Windows (like load_verify_location() does).

It should convert any passed unicode path to the filesystem encoding.

This is already fixed in the 3.x head revision, by loading the file via python 
instead of the OpenSSL BIO functions, but is broken in 2.7.10.

Currently it silently works for most files due to an implicit conversion to 
string, but with the wrong default encoding instead of filesystem encoding.

--
components: Extension Modules
messages: 252987
nosy: schlenk
priority: normal
severity: normal
status: open
title: ssl.SSLcontext.load_dh_params() does not handle unicode filenames 
properly
type: behavior
versions: Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com