[issue25847] CPython not using Visual Studio code analysis!

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___

[issue25847] CPython not using Visual Studio code analysis!

Christian Heimes added the comment: Coverity Scan has two steps. In the first step the code is compiled with the coverity tool chain. It's a wrapper around the preprocessor and compiler. Next up the result is uploaded and analyzed by a service. So yes, the project needs to be build before it

[issue25847] CPython not using Visual Studio code analysis!

Steve Dower added the comment: Does it only check built code? I thought it would statically analyze everything? Is MS_WINDOWS code excluded, because that would explain why it "misses" issues. -- ___ Python tracker

[issue25847] CPython not using Visual Studio code analysis!

Christian Heimes added the comment: +1, if somebody is able to find time. Coverity Scan checks only X86_64 Linux builds. -- ___ Python tracker ___

[issue25847] CPython not using Visual Studio code analysis!

Steve Dower added the comment: > (Steve)> Doing the work to clean up the warnings really has to come second, > ultimately. > Second to what? Second to enabling all the warnings, which is where the thread started. I need to break my nasty habit on here of not quoting posts, but it's such a

[issue25847] CPython not using Visual Studio code analysis!

Terry J. Reedy added the comment: Like Mark, I have noticed that there are enough ignored VS warnings now to not think we need more. Every time socketmodule is recompiled, for instance, I see all the scary deprecation warnings. These are Windows-specific. Should the code be changed or

[issue25847] CPython not using Visual Studio code analysis!

Alexander Riccio added the comment: I'll open up a new issue for /W4, and deal with that first. -- ___ Python tracker ___

[issue25847] CPython not using Visual Studio code analysis!

Alexander Riccio added the comment: See Issue25878. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue25847] CPython not using Visual Studio code analysis!

Alexander Riccio added the comment: > That is, (as I undersatnd it) we've done a lot of work to not have compiler > warnings generated during compilation, and we don't want to backtrack on that. Well, as-is, simply building as x64 generates a bunch of warnings, so it's not *quite* clean. I

[issue25847] CPython not using Visual Studio code analysis!

Alexander Riccio added the comment: > In which direction do you find us to be mad? That's really quite a low warning level! For a large project, I can't imagine anything less than /W4! -- ___ Python tracker

[issue25847] CPython not using Visual Studio code analysis!

Alexander Riccio added the comment: Actually, hmm... the very naive version *DOES NOT* work. Grr. -- ___ Python tracker ___

[issue25847] CPython not using Visual Studio code analysis!

Zachary Ware added the comment: In which direction do you find us to be mad? -- ___ Python tracker ___ ___

[issue25847] CPython not using Visual Studio code analysis!

Alexander Riccio added the comment: Hold on... CPython builds at /W3???!? What is this madness??!? -- Added file: http://bugs.python.org/file41312/CPythonW3.PNG ___ Python tracker

[issue25847] CPython not using Visual Studio code analysis!

Steve Dower added the comment: Doing the work to clean up the warnings really has to come second, ultimately. The buildbot script also should be updated to pass that option. -- ___ Python tracker

[issue25847] CPython not using Visual Studio code analysis!

R. David Murray added the comment: OK, let's move this to patch needed, then, and see if anyone is ambitious enough to do the work needed to make it useful to us :) -- stage: -> needs patch type: -> enhancement versions: +Python 3.6 ___ Python

[issue25847] CPython not using Visual Studio code analysis!

Alexander Riccio added the comment: > OK, let's move this to patch needed, then, and see if anyone is ambitious > enough to do the work needed to make it useful to us :) I can try and hack it in, just as proof of concept. I think I should just be able to add something like:

[issue25847] CPython not using Visual Studio code analysis!

R. David Murray added the comment: It seems to me that adding the CLI flag is the least of the work. You then have to make it compile cleanly :) (That's why I said 'ambitious enough'). That is, (as I undersatnd it) we've done a lot of work to not have compiler warnings generated during

[issue25847] CPython not using Visual Studio code analysis!

Alexander Riccio added the comment: Yup, the very naive version works. -- keywords: +patch Added file: http://bugs.python.org/file41311/EnableCodeAnalysis.patch ___ Python tracker

[issue25847] CPython not using Visual Studio code analysis!

Mark Lawrence added the comment: There are all ready numerous compiler warnings in the Windows builds, see #9566, #18295 and #18407. -- components: +Windows nosy: +BreamoreBoy ___ Python tracker

[issue25847] CPython not using Visual Studio code analysis!

Alexander Riccio added the comment: > Is analyze something that can be used from the command line only, or does it > require the GUI? You can do it from the command line - Chrome/chromium makes use of it as such. See: https://code.google.com/p/chromium/issues/detail?id=427616 The /analyze

[issue25847] CPython not using Visual Studio code analysis!

Changes by Brett Cannon : -- components: +Windows -Build ___ Python tracker ___ ___

[issue25847] CPython not using Visual Studio code analysis!

R. David Murray added the comment: Is analyze something that can be used from the command line only, or does it require the GUI? Also, we aren't likely to make the code more complex in order to deal with shortcomings in analyze's algorithms (meaning in that case we couldn't turn it on

[issue25847] CPython not using Visual Studio code analysis!

Changes by Raymond Hettinger : -- nosy: +loewis ___ Python tracker ___ ___

[issue25847] CPython not using Visual Studio code analysis!

New submission from Alexander Riccio: Visual Studio comes with static analysis, enabled by /analyze (command line) or "Code analysis" in the project configuration dialog. Currently, none of the CPython projects in PCbuild have Code Analysis turned on, in any configuration. I was going to