[issue25888] awaiting on coroutine that is being awaited should be an error

[Yury Selivanov]

Yury Selivanov added the comment:

Committed. Thanks for the review, Martin!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25888] awaiting on coroutine that is being awaited should be an error

[Roundup Robot]

Roundup Robot added the comment:

New changeset e16084e07761 by Yury Selivanov in branch '3.5':
coroutines: Error when awaiting on coroutine that's being awaited
https://hg.python.org/cpython/rev/e16084e07761

New changeset 2218ce5c592f by Yury Selivanov in branch 'default':
Merge 3.5 (issue #25888)
https://hg.python.org/cpython/rev/2218ce5c592f

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25888] awaiting on coroutine that is being awaited should be an error

[Yury Selivanov]

Yury Selivanov added the comment:

Will commit this patch tomorrow to 3.5 and 3.6.

It only affects coroutines (async defs): if an await expression is used on a 
coroutine object while it's being already awaited by another coroutine, a 
`RuntimeError("coroutine is being awaited already")` will be triggered.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25888] awaiting on coroutine that is being awaited should be an error

[Martin Panter]

Martin Panter added the comment:

Missing word in a comment on the review

--
nosy: +martin.panter

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25888] awaiting on coroutine that is being awaited should be an error

[Brett Cannon]

Changes by Brett Cannon :


--
nosy: +brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25888] awaiting on coroutine that is being awaited should be an error

[Yury Selivanov]

Yury Selivanov added the comment:

The patch is attached, please review.

--
keywords: +patch
stage:  -> patch review
Added file: http://bugs.python.org/file41339/Issue25888.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25888] awaiting on coroutine that is being awaited should be an error

[Guido van Rossum]

Guido van Rossum added the comment:

Right.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25888] awaiting on coroutine that is being awaited should be an error

[Yury Selivanov]

New submission from Yury Selivanov:

This problem was discussed in one of the asyncio issues here: 
https://github.com/python/asyncio/issues/288

I propose to raise a RuntimeError if an 'await' expression is used for a 
coroutine object that's being awaited on already.  This change shouldn't impact 
performance in any way.  It will prevent users from writing code that behaves 
in a very weird ways (see the github link for an example).

--
assignee: yselivanov
components: Interpreter Core
messages: 256539
nosy: asvetlov, gvanrossum, haypo, ncoghlan, yselivanov
priority: normal
severity: normal
status: open
title: awaiting on coroutine that is being awaited should be an error
type: enhancement
versions: Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com