[issue2604] doctest.DocTestCase fails when run repeatedly

Pi Delport added the comment: Thanks! ️ -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue2604] doctest.DocTestCase fails when run repeatedly

Jelle Zijlstra added the comment: After 14 years this bug is finally fixed. Thanks everyone for the patches and discussion. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue2604] doctest.DocTestCase fails when run repeatedly

miss-islington added the comment: New changeset f163ad22d3321cb9bb4e6cbaac5a723444641565 by Miss Islington (bot) in branch '3.10': bpo-2604: Make doctest.DocTestCase reset globs in teardown (GH-31932) https://github.com/python/cpython/commit/f163ad22d3321cb9bb4e6cbaac5a723444641565

[issue2604] doctest.DocTestCase fails when run repeatedly

miss-islington added the comment: New changeset 3c6019035f16b673cf0f0be6918f7d5493e5690e by Miss Islington (bot) in branch '3.9': bpo-2604: Make doctest.DocTestCase reset globs in teardown (GH-31932) https://github.com/python/cpython/commit/3c6019035f16b673cf0f0be6918f7d5493e5690e

[issue2604] doctest.DocTestCase fails when run repeatedly

Change by miss-islington : -- pull_requests: +30150 pull_request: https://github.com/python/cpython/pull/32058 ___ Python tracker ___

[issue2604] doctest.DocTestCase fails when run repeatedly

Change by miss-islington : -- nosy: +miss-islington nosy_count: 8.0 -> 9.0 pull_requests: +30149 pull_request: https://github.com/python/cpython/pull/32057 ___ Python tracker

[issue2604] doctest.DocTestCase fails when run repeatedly

Jelle Zijlstra added the comment: New changeset 7ba7eae50803b11766421cb8aae1780058a57e2b by Daniël van Noord in branch 'main': bpo-2604: Make doctest.DocTestCase reset globs in teardown (GH-31932) https://github.com/python/cpython/commit/7ba7eae50803b11766421cb8aae1780058a57e2b --

[issue2604] doctest.DocTestCase fails when run repeatedly

Daniël van Noord added the comment: I have created a PR that combines the patch here with the patch from issue9736. -- nosy: +danielnoord ___ Python tracker ___

[issue2604] doctest.DocTestCase fails when run repeatedly

Change by Roundup Robot : -- nosy: +python-dev nosy_count: 5.0 -> 6.0 pull_requests: +30023 stage: -> patch review pull_request: https://github.com/python/cpython/pull/31932 ___ Python tracker

[issue2604] doctest.DocTestCase fails when run repeatedly

Irit Katriel added the comment: I've reproduced this on 3.11 as well. The patch here needs to be converted to a GitHub PR and then tested and reviewed. The patch on issue9736 has a unit test as well, which should be included (because the pjd's patch doesn't have one). -- keywords:

[issue2604] doctest.DocTestCase fails when run repeatedly

Change by Irit Katriel : -- versions: +Python 3.10, Python 3.9 -Python 2.7, Python 3.1, Python 3.2 ___ Python tracker ___ ___

[issue2604] doctest.DocTestCase fails when run repeatedly

Marius Gedminas added the comment: For the record, this bug also breaks zope.testrunner's --repeat option, if you have any doctests in your test suite that rely on test.globs not going away. -- nosy: +mgedmin ___ Python tracker

[issue2604] doctest.DocTestCase fails when run repeatedly

Changes by Terry J. Reedy tjre...@udel.edu: -- versions: +Python 2.7, Python 3.1, Python 3.2 -Python 2.4, Python 2.5, Python 2.6, Python 3.0 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2604

[issue2604] doctest.DocTestCase fails when run repeatedly

Changes by Piet Delport [EMAIL PROTECTED]: -- keywords: +patch Added file: http://bugs.python.org/file10060/reset_globs.patch __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2604 __

[issue2604] doctest.DocTestCase fails when run repeatedly

James Henstridge [EMAIL PROTECTED] added the comment: Is repeating a test with the same TestCase instance ever safe? It'd be better to create a new instance and run that. If any of the variables in test.globs are changed by the test (e.g. appending to a list), then rerunning the test will not

[issue2604] doctest.DocTestCase fails when run repeatedly

Piet Delport [EMAIL PROTECTED] added the comment: If any of the variables in test.globs are changed by the test (e.g. appending to a list), then rerunning the test will not necessarily give the same result. This is true, but modifying the globals such that subsequent runs of the same test can

[issue2604] doctest.DocTestCase fails when run repeatedly

James Henstridge [EMAIL PROTECTED] added the comment: If I create a test case with a command like: test = DocFileSuite('foo.txt', globs={'somelist': [42]}) The doctest isn't doing anything wrong if it modifies somelist. Furthermore, Glyph has said he thinks the current --until-failure

[issue2604] doctest.DocTestCase fails when run repeatedly

Piet Delport [EMAIL PROTECTED] added the comment: Well, whether that code is wrong depends on whether your project policy wants repeatable tests or not. A repeatable and arguably more idiomatic way of writing that example is to give DocFileSuite a setUp function which initializes any special

[issue2604] doctest.DocTestCase fails when run repeatedly

Amaury Forgeot d'Arc [EMAIL PROTECTED] added the comment: FWIW, the python testsuite needs repeatable tests, when running in reference leaks mode. See also r62100, where a DocTestSuite construction had to be moved into the repeated function. -- nosy: +amaury.forgeotdarc

[issue2604] doctest.DocTestCase fails when run repeatedly

New submission from Piet Delport [EMAIL PROTECTED]: DocTestCase.tearDown destructively clears its DocTest instance's globs, preventing the test from being run repeatedly (such as with trial --until-failure). There's a fix for this in zope.testing's version of doctest, which resets the globs

[issue2604] doctest.DocTestCase fails when run repeatedly

Piet Delport [EMAIL PROTECTED] added the comment: Addendum: This appears to be a regression in r36809 (Python 2.4+). __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2604 __ ___