[issue27190] Check sqlite3_version before allowing check_same_thread = False

2016-06-12 Thread Berker Peksag

Berker Peksag added the comment:

Thanks!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27190] Check sqlite3_version before allowing check_same_thread = False

2016-06-12 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 12bf71b9f1cd by Berker Peksag in branch '3.5':
Issue #27190: Raise NotSupportedError if sqlite3 is older than 3.3.1
https://hg.python.org/cpython/rev/12bf71b9f1cd

New changeset 4502cff170c2 by Berker Peksag in branch 'default':
Issue #27190: Merge from 3.5
https://hg.python.org/cpython/rev/4502cff170c2

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27190] Check sqlite3_version before allowing check_same_thread = False

2016-06-03 Thread Dave Sawyer

Dave Sawyer added the comment:

This can go into bugfix branches. In fact, it's most likely to be helpful there 
because they are more likely to be running with a version of sqlite 10 years 
old. I use the sqlite3_libversion_number() call because I'm testing against the 
version of sqlite actually loaded. The SQLITE_VERSION_NUMBER define is set at 
compile time.

--
Added file: http://bugs.python.org/file43161/issue27190_patch2.txt

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27190] Check sqlite3_version before allowing check_same_thread = False

2016-06-02 Thread Berker Peksag

Changes by Berker Peksag :


--
components: +Extension Modules

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27190] Check sqlite3_version before allowing check_same_thread = False

2016-06-02 Thread Berker Peksag

Berker Peksag added the comment:

Thanks for the patch. I'm not sure we can apply the patch to bugfix branches. 
You can use SQLITE_VERSION_NUMBER to check sqlite3 version.

--
nosy: +berker.peksag
stage:  -> patch review
versions: +Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27190] Check sqlite3_version before allowing check_same_thread = False

2016-06-02 Thread Dave Sawyer

New submission from Dave Sawyer:

Starting in sqlite version 3.3.1 (Jan 2006) multiple threads can share the same 
connection. Python allows you do use this with the check_same_thread parameter 
of sqlite3.connect() method. It's almost certain users have a late enough 
version of sqlite that they can use this option. While we could document "check 
your version before using this feature" (see http://bugs.python.org/issue27113) 
it would be nicer to check the actual database for support. Code can be written 
and tested on one machine and deployed to another machine. Using this feature 
on an very old version of sqlite can crash or possibly corrupt the database.

--
files: sqlite_oldver_issue.txt
messages: 267013
nosy: Dave Sawyer
priority: normal
severity: normal
status: open
title: Check sqlite3_version before allowing check_same_thread = False
type: enhancement
Added file: http://bugs.python.org/file43135/sqlite_oldver_issue.txt

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com