[issue27950] Superfluous messages when running make

2016-09-22 Thread Martin Panter 

Changes by Martin Panter :


--
versions: +Python 3.7 -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27950] Superfluous messages when running make

2016-09-22 Thread Martin Panter 

Martin Panter added the comment:

The version I committed has the space separating @ #

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27950] Superfluous messages when running make

2016-09-22 Thread Roundup Robot 

Roundup Robot added the comment:

New changeset 6911917f1f02 by Martin Panter in branch 'default':
Issue #27950: Silence long makefile commands and comments
https://hg.python.org/cpython/rev/6911917f1f02

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27950] Superfluous messages when running make

2016-09-04 Thread Xiang Zhang 

Xiang Zhang added the comment:

Ohh, it's reasonable. I forgot # means also comments in shell. What a shame. :(

But can we make it '@ #...'? Note there is a space. In my editor(Emacs), 
'@#' will break highlight and highlight it as a command, which is a hurt 
during reading. You can see it in the screenshot I upload.

--
Added file: http://bugs.python.org/file44367/Selection_012.png

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27950] Superfluous messages when running make

2016-09-04 Thread Martin Panter 

Martin Panter added the comment:

I think

@# Comment

would be just as good as (and slightly clearer than)

@: # Comment

They would both invoke the shell. The first has no command and just a shell 
comment; the second has a no-op command (:) with a comment. Let me know if you 
agree @# would be okay.

I can’t think of a simple solution for the pybuilddir.txt rule. (Other than 
using make -s :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27950] Superfluous messages when running make

2016-09-04 Thread Xiang Zhang 

Xiang Zhang added the comment:

After more study, I think we can do just as what I have pointed out as the 
problem, ': #...". This can make us have an indent comment that won't be 
evaluated by the shell. And we only need to add @ before it so it won't be 
echoed.

As for the part you comment, Martin, if we have to rely on the exit status, I'm 
afraid there is nothing we can do.

--
Added file: http://bugs.python.org/file44357/issue27950_v2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27950] Superfluous messages when running make

2016-09-03 Thread Xiang Zhang 

Xiang Zhang added the comment:

That is not ideal. @# can silence the comment but actually it is still not a 
comment. The "# ..." part still will be evaluated by shell.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27950] Superfluous messages when running make

2016-09-03 Thread Martin Panter 

Changes by Martin Panter :


--
title: Superflous messages when running make -> Superfluous messages when 
running make

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com