[issue28086] test.test_getargs2.TupleSubclass test failure

Changes by Donald Stufft : -- pull_requests: +957 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue28086] test.test_getargs2.TupleSubclass test failure

Roundup Robot added the comment: New changeset 5324906ae307 by Serhiy Storchaka in branch '3.6': Issue #28086: Single var-positional argument of tuple subtype was passed https://hg.python.org/cpython/rev/5324906ae307 New changeset 858afd17e3ee by Serhiy Storchaka in branch 'default': Issue #2808

[issue28086] test.test_getargs2.TupleSubclass test failure

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue28086] test.test_getargs2.TupleSubclass test failure

Raymond Hettinger added the comment: > The simplest way is just change PyTuple_Check to > PyTuple_CheckExact in ceval.c. +1 -- nosy: +rhettinger ___ Python tracker ___

[issue28086] test.test_getargs2.TupleSubclass test failure

Serhiy Storchaka added the comment: The simplest way is just change PyTuple_Check to PyTuple_CheckExact in ceval.c. Maybe this is suboptimal for tuple subclasses (namedtuple?), but I think this is very rare case. -- keywords: +patch stage: needs patch -> patch review versions: +Python

[issue28086] test.test_getargs2.TupleSubclass test failure

Serhiy Storchaka added the comment: This bug is not so critical. This bug exists in 3.5 and 2.7. Tests was added in issue18531, but at that moment the bug already was fixed in 3.6 (maybe accidentally). -- ___ Python tracker

[issue28086] test.test_getargs2.TupleSubclass test failure

Gregory P. Smith added the comment: I'm marking this as a deferred blocker as i believe we want this resolved before we exit the betas. -- nosy: +gregory.p.smith priority: normal -> deferred blocker ___ Python tracker

[issue28086] test.test_getargs2.TupleSubclass test failure

Serhiy Storchaka added the comment: Thank you for making buildbots green Steve. The intent of 51b635e81958 was avoiding needless copying. But this caused to leaking tuple subtype in case of single var-positional argument without other positional arguments. The intent of tests was checking that

[issue28086] test.test_getargs2.TupleSubclass test failure

Ned Deily added the comment: Serhiy, what do you think? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue28086] test.test_getargs2.TupleSubclass test failure

Changes by Steve Dower : -- stage: needs patch -> commit review type: compile error -> behavior ___ Python tracker ___ ___ Python-bugs

[issue28086] test.test_getargs2.TupleSubclass test failure

Steve Dower added the comment: I added a fix in 7793d34609cb assuming that the intent is to allow subclasses of tuple to be passed directly as *args rather than creating a new tuple. The original changeset seems to suggest this is the intent. -- nosy: +ned.deily, steve.dower _

[issue28086] test.test_getargs2.TupleSubclass test failure

Steve Kowalik added the comment: I've bisected this via the git mirror, and converting it to the hg changeset gives changeset 103659:51b635e81958 as what introduced this failure. -- nosy: +stevenk ___ Python tracker

[issue28086] test.test_getargs2.TupleSubclass test failure

Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue28086] test.test_getargs2.TupleSubclass test failure

New submission from Robert Collins: The test.test_getargs2.TupleSubclass test is failing in master. I suspect its a fastcall fallout. -- messages: 275879 nosy: rbcollins, serhiy.storchaka priority: normal severity: normal stage: needs patch status: open title: test.test_getargs2.TupleSu