[issue28192] Don't import readline in isolated mode

[Donald Stufft]

Changes by Donald Stufft :


--
pull_requests: +1101

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28192] Don't import readline in isolated mode

[Steve Dower]

Steve Dower added the comment:

Turned out that we really only need to check for sys.__interactivehook__, which 
made it much easier to write the tests.

--
resolution:  -> fixed
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28192] Don't import readline in isolated mode

[Roundup Robot]

Roundup Robot added the comment:

New changeset 5761294bb877 by Steve Dower in branch '3.6':
Issue #28192: Adds tests for hook in isolated mode
https://hg.python.org/cpython/rev/5761294bb877

New changeset 6c7a8a012669 by Steve Dower in branch 'default':
Issue #28192: Adds tests for hook in isolated mode
https://hg.python.org/cpython/rev/6c7a8a012669

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28192] Don't import readline in isolated mode

[Christian Heimes]

Christian Heimes added the comment:

The robot didn't mention your merge because the tracker id was not in the 
submit messages. I just saw it on python-cvs.

How about a test in subprocess? You could drop a readline.py into 
Lib/tests/somedirectory and run sys.executable with 
cwd='Lib/tests/somedirectory').

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28192] Don't import readline in isolated mode

[Steve Dower]

Steve Dower added the comment:

Also, I think PEP 432 is the way to go about simplifying Py_Main, and I'm keen 
to see it happen (presumably for 3.7). But the time constraints make it hard, 
which is why Nick hasn't gotten it done yet either.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28192] Don't import readline in isolated mode

[Steve Dower]

Steve Dower added the comment:

The NEWS change slipped into my following commit, and I just did the one merge.

Since you're here, any ideas on how to test this? Adding a readline.py during 
the test suite will affect any tests running in parallel...

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28192] Don't import readline in isolated mode

[Christian Heimes]

Changes by Christian Heimes :


--
components: +Interpreter Core
type: behavior -> security

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28192] Don't import readline in isolated mode

[Christian Heimes]

Christian Heimes added the comment:

+1, but your patch is missing Misc/NEWS and a merge to 'default'. The code in 
Modules/main.c is getting harder to read, too.

--
nosy: +christian.heimes

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28192] Don't import readline in isolated mode

[Roundup Robot]

Roundup Robot added the comment:

New changeset b0350f351752 by Steve Dower in branch '3.6':
Issue #28192: Don't import readline in isolated mode
https://hg.python.org/cpython/rev/b0350f351752

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28192] Don't import readline in isolated mode

[Steve Dower]

Steve Dower added the comment:

Should also allow users to explicitly call site.enablerlcompleter() if they 
really want it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28192] Don't import readline in isolated mode

[Steve Dower]

New submission from Steve Dower:

When running in isolated mode, readline should not be automatically imported 
(as it could conceivably be arbitrary code).

--
assignee: steve.dower
messages: 276816
nosy: steve.dower
priority: normal
severity: normal
stage: needs patch
status: open
title: Don't import readline in isolated mode
type: behavior
versions: Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com