[issue28226] compileall does not support pathlib

[Donald Stufft]

Changes by Donald Stufft :


--
pull_requests: +955

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28226] compileall does not support pathlib

[Berker Peksag]

Changes by Berker Peksag :


--
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28226] compileall does not support pathlib

[Roundup Robot]

Roundup Robot added the comment:

New changeset 13cd90bdcfbe by Berker Peksag in branch '3.6':
Issue #28226: Fix test_compileall on Windows
https://hg.python.org/cpython/rev/13cd90bdcfbe

New changeset ff80d77200ed by Berker Peksag in branch 'default':
Issue #28226: Merge from 3.6
https://hg.python.org/cpython/rev/ff80d77200ed

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28226] compileall does not support pathlib

[Berker Peksag]

Berker Peksag added the comment:

Windows buildbots didn't like a6f0cc1820f4 :) Fix is incoming.

==
FAIL: test_compile_dir_pathlike (test.test_compileall.CompileallTests)
--
Traceback (most recent call last):
  File "D:\buildarea\3.6.ware-win81-release\build\lib\test\test_compileall.py", 
line 161, in test_compile_dir_pathlike
self.assertIn("Listing '{}'...".format(self.directory), stdout.getvalue())
AssertionError: "Listing 'D:\\temp\\tmpuziqv_kw'..." not found in "Listing 
'D:temptmpuziqv_kw'...\nListing 
'D:temptmpuziqv_kw_subdir'...\nCompiling 
'D:temptmpuziqv_kw_subdir_test3.py'...\nCompiling 
'D:temptmpuziqv_kw_test.py'...\nCompiling 
'D:temptmpuziqv_kw_test2.py'...\n"

==
FAIL: test_compile_file_pathlike (test.test_compileall.CompileallTests)
--
Traceback (most recent call last):
  File "D:\buildarea\3.6.ware-win81-release\build\lib\test\test_compileall.py", 
line 111, in test_compile_file_pathlike
"Compiling '{}'...\n".format(self.source_path))
AssertionError: "Compiling 'D:temptmpqvjkm0fm_test.py'...\n" != 
"Compiling 'D:\\temp\\tmpqvjkm0fm\\_test.py'...\n"
- Compiling 'D:\\temp\\tmpqvjkm0fm\\_test.py'...
?  - --
+ Compiling 'D:\temp\tmpqvjkm0fm\_test.py'...

--
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28226] compileall does not support pathlib

[Ethan Furman]

Ethan Furman added the comment:

Thanks, Berker Peksag!

--
assignee: ethan.furman -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28226] compileall does not support pathlib

[Berker Peksag]

Berker Peksag added the comment:

I found a similar problem in compile_dir() and fixed it in the commit.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28226] compileall does not support pathlib

[Roundup Robot]

Roundup Robot added the comment:

New changeset a6f0cc1820f4 by Berker Peksag in branch '3.6':
Issue #28226: compileall now supports pathlib
https://hg.python.org/cpython/rev/a6f0cc1820f4

New changeset fcce24bc9416 by Berker Peksag in branch 'default':
Issue #28226: Merge from 3.6
https://hg.python.org/cpython/rev/fcce24bc9416

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28226] compileall does not support pathlib

[Berker Peksag]

Changes by Berker Peksag :


Added file: http://bugs.python.org/file44887/issue28226_v3.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28226] compileall does not support pathlib

[Berker Peksag]

Berker Peksag added the comment:

> Is there a fix for compileall missing from the patch?

No, os.path.* functions have taken care of the conversion, but the output was 
in the following format:

Compiling PosixPath('/tmp/tmp_nfh98lw/_test.py')...

I fixed it, added a test for the ddir argument and simplified tests a bit.

--
components: +Library (Lib)
nosy: +berker.peksag
Added file: http://bugs.python.org/file44886/issue28226_v2.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28226] compileall does not support pathlib

[Brett Cannon]

New submission from Brett Cannon:

Is there a fix for compileall missing from the patch? All I see are a new test.

--
assignee:  -> ethan.furman

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28226] compileall does not support pathlib

[Ned Deily]

Changes by Ned Deily :


--
nosy: +ned.deily
versions: +Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28226] compileall does not support pathlib

[Ethan Furman]

Changes by Ethan Furman :


--
files: open-compileall.stoneleaf.patch
keywords: patch
nosy: brett.cannon, ethan.furman
priority: normal
severity: normal
stage: patch review
status: open
title: compileall does not support pathlib
type: behavior
versions: Python 3.6
Added file: http://bugs.python.org/file44768/open-compileall.stoneleaf.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com