[issue28235] In xml.etree.ElementTree docs there is no parser argument in fromstring()

[Cheryl Sabella]

Cheryl Sabella  added the comment:

Thank you @py.user for reporting this issue and for the original patch and 
thank you @Manjusaka for the PR!

This was my first merge! Woot! :-)

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28235] In xml.etree.ElementTree docs there is no parser argument in fromstring()

[miss-islington]

miss-islington  added the comment:


New changeset b046f1badaaffb7e526b937fa2192c449b9076ed by Miss Islington (bot) 
in branch '3.7':
bpo-28235: Fix xml.etree.ElementTree.fromstring docs (GH-11903)
https://github.com/python/cpython/commit/b046f1badaaffb7e526b937fa2192c449b9076ed


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28235] In xml.etree.ElementTree docs there is no parser argument in fromstring()

[miss-islington]

Change by miss-islington :


--
pull_requests: +12007

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28235] In xml.etree.ElementTree docs there is no parser argument in fromstring()

[Cheryl Sabella]

Cheryl Sabella  added the comment:


New changeset e5458bdb6af81f9b98acecd8819c60016d3f1441 by Cheryl Sabella 
(Manjusaka) in branch 'master':
bpo-28235: Fix xml.etree.ElementTree.fromstring docs (GH-11903)
https://github.com/python/cpython/commit/e5458bdb6af81f9b98acecd8819c60016d3f1441


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28235] In xml.etree.ElementTree docs there is no parser argument in fromstring()

[py.user]

py.user  added the comment:

@Cheryl Sabella, I guess Manjusaka has done it already and this looks fine.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28235] In xml.etree.ElementTree docs there is no parser argument in fromstring()

[Manjusaka]

Manjusaka  added the comment:

I have already make a pull request on GitHub

--
nosy: +Manjusaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28235] In xml.etree.ElementTree docs there is no parser argument in fromstring()

[Manjusaka]

Change by Manjusaka :


--
pull_requests: +11929

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28235] In xml.etree.ElementTree docs there is no parser argument in fromstring()

[Cheryl Sabella]

Cheryl Sabella  added the comment:

@py.user, would you be able to convert your patch to a Github pull request?  
Thanks!

--
nosy: +cheryl.sabella
type: behavior -> enhancement
versions: +Python 3.8 -Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28235] In xml.etree.ElementTree docs there is no parser argument in fromstring()

[Martin Panter]

Martin Panter added the comment:

Added review comment

--
nosy: +martin.panter

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28235] In xml.etree.ElementTree docs there is no parser argument in fromstring()

[Berker Peksag]

Berker Peksag added the comment:

Instead of duplicating XML() documentation, I'd suggest changing fromstring() 
documentation to say something like "this is an alias for ElementTree.XML()."

--
nosy: +berker.peksag
versions: +Python 3.5, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28235] In xml.etree.ElementTree docs there is no parser argument in fromstring()

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28235] In xml.etree.ElementTree docs there is no parser argument in fromstring()

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
nosy: +eli.bendersky, scoder

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28235] In xml.etree.ElementTree docs there is no parser argument in fromstring()

[py.user]

New submission from py.user:

https://docs.python.org/3/library/xml.etree.elementtree.html#xml.etree.ElementTree.fromstring

The function has argument parser that works like in XML() function, but in the 
description there is no info about it (copied from XML() description).

Applied a patch to the issue that adds argument to the signature and describes 
it.

--
assignee: docs@python
components: Documentation, Library (Lib), XML
files: fromstring-parser.diff
keywords: patch
messages: 277124
nosy: docs@python, py.user
priority: normal
severity: normal
status: open
title: In xml.etree.ElementTree docs there is no parser argument in fromstring()
type: behavior
versions: Python 3.6
Added file: http://bugs.python.org/file44776/fromstring-parser.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com