[issue28291] urllib/urllib2 AbstractDigestAuthHandler locked to retried count of 5

[Ned Deily]

Changes by Ned Deily :


--
nosy: +orsenthil

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28291] urllib/urllib2 AbstractDigestAuthHandler locked to retried count of 5

[R. David Murray]

Changes by R. David Murray :


--
stage: patch review -> needs patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28291] urllib/urllib2 AbstractDigestAuthHandler locked to retried count of 5

[R. David Murray]

R. David Murray added the comment:

Well, it's missing doc changes and tests, so even if it is still applicable it 
isn't ready for merge yet.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28291] urllib/urllib2 AbstractDigestAuthHandler locked to retried count of 5

[Stéphane Wirtel]

Changes by Stéphane Wirtel :


--
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28291] urllib/urllib2 AbstractDigestAuthHandler locked to retried count of 5

[orban]

orban added the comment:

Just checked (for my first contribution at cpython) this patch. For me this 
patch could be merge.

--
nosy: +matorban

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28291] urllib/urllib2 AbstractDigestAuthHandler locked to retried count of 5

[secynic]

Changes by secynic :


--
keywords: +patch
versions:  -Python 2.7, Python 3.3, Python 3.4, Python 3.5, Python 3.6
Added file: http://bugs.python.org/file44850/issue28291.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28291] urllib/urllib2 AbstractDigestAuthHandler locked to retried count of 5

[secynic]

secynic added the comment:

It is a very limited use case; I won't gripe about 3.7+ only support. At the 
end of the day, even shown in the comments of that class, it shouldn't be set 
to a static 5 count.

At least this is a very easy patch that won't affect existing code.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28291] urllib/urllib2 AbstractDigestAuthHandler locked to retried count of 5

[R. David Murray]

R. David Murray added the comment:

For (convoluted) background, see issue 8797.

A solution that uses a new would be a new feature and could only go in 3.7, but 
perhaps the solutions in the above issue will point to a backward compatible 
solution.

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28291] urllib/urllib2 AbstractDigestAuthHandler locked to retried count of 5

[secynic]

New submission from secynic:

urllib/urllib2 AbstractDigestAuthHandler is hardcoded to 5 retries 
(self.retried). Normally this wouldn't be an issue.

Certain products link basic HTTP auth to Active Directory (yes, this shouldn't 
be a thing). When you have a failed login attempt lockout set on AD, this will 
lockout accounts on the very first failed Python basic auth attempt, if the AD 
lockout is set to 5 or less.

In my specific use case, I was able to override 
request.HTTPBasicAuthHandler.__init__() and 
request.HTTPBasicAuthHandler.reset_retry_count() by setting self.retried=5. One 
way to fix this would be to add a new retry_count argument to 
AbstractDigestAuthHandler.

I am a bit busy at the moment, but will submit a patch as soon as I get time.

--
components: Library (Lib)
messages: 277549
nosy: secynic
priority: normal
severity: normal
status: open
title: urllib/urllib2 AbstractDigestAuthHandler locked to retried count of 5
type: enhancement
versions: Python 2.7, Python 3.3, Python 3.4, Python 3.5, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com