[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Mariatta Wijaya added the comment: We can finally close this. Thanks everyone :) -- stage: backport needed -> resolved status: open -> closed ___ Python tracker

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Mariatta Wijaya added the comment: New changeset e1b02ff58883c68d3a5e549aa33c6dd94f915bd6 by Mariatta in branch '2.7': [2.7] bpo-28315: Improve code examples in docs (GH-1372) (#1447) https://github.com/python/cpython/commit/e1b02ff58883c68d3a5e549aa33c6dd94f915bd6 --

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Changes by Mariatta Wijaya : -- pull_requests: +1545 ___ Python tracker ___ ___

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Mariatta Wijaya added the comment: New changeset af71364c3f0e9cd6cb9d83194315af0ee3c783d2 by Mariatta in branch '3.6': [3.6] bpo-28315: Improve code examples in docs (GH-1372) (#1445) https://github.com/python/cpython/commit/af71364c3f0e9cd6cb9d83194315af0ee3c783d2 --

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Mariatta Wijaya added the comment: New changeset 5274faf5e360f74690ffb735e919cdba5fdbdf1c by Mariatta in branch '3.5': [3.5] bpo-28315: Improve code examples in docs (GH-1372) (#1446) https://github.com/python/cpython/commit/5274faf5e360f74690ffb735e919cdba5fdbdf1c --

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Changes by Mariatta Wijaya : -- pull_requests: +1544 ___ Python tracker ___ ___

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Changes by Mariatta Wijaya : -- pull_requests: +1543 ___ Python tracker ___ ___

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Mariatta Wijaya added the comment: For sure :) Thanks Terry. -- assignee: -> Mariatta ___ Python tracker ___

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Terry J. Reedy added the comment: Mariatta, please continue with this and assign to yourself. I now have IDLE PRs to review and apply. -- assignee: terry.reedy -> ___ Python tracker

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Changes by Mariatta Wijaya : -- stage: resolved -> backport needed ___ Python tracker ___

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Mariatta Wijaya added the comment: New changeset 8856940cf2e82cb17db2b684cd5732fe658605ca by Mariatta (UltimateCoder) in branch 'master': bpo-28315: Improve code examples in docs (GH-1372) https://github.com/python/cpython/commit/8856940cf2e82cb17db2b684cd5732fe658605ca --

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Changes by Jaysinh shukla : -- pull_requests: +1480 ___ Python tracker ___ ___

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Jaysinh shukla added the comment: Thanks Mariatta for reminding. Please expect a Github PR from my side in next 2 days. -- ___ Python tracker ___

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Mariatta Wijaya added the comment: Jaysinh, are you up for preparing a PR based on you patch? Start with the master branch. Thanks. -- ___ Python tracker

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Cheryl Sabella added the comment: @Mariatta I believe you can do this now? -- nosy: +csabella ___ Python tracker ___

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Mariatta Wijaya added the comment: Hi Jaysinh, I reviewed your changes, they look good to me. I can't approve it, so it would still be good for a core dev here to take another pass. Thanks :) -- ___ Python tracker

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Jaysinh shukla added the comment: Hello Terry, According to your instructions I had uploaded two patch files. The file named `all_rst_patch_default.diff` is applicable for version `default`, `3.5`, `3.6` and for most files of `2.7`. The file named `v_2_7_conflict_files.diff` is a correct

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Changes by Jaysinh shukla : Removed file: http://bugs.python.org/file44958/other_rst_version_3_6.diff ___ Python tracker ___

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Changes by Jaysinh shukla : Removed file: http://bugs.python.org/file44957/other_rst_version_3_5.diff ___ Python tracker ___

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Changes by Jaysinh shukla : Removed file: http://bugs.python.org/file44956/other_rst_version_2_7.diff ___ Python tracker ___

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Changes by Jaysinh shukla : Removed file: http://bugs.python.org/file44955/other_rst_default.diff ___ Python tracker ___

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Changes by Jaysinh shukla : Removed file: http://bugs.python.org/file44953/Doc_library_ctypes_rst_version_3_5.diff ___ Python tracker ___

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Changes by Jaysinh shukla : Removed file: http://bugs.python.org/file44952/Doc_library_ctypes_rst_version_2_7.diff ___ Python tracker ___

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Changes by Jaysinh shukla : Removed file: http://bugs.python.org/file44951/Doc_library_ctypes_rst_default.diff ___ Python tracker ___

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Changes by Jaysinh shukla : Removed file: http://bugs.python.org/file44954/Doc_library_ctypes_rst_version_3_6.diff ___ Python tracker ___

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Changes by Jaysinh shukla : Added file: http://bugs.python.org/file44971/v_2_7_conflict_files.diff ___ Python tracker ___

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Changes by Jaysinh shukla : Added file: http://bugs.python.org/file44970/all_rst_patch_default.diff ___ Python tracker ___

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Terry J. Reedy added the comment: Jaysinh, unless a patch for 3.5 does not cleanly apply to 3.6, or the patch must be different in 3.6*, no 3.6 patch is needed. Ditto for 3.7/default. Mariatta's patch merged forward without problem. *In this case, 'must be different' would be because there

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Changes by Terry J. Reedy : -- status: closed -> open ___ Python tracker ___ ___

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Jaysinh shukla added the comment: @Treyy: I have uploaded patches according to your comment at Core mentorship here (https://mail.python.org/mailman/private/core-mentorship/2016-October/003662.html) `Since I applied the patch, I can say in in this particular case, re-open, preferably with

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Changes by Jaysinh shukla : Added file: http://bugs.python.org/file44955/other_rst_default.diff ___ Python tracker ___

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Changes by Jaysinh shukla : Added file: http://bugs.python.org/file44956/other_rst_version_2_7.diff ___ Python tracker ___

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Changes by Jaysinh shukla : Added file: http://bugs.python.org/file44958/other_rst_version_3_6.diff ___ Python tracker ___

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Changes by Jaysinh shukla : Added file: http://bugs.python.org/file44957/other_rst_version_3_5.diff ___ Python tracker ___

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Changes by Jaysinh shukla : Added file: http://bugs.python.org/file44954/Doc_library_ctypes_rst_version_3_6.diff ___ Python tracker ___

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Changes by Jaysinh shukla : -- hgrepos: -358 ___ Python tracker ___ ___ Python-bugs-list

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Changes by Jaysinh shukla : Added file: http://bugs.python.org/file44953/Doc_library_ctypes_rst_version_3_5.diff ___ Python tracker ___

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Changes by Jaysinh shukla : -- hgrepos: +358 Added file: http://bugs.python.org/file44952/Doc_library_ctypes_rst_version_2_7.diff ___ Python tracker

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Changes by Jaysinh shukla : -- hgrepos: -357 ___ Python tracker ___ ___ Python-bugs-list

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Jaysinh shukla added the comment: According to this email, conversation with Terry, https://mail.python.org/mailman/private/core-mentorship/2016-October/003662.html adding patch for `Doc/library/ctypes.rst` -- hgrepos: +357 Added file:

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Changes by Jaysinh shukla : -- nosy: +jaysinh.shukla ___ Python tracker ___ ___

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Terry J. Reedy added the comment: Pushed to all 4 versions in ce57a74b5223, 1bead1f0260f, c729a62d4ec5, and 89cc2a6b64aa, but I gave issue # as 28815 instead of 28315. Thanks for the clean patch for 3.5. It mostly worked for 2.7, which also had an additional item not in 3.5. The only other

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Changes by Terry J. Reedy : -- assignee: docs@python -> terry.reedy nosy: +terry.reedy stage: -> commit review versions: +Python 3.6, Python 3.7 ___ Python tracker

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Mariatta Wijaya added the comment: Updated the documentation to use instead of ? I also went through other examples in the page and fixed those too. -- keywords: +patch Added file: http://bugs.python.org/file44885/issue28315.patch ___ Python

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Mariatta Wijaya added the comment: Thanks for the report. I agree, it should be instead of ? I'll work on a patch for this :) -- ___ Python tracker ___

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Changes by Mariatta Wijaya : -- nosy: +Mariatta ___ Python tracker ___ ___

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

New submission from Viorel Tabara: At https://docs.python.org/3.5/tutorial/errors.html#defining-clean-up-actions when I'm running the "divide('2', '1')" example I get: File "", line 1, in instead of the documentation output of: File "", line 1, in ? The same message is included with