[issue28334] netrc does not work if $HOME is not set

2017-11-25 Thread Berker Peksag
Berker Peksag added the comment: Thanks, Dimitri. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 2.7, Python 3.5, Python 3.6 ___ Python tracker

[issue28334] netrc does not work if $HOME is not set

2017-11-25 Thread Berker Peksag
Berker Peksag added the comment: New changeset 8d9bb11d8fcbf10cc9b1eb0a647bcf3658a4e3dd by Berker Peksag in branch 'master': bpo-28334: netrc() now uses expanduser() to find .netrc file (GH-4537)

[issue28334] netrc does not work if $HOME is not set

2017-11-24 Thread Berker Peksag
Change by Berker Peksag : -- pull_requests: +4471 ___ Python tracker ___ ___

[issue28334] netrc does not work if $HOME is not set

2017-02-15 Thread Roundup Robot
Changes by Roundup Robot : -- pull_requests: +86 ___ Python tracker ___ ___

[issue28334] netrc does not work if $HOME is not set

2016-11-27 Thread Xiang Zhang
Changes by Xiang Zhang : -- nosy: +xiang.zhang ___ Python tracker ___ ___ Python-bugs-list

[issue28334] netrc does not work if $HOME is not set

2016-10-18 Thread STINNER Victor
Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___

[issue28334] netrc does not work if $HOME is not set

2016-10-18 Thread Dimitri Merejkowsky
Dimitri Merejkowsky added the comment: During review SilentGhost suggested that maybe a test was not essential. In any case, I think patching documentation about the new behavior won't hurt. Do you want me to do that? -- ___ Python tracker

[issue28334] netrc does not work if $HOME is not set

2016-10-10 Thread Terry J. Reedy
Terry J. Reedy added the comment: FWIW, some history: The $HOME lookup was in Guido's original 1998-12-22 patch: if not file: file = os.path.join(os.environ['HOME'], ".netrc") The lookup was wrapped in try-except 4 years later to give a 'consistent error message'. Module

[issue28334] netrc does not work if $HOME is not set

2016-10-10 Thread Dimitri Merejkowsky
Dimitri Merejkowsky added the comment: > if it make sense to run this on Windows I found this issue while running cross-platform code. I needed to store some credentials, did not mind having them in plain-text and I thought .netrc was a good place for this. (did not need to re-invent the

[issue28334] netrc does not work if $HOME is not set

2016-10-07 Thread Terry J. Reedy
Terry J. Reedy added the comment: On Windows, HOME is both split into two variables and replaced by USERPROFILE. C:\Users\Terry>set HOME HOMEDRIVE=C: HOMEPATH=\Users\Terry C:\Users\Terry>set USERPROFILE USERPROFILE=C:\Users\Terry So if it make sense to run this on Windows*, I would call it a

[issue28334] netrc does not work if $HOME is not set

2016-10-02 Thread Dimitri Merejkowsky
Dimitri Merejkowsky added the comment: > However, since we are changing the behavior of the netrc() class, I'm not > sure this can be considered as a bug fix. I was not sure either. The patch does change behavior in subtle ways... I've added a new patch, and sent the CLA form. Thanks for

[issue28334] netrc does not work if $HOME is not set

2016-10-01 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, Dimitri. I think this is a reasonable improvement. However, since we are changing the behavior of the netrc() class, I'm not sure this can be considered as a bug fix. In any case, 3.3 and 3.4 are in security-fix-only mode so I'm going to

[issue28334] netrc does not work if $HOME is not set

2016-10-01 Thread Dimitri Merejkowsky
New submission from Dimitri Merejkowsky: If $HOME is not set, netrc will raise an exception. Attached patch fixes the problem by using `os.path.expanduser` instead -- components: Library (Lib) files: netrc-use-expanduser.patch keywords: patch messages: 277824 nosy: Dimitri Merejkowsky