[issue28411] Eliminate PyInterpreterState.modules.

Change by Eric Snow : -- assignee: -> eric.snow type: -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue28411] Eliminate PyInterpreterState.modules.

Eric Snow added the comment: FTR, gh-9047 (for issue #34572) mentions this issue. -- ___ Python tracker ___ ___ Python-bugs-list ma

[issue28411] Eliminate PyInterpreterState.modules.

Change by Eric Snow : -- pull_requests: -11714 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue28411] Eliminate PyInterpreterState.modules.

Change by Eric Snow : -- pull_requests: -11713 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue28411] Eliminate PyInterpreterState.modules.

Change by Tim Burgess : -- pull_requests: +11713 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue28411] Eliminate PyInterpreterState.modules.

Change by Tim Burgess : -- pull_requests: +11713, 11714 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue28411] Eliminate PyInterpreterState.modules.

Change by miss-islington : -- pull_requests: +7625 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue28411] Eliminate PyInterpreterState.modules.

Change by Roundup Robot : -- pull_requests: +7603 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue28411] Eliminate PyInterpreterState.modules.

Changes by Eric Snow : -- pull_requests: +3596 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue28411] Eliminate PyInterpreterState.modules.

Eric Snow added the comment: New changeset 3f9eee6eb4b25fe1926eaa5f00e02344b126f54d by Eric Snow in branch 'master': bpo-28411: Support other mappings in PyInterpreterState.modules. (#3593) https://github.com/python/cpython/commit/3f9eee6eb4b25fe1926eaa5f00e02344b126f54d -- _

[issue28411] Eliminate PyInterpreterState.modules.

Changes by Eric Snow : -- pull_requests: +3584 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue28411] Eliminate PyInterpreterState.modules.

Eric Snow added the comment: New changeset d393c1b227f22fb9af66040b2b367c99a4d1fa9a by Eric Snow in branch 'master': bpo-28411: Isolate PyInterpreterState.modules (#3575) https://github.com/python/cpython/commit/d393c1b227f22fb9af66040b2b367c99a4d1fa9a --

[issue28411] Eliminate PyInterpreterState.modules.

Changes by Eric Snow : -- pull_requests: +3566 stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing

[issue28411] Eliminate PyInterpreterState.modules.

Eric Snow added the comment: New changeset 93c92f7d1dbb6e7e472f1d0444c6968858113de2 by Eric Snow in branch 'master': bpo-31404: Revert "remove modules from Py_InterpreterState (#1638)" (#3565) https://github.com/python/cpython/commit/93c92f7d1dbb6e7e472f1d0444c6968858113de2 -- __

[issue28411] Eliminate PyInterpreterState.modules.

Eric Snow added the comment: We're reverting this (see #31404), so back to the drawing board... -- resolution: fixed -> stage: resolved -> needs patch status: closed -> open ___ Python tracker ___

[issue28411] Eliminate PyInterpreterState.modules.

Changes by Eric Snow : -- pull_requests: +3555 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue28411] Eliminate PyInterpreterState.modules.

Eric Snow added the comment: FYI, this broke some (very) corner cases. See issue #31404. -- ___ Python tracker ___ ___ Python-bugs-l

[issue28411] Eliminate PyInterpreterState.modules.

Changes by Eric Snow : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Pyth

[issue28411] Eliminate PyInterpreterState.modules.

Eric Snow added the comment: New changeset 86b7afdfeee77993fe896a2aa13b3f4f95973f16 by Eric Snow in branch 'master': bpo-28411: Remove "modules" field from Py_InterpreterState. (#1638) https://github.com/python/cpython/commit/86b7afdfeee77993fe896a2aa13b3f4f95973f16 -- __

[issue28411] Eliminate PyInterpreterState.modules.

Changes by Eric Snow : -- pull_requests: +1732 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue28411] Eliminate PyInterpreterState.modules.

Brett Cannon added the comment: As Nick pointed out, PyInterpreterState's fields are private so do what you want. :) -- ___ Python tracker ___ __

[issue28411] Eliminate PyInterpreterState.modules.

Nick Coghlan added the comment: I just checked the docs, and it turns out I'm wrong about this being a previously public API: "There are no public members in this structure." >From https://docs.python.org/3/c-api/init.html#c.PyInterpreterState That means the only externally supported API that

[issue28411] Eliminate PyInterpreterState.modules.

Eric Snow added the comment: Meh, there really isn't any need for _PyImport_GetModuleDict(). I'll drop it. Problem solved! :) -- ___ Python tracker ___ ___

[issue28411] Eliminate PyInterpreterState.modules.

Eric Snow added the comment: Hmm, actually _PyImport_GetModuleDict() isn't needed to solve the startup issue. It's still rather internally focused but the same could be said for PyImport_GetModuleDict(). I guess I'm still not sold on adding a new public API function for what amounts to a ren

[issue28411] Eliminate PyInterpreterState.modules.

Eric Snow added the comment: What's the benefit to adding PyInterpreterState_GetModuleCache()? TBH, it should only be needed in this short period during startup when the import system hasn't been bootstrapped yet. After that code can import sys and access sys.modules from there. (For that m

[issue28411] Eliminate PyInterpreterState.modules.

Graham Dumpleton added the comment: I always use PyImport_GetModuleDict(). So long as that isn't going away I should be good. -- ___ Python tracker ___ _

[issue28411] Eliminate PyInterpreterState.modules.

Nick Coghlan added the comment: (added Graham Dumpleton to the nosy list to ask if this change may impact mod_wsgi for 3.7) +1 on the general idea, but given that the current field is a public part of the interpreter state, the replacement access API should really be public as well - we can't

[issue28411] Eliminate PyInterpreterState.modules.

New submission from Eric Snow: tl;dr PyInterpreterState does not need a "modules" field. Attached is a patch that removes it. During interpreter startup [1] the sys module is imported using the same C API [2] as any other builtin module. That API only requires one bit of import state, sys.m