[issue28969] lru_cache is not threadsafe

Changes by Serhiy Storchaka : -- pull_requests: -855 ___ Python tracker ___ ___

[issue28969] lru_cache is not threadsafe

Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing

[issue28969] lru_cache is not threadsafe

Changes by Donald Stufft : -- pull_requests: +855 ___ Python tracker ___ ___

[issue28969] lru_cache is not threadsafe

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker

[issue28969] lru_cache is not threadsafe

Serhiy Storchaka added the comment: Thanks Inada. Committed in 9314aebc9674, 5724c3ddf25b and 9c852878a998. There were errors during pushing: remote: adding changesets remote: adding manifests remote: adding file changes remote: added 9 changesets with 15 changes to 5 files remote: buildbot:

[issue28969] lru_cache is not threadsafe

Changes by Serhiy Storchaka : -- assignee: rhettinger -> serhiy.storchaka stage: patch review -> commit review ___ Python tracker

[issue28969] lru_cache is not threadsafe

INADA Naoki added the comment: LGTM -- nosy: +inada.naoki ___ Python tracker ___ ___ Python-bugs-list mailing

[issue28969] lru_cache is not threadsafe

Serhiy Storchaka added the comment: With Antoine's suggestion lru_cache-dict-pop-simpler-3.5.patch no longer has an advantage. Just ignore it. -- ___ Python tracker

[issue28969] lru_cache is not threadsafe

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___

[issue28969] lru_cache is not threadsafe

Serhiy Storchaka added the comment: Antoine noticed that the first patch doesn't need special sentinel object. Thus it can be simplified. -- Added file: http://bugs.python.org/file46062/lru_cache-dict-pop-3.5-2.patch ___ Python tracker

[issue28969] lru_cache is not threadsafe

Serhiy Storchaka added the comment: What solution do you prefer Raymond? -- assignee: serhiy.storchaka -> rhettinger ___ Python tracker ___

[issue28969] lru_cache is not threadsafe

Serhiy Storchaka added the comment: An alternative patch changes semantic of _PyDict_Pop() with deflt == NULL, but makes the code simpler. -- Added file: http://bugs.python.org/file45931/lru_cache-dict-pop-simpler-3.5.patch ___ Python tracker

[issue28969] lru_cache is not threadsafe

Ned Deily added the comment: Before it could be considered for 3.6.0, it needs to be reviewed, pushed to the 3.6 branch for 3.6.1, and have some buildbot exposure. 3.6.0rc2 is in the process of manufacturing already. Since this is a fairly extensive change, I think it would not be

[issue28969] lru_cache is not threadsafe

Raymond Hettinger added the comment: Ned, can this be considered for inclusion in Python 3.6? ISTM that this problematic in that it may already be causing hard-to-diagnose bugs in existing applications. -- nosy: +ned.deily ___ Python tracker

[issue28969] lru_cache is not threadsafe

Changes by Josh Rosenberg : -- nosy: +josh.r ___ Python tracker ___ ___

[issue28969] lru_cache is not threadsafe

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file45914/lru_cache-dict-pop-3.5.patch ___ Python tracker ___

[issue28969] lru_cache is not threadsafe

Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file45912/lru_cache-dict-pop-3.5.patch ___ Python tracker ___

[issue28969] lru_cache is not threadsafe

Changes by Serhiy Storchaka : -- type: crash -> behavior ___ Python tracker ___

[issue28969] lru_cache is not threadsafe

Serhiy Storchaka added the comment: Thank you for your example Peter. Proposed patch fixes the KeyError. It introduces new private C API _PyDict_Pop_KnownHash(). It is like _PyDict_Pop(), but with precomputed hash. -- keywords: +patch stage: needs patch -> patch review Added file:

[issue28969] lru_cache is not threadsafe

Changes by Serhiy Storchaka : -- title: fnmatch is not threadsafe -> lru_cache is not threadsafe ___ Python tracker ___