[issue29063] Fixed timemodule compile warnings (gmtoff).

STINNER Victor added the comment: I backported the fix to 3.6. So all warnings on timemodule.c should now be fixed. Thanks for the bug report and the patch Decorater! commit 69f3a5ac28041fac86897e0c90d98ad9fd6fa3f7 Author: Victor Stinner Date: Wed May 17 14:45:45

[issue29063] Fixed timemodule compile warnings (gmtoff).

Changes by STINNER Victor : -- pull_requests: +1731 ___ Python tracker ___ ___

[issue29063] Fixed timemodule compile warnings (gmtoff).

Changes by STINNER Victor : -- title: Fixed timemodule compile warnings. -> Fixed timemodule compile warnings (gmtoff). ___ Python tracker

[issue29063] Fixed timemodule compile warnings.

STINNER Victor added the comment: commit 0d659e5614cad512a1940125135b443b3eecb5d7 Author: Victor Stinner Date: Tue Apr 25 01:22:42 2017 +0200 -- pull_requests: +1726 ___ Python tracker

[issue29063] Fixed timemodule compile warnings.

Decorater added the comment: I think the patch that haypo added should help take care of the warning. It does however only warned when building for 64 bit. -- ___ Python tracker

[issue29063] Fixed timemodule compile warnings.

STINNER Victor added the comment: Not checking for integer overflow is more likely to hide bugs. Handling time is an hard problem, see a recent funny (or not) story from Cloudfare with the latest leap second added at midnight the 2016-12-31:

[issue29063] Fixed timemodule compile warnings.

STINNER Victor added the comment: The warning was introduced by a recent change: changeset: 103680:a96101dd105c user:Alexander Belopolsky date:Sun Sep 11 22:55:16 2016 -0400 files: Doc/library/time.rst Misc/NEWS Modules/timemodule.c

[issue29063] Fixed timemodule compile warnings.

STINNER Victor added the comment: Downcasting to int doesn't seem good to me. gmtoff_time_t.patch uses time_t instead of an int to store gmtoff. It raises an OverflowError if the value doesn't fit into a C long (at least max is at least 2^31). I guess that the issue only impacts Windows, I

[issue29063] Fixed timemodule compile warnings.

Steve Dower added the comment: Any reason we can't make gmtoff a time_t instead of an int? If we're going to truncate values to get rid of the warnings, I'd like to also see either proof that it will never exceed the size of an int (which may be a simple comment, but it's not obvious that

[issue29063] Fixed timemodule compile warnings.

Changes by Decorater : -- title: Fix timemodule compile warnings. -> Fixed timemodule compile warnings. ___ Python tracker ___