[issue29142] urllib: no_proxy variable values with leading dot not properly handled

Changes by Donald Stufft : -- pull_requests: +961 ___ Python tracker ___ ___

[issue29142] urllib: no_proxy variable values with leading dot not properly handled

Xiang Zhang added the comment: Thanks Milan and Thomas! -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker

[issue29142] urllib: no_proxy variable values with leading dot not properly handled

Roundup Robot added the comment: New changeset cb4f73be9486 by Xiang Zhang in branch '2.7': Issue #29142: Fix suffixes in no_proxy handling in urllib. https://hg.python.org/cpython/rev/cb4f73be9486 New changeset 350c5a1f9cfd by Xiang Zhang in branch '3.5': Issue #29142: Fix suffixes in no_proxy

[issue29142] urllib: no_proxy variable values with leading dot not properly handled

Xiang Zhang added the comment: LGTM. -- assignee: -> xiang.zhang stage: patch review -> commit review ___ Python tracker ___

[issue29142] urllib: no_proxy variable values with leading dot not properly handled

Milan Oberkirch added the comment: Thanks for the feedback! I changed the patch to use lstrip so that the FQDN "example.com." would match the NOPROXY entry "example.com.". I don't think we get FQDNs, but that's just my guess. I think ideally "example.com" would also match "example.com." but

[issue29142] urllib: no_proxy variable values with leading dot not properly handled

Xiang Zhang added the comment: > I think it makes sense to strip at the end as well (`example.com` is the same > domain as `example.com.`). Are your sure the host checked against the list is FQDN? With and without the trailing dot are different. --

[issue29142] urllib: no_proxy variable values with leading dot not properly handled

Changes by Berker Peksag : -- type: -> behavior versions: +Python 3.5, Python 3.6, Python 3.7 ___ Python tracker ___

[issue29142] urllib: no_proxy variable values with leading dot not properly handled

Changes by Milan Oberkirch : -- type: behavior -> versions: -Python 3.5, Python 3.6, Python 3.7 Added file: http://bugs.python.org/file46168/ignore_dots-v2.patch ___ Python tracker

[issue29142] urllib: no_proxy variable values with leading dot not properly handled

Berker Peksag added the comment: Yes, thanks! -- nosy: +martin.panter, xiang.zhang stage: -> patch review type: -> behavior versions: +Python 3.5, Python 3.6, Python 3.7 ___ Python tracker

[issue29142] urllib: no_proxy variable values with leading dot not properly handled

Milan Oberkirch added the comment: Too bad, I was all exited when I saw that I can paste a PR link here :) I downloaded the patch from the commit using github, I hope that works? -- keywords: +patch Added file: http://bugs.python.org/file46154/ignore_dots-v1.patch

[issue29142] urllib: no_proxy variable values with leading dot not properly handled

Berker Peksag added the comment: Note: We don't officially use pull requests yet. Current way of contributing to Python is documented at https://docs.python.org/devguide/patch.html -- nosy: +berker.peksag ___ Python tracker

[issue29142] urllib: no_proxy variable values with leading dot not properly handled

Milan Oberkirch added the comment: I added a line stripping dots from name, I think it makes sense to strip at the end as well (`example.com` is the same domain as `example.com.`). -- nosy: +zvyn pull_requests: +8 ___ Python tracker

[issue29142] urllib: no_proxy variable values with leading dot not properly handled

New submission from Thomas Loetzer: Hi, the fix for issue 26864 changed the behavior of urllib for no_proxy values with a leading dot to no longer match anything. This seems to be caused by always adding an additional dot between the hostname being checked and the entry. Example: no_proxy =