[issue29142] urllib: no_proxy variable values with leading dot not properly handled

[Donald Stufft]

Changes by Donald Stufft :


--
pull_requests: +961

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29142] urllib: no_proxy variable values with leading dot not properly handled

[Xiang Zhang]

Xiang Zhang added the comment:

Thanks Milan and Thomas!

--
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29142] urllib: no_proxy variable values with leading dot not properly handled

[Roundup Robot]

Roundup Robot added the comment:

New changeset cb4f73be9486 by Xiang Zhang in branch '2.7':
Issue #29142: Fix suffixes in no_proxy handling in urllib.
https://hg.python.org/cpython/rev/cb4f73be9486

New changeset 350c5a1f9cfd by Xiang Zhang in branch '3.5':
Issue #29142: Fix suffixes in no_proxy handling in urllib.
https://hg.python.org/cpython/rev/350c5a1f9cfd

New changeset e90efd9f203e by Xiang Zhang in branch '3.6':
Issue #29142: Merge 3.5.
https://hg.python.org/cpython/rev/e90efd9f203e

New changeset 3954f8f6be3d by Xiang Zhang in branch 'default':
Issue #29142: Merge 3.6.
https://hg.python.org/cpython/rev/3954f8f6be3d

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29142] urllib: no_proxy variable values with leading dot not properly handled

[Xiang Zhang]

Xiang Zhang added the comment:

LGTM.

--
assignee:  -> xiang.zhang
stage: patch review -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29142] urllib: no_proxy variable values with leading dot not properly handled

[Milan Oberkirch]

Milan Oberkirch added the comment:

Thanks for the feedback!

I changed the patch to use lstrip so that the FQDN "example.com." would match 
the NOPROXY entry "example.com.". I don't think we get FQDNs, but that's just 
my guess.

I think ideally "example.com" would also match "example.com." but that's a 
different issue.

--
Added file: http://bugs.python.org/file46207/ignore_dots-v3.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29142] urllib: no_proxy variable values with leading dot not properly handled

[Xiang Zhang]

Xiang Zhang added the comment:

> I think it makes sense to strip at the end as well (`example.com` is the same 
> domain as `example.com.`).

Are your sure the host checked against the list is FQDN? With and without the 
trailing dot are different.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29142] urllib: no_proxy variable values with leading dot not properly handled

[Berker Peksag]

Changes by Berker Peksag :


--
type:  -> behavior
versions: +Python 3.5, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29142] urllib: no_proxy variable values with leading dot not properly handled

[Milan Oberkirch]

Changes by Milan Oberkirch :


--
type: behavior -> 
versions:  -Python 3.5, Python 3.6, Python 3.7
Added file: http://bugs.python.org/file46168/ignore_dots-v2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29142] urllib: no_proxy variable values with leading dot not properly handled

[Berker Peksag]

Berker Peksag added the comment:

Yes, thanks!

--
nosy: +martin.panter, xiang.zhang
stage:  -> patch review
type:  -> behavior
versions: +Python 3.5, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29142] urllib: no_proxy variable values with leading dot not properly handled

[Milan Oberkirch]

Milan Oberkirch added the comment:

Too bad, I was all exited when I saw that I can paste a PR link here :)

I downloaded the patch from the commit using github, I hope that works?

--
keywords: +patch
Added file: http://bugs.python.org/file46154/ignore_dots-v1.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29142] urllib: no_proxy variable values with leading dot not properly handled

[Berker Peksag]

Berker Peksag added the comment:

Note: We don't officially use pull requests yet. Current way of contributing to 
Python is documented at https://docs.python.org/devguide/patch.html

--
nosy: +berker.peksag

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29142] urllib: no_proxy variable values with leading dot not properly handled

[Milan Oberkirch]

Milan Oberkirch added the comment:

I added a line stripping dots from name, I think it makes sense to strip at the 
end as well (`example.com` is the same domain as `example.com.`).

--
nosy: +zvyn
pull_requests: +8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29142] urllib: no_proxy variable values with leading dot not properly handled

[Thomas Loetzer]

New submission from Thomas Loetzer:

Hi,

the fix for issue 26864 changed the behavior of urllib for no_proxy values with 
a leading dot to no longer match anything. This seems to be caused by always 
adding an additional dot between the hostname being checked and the entry.

Example:
no_proxy = '.company.internal'

I would expect 'somehost.company.internal' to be accessed without proxy, but 
this is not actually the case. Changing no_proxy to company.internal changes 
this and the host is accessed without proxy.

Python 2.7.11 and curl both handle this case fine and the proxy is not used.

Regards,
Thomas

--
components: Library (Lib)
messages: 284565
nosy: tloetzer
priority: normal
severity: normal
status: open
title: urllib: no_proxy variable values with leading dot not properly handled
versions: Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com