[issue29213] python -m venv activate.bat has weird mix of line endings

Roundup Robot added the comment: New changeset a7dc69b8956ad223ff6c239299896dd5195ce430 by Vinay Sajip in branch 'master': Fixes #29213: regularised EOLs of venv scripts. https://github.com/python/cpython/commit/a7dc69b8956ad223ff6c239299896dd5195ce430 New changeset

[issue29213] python -m venv activate.bat has weird mix of line endings

Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue29213] python -m venv activate.bat has weird mix of line endings

Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue29213] python -m venv activate.bat has weird mix of line endings

Roundup Robot added the comment: New changeset a7dc69b8956ad223ff6c239299896dd5195ce430 by Vinay Sajip in branch '3.6': Fixes #29213: regularised EOLs of venv scripts. https://github.com/python/cpython/commit/a7dc69b8956ad223ff6c239299896dd5195ce430 New changeset

[issue29213] python -m venv activate.bat has weird mix of line endings

Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue29213] python -m venv activate.bat has weird mix of line endings

Roundup Robot added the comment: New changeset a7dc69b8956ad223ff6c239299896dd5195ce430 by Vinay Sajip in branch '3.5': Fixes #29213: regularised EOLs of venv scripts. https://github.com/python/cpython/commit/a7dc69b8956ad223ff6c239299896dd5195ce430 --

[issue29213] python -m venv activate.bat has weird mix of line endings

Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue29213] python -m venv activate.bat has weird mix of line endings

Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue29213] python -m venv activate.bat has weird mix of line endings

Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue29213] python -m venv activate.bat has weird mix of line endings

Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue29213] python -m venv activate.bat has weird mix of line endings

Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue29213] python -m venv activate.bat has weird mix of line endings

Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue29213] python -m venv activate.bat has weird mix of line endings

Roundup Robot added the comment: New changeset ef0264af4d1a1844c2feb32714870d636e583b3a by Vinay Sajip in branch 'master': Closes #29213: Merged fix from 3.6. https://github.com/python/cpython/commit/ef0264af4d1a1844c2feb32714870d636e583b3a -- ___

[issue29213] python -m venv activate.bat has weird mix of line endings

Roundup Robot added the comment: New changeset c23224ebc9e5 by Vinay Sajip in branch 'default': Closes #29213: Merged fix from 3.6. https://hg.python.org/cpython/rev/c23224ebc9e5 -- resolution: -> fixed stage: patch review -> resolved status: open -> closed

[issue29213] python -m venv activate.bat has weird mix of line endings

Roundup Robot added the comment: New changeset 2b9e5cbdb0b1 by Vinay Sajip in branch '3.5': Fixes #29213: regularised EOLs of venv scripts. https://hg.python.org/cpython/rev/2b9e5cbdb0b1 New changeset 0f3ebeb389fe by Vinay Sajip in branch '3.6': Fixes #29213: merged fix from 3.5.

[issue29213] python -m venv activate.bat has weird mix of line endings

Vinay Sajip added the comment: I've added a patch, can you confirm if it resolves the issue? -- assignee: -> vinay.sajip keywords: +patch stage: -> patch review Added file: http://bugs.python.org/file46278/issue-29213-01.diff ___ Python tracker

[issue29213] python -m venv activate.bat has weird mix of line endings

Vinay Sajip added the comment: Although we don't currently have binaries under venv/scripts, that might change in the future. The logic could be changed to: with open(srcfile, 'rb') as f: data = f.read() if not srcfile.endswith('.exe'): try: data =

[issue29213] python -m venv activate.bat has weird mix of line endings

Evan added the comment: The scripts are being read in with mode 'rb', decoded, modified, then written back out with mode 'w'. This means the EOL conversion doesn't happen on the way in, but does happen on the way out, and so '\r\n' becomes '\r\r\n'. One fix would be to always use binary mode

[issue29213] python -m venv activate.bat has weird mix of line endings

New submission from Josh Wilson: The activate.bat file generated by python -m venv somevirtualenv seems to have a mix of line ending styles. Sometimes using Carriage Return (CR) and Line Feed (LF) and other times using only CR. This seems to cause unexpected behavior when trying to modify