[issue29281] json.loads documentation missing "versionchanged" statement

[Ammar Askar]

Ammar Askar added the comment:

Which part is misleading, do you think the use of "encoding" could be confused 
with the argument encoding? 

There is a note right above the versionchanged block that says:

`The other arguments have the same meaning as in load(), except encoding which 
is ignored and deprecated.`


If that is the concern then I think changing the wording to be, "the encoding 
of the input string should be ..."

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29281] json.loads documentation missing "versionchanged" statement

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

The wording looks little misleading. There is the encoding parameter in 
json.loads(). It is deprecated and ignored.

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29281] json.loads documentation missing "versionchanged" statement

[Raymond Hettinger]

Raymond Hettinger added the comment:

Thanks for the patch.

--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29281] json.loads documentation missing "versionchanged" statement

[Roundup Robot]

Roundup Robot added the comment:

New changeset 3452ff9e8f0a by Raymond Hettinger in branch '3.6':
Issue #29281:  Fill-in a missing versionchanged entry
https://hg.python.org/cpython/rev/3452ff9e8f0a

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29281] json.loads documentation missing "versionchanged" statement

[Raymond Hettinger]

Changes by Raymond Hettinger :


--
assignee: docs@python -> rhettinger
nosy: +rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29281] json.loads documentation missing "versionchanged" statement

[Ammar Askar]

Ammar Askar added the comment:

Attached patch adds a versionchanged block to specify that bytes and bytesarray 
can now be used and the types of encodings it supports (as taken from the 
whatsnew changes here https://hg.python.org/cpython/rev/e9e1bf9ec2ac#l2.7)

--
keywords: +patch
Added file: http://bugs.python.org/file46350/json_loads_bytes.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29281] json.loads documentation missing "versionchanged" statement

[R. David Murray]

R. David Murray added the comment:

Yes, this should be documented with a versionchanged.  The removal was for 
python3 so we didn't need a versionchanged there; it was just a difference from 
python2, and the python3 docs were "restarted" with (almost) no back references 
to python2.

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29281] json.loads documentation missing "versionchanged" statement

[Ammar Askar]

Ammar Askar added the comment:

To anyone more experienced with python documentation, is behavior like this 
actually supposed to be documented? For some more historical context,

the support for bytes in the json module was removed in this issue: 
https://bugs.python.org/issue4136

and then re-added in this one: 
https://bugs.python.org/issue17909

--
nosy: +ammar2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29281] json.loads documentation missing "versionchanged" statement

[Alexey Popravka]

New submission from Alexey Popravka:

json.loads function was changed in Python 3.6 to accept
bytes and bytearrays, however documentation is missing
`versionchanged` block describing this changes.

--
assignee: docs@python
components: Documentation
messages: 285545
nosy: Alexey Popravka, docs@python
priority: normal
severity: normal
status: open
title: json.loads documentation missing "versionchanged" statement
versions: Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com