[issue29530] Windows buildbots broken by the migration to GitHub (meta issue)

[STINNER Victor]

STINNER Victor added the comment:

Windows buildbots are green since at least 2 months, so I close this issue.

There is one remaining issue, but specific to the Windows *installer*: see 
bpo-30716 and bpo-27425.

--
dependencies:  -Tests fail because of git's newline preferences on Windows
resolution:  -> fixed
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29530] Windows buildbots broken by the migration to GitHub (meta issue)

[Steve Dower]

Steve Dower added the comment:

> Does Git support per-file settings like the svn:eol-style property in 
> Subversion or .hgeol in Mercurial?

The .gitattributes file seems to be full of glob patterns, so I assume a full 
file path will work.

However, that doesn't help with tarballs. Fixing the tests is the best way.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29530] Windows buildbots broken by the migration to GitHub (meta issue)

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Does Git support per-file settings like the svn:eol-style property in 
Subversion or .hgeol in Mercurial?

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29530] Windows buildbots broken by the migration to GitHub (meta issue)

[R. David Murray]

R. David Murray added the comment:

Some of the tests (notably email tests) are *testing* platform line endings.  
In tests that I rewrote I did my best to make the tests independent of the line 
endings of checked in files (that is, constructing the files-to-test in the 
test itself instead of checking them in), but I wouldn't be surprised if there 
were a few tests that weren't converted to that paradigm.  (I haven't looked to 
see if there are any test.test_email.test_email failures, which is where they'd 
be.)

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29530] Windows buildbots broken by the migration to GitHub (meta issue)

[Steve Dower]

Steve Dower added the comment:

My vote would be to make the tests not presume anything about line endings, to 
the point of converting test files on the fly to be sure.

I'm mostly free today (in a different city with nothing to do), so if my hotel 
internet will let me SSH to github then I can work on this today. If people are 
around, I'll be on IRC too.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29530] Windows buildbots broken by the migration to GitHub (meta issue)

[Zachary Ware]

Zachary Ware added the comment:

We really need to be able to function regardless of the core.autocrlf setting.  
See #27425 for more about the EOL issues.

--
dependencies: +Tests fail because of git's newline preferences on Windows

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29530] Windows buildbots broken by the migration to GitHub (meta issue)

[Zachary Ware]

Changes by Zachary Ware :


--
components: +Windows
nosy: +paul.moore, steve.dower, tim.golden, zach.ware
priority: normal -> critical
versions: +Python 2.7, Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29530] Windows buildbots broken by the migration to GitHub (meta issue)

[Jeremy Kloth]

Jeremy Kloth added the comment:

Tests are now failing due to end-of-line (?) differences.

I did a quick reading of the devguide, but didn't see any mention of the 
settings to be used for Git on Windows wrt core.autocrlf.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29530] Windows buildbots broken by the migration to GitHub (meta issue)

[Jeremy Kloth]

Jeremy Kloth added the comment:

After ensuring that Git is available to the buildbot service, the initial 
update fails due to the existing build directory containing the Mercurial 
checkout.

After manually removing the contents of the build directories, the update task 
successfully completes.

--
nosy: +jkloth

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29530] Windows buildbots broken by the migration to GitHub (meta issue)

[STINNER Victor]

New submission from STINNER Victor:

(*) I noticed test_sax and test_random failures on Windows since CPython moved 
to GitHub. These failures seem to be caused by newlines: see issue #27425.


(*) "AMD64 Windows7 SP1 3.x" fails on the "git" step with:

   'git' is not recognized as an internal or external command

I contacted the slave owner, Jeremy, to ask him to install git.

--
components: Tests
keywords: buildbot
messages: 287587
nosy: haypo
priority: normal
severity: normal
status: open
title: Windows buildbots broken by the migration to GitHub (meta issue)
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com