[issue29673] Some gdb macros are broken in 3.6

[Ned Deily]

Ned Deily  added the comment:

Thanks, Marcel, for the fix and thanks, Skip, for the review.  Merged for 
release in 3.6.6 and 3.7.0.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29673] Some gdb macros are broken in 3.6

[Ned Deily]

Ned Deily  added the comment:


New changeset 3468a05f6a7d730a656d254730a3f5b6b7e85983 by Ned Deily (Miss 
Islington (bot)) in branch '3.6':
[3.6] bpo-29673: fix gdb scripts pystack and pystackv (GH-6126) (GH-6400)
https://github.com/python/cpython/commit/3468a05f6a7d730a656d254730a3f5b6b7e85983


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29673] Some gdb macros are broken in 3.6

[Ned Deily]

Ned Deily  added the comment:


New changeset 3c193cf8afce525b1283986f113de0e16f23e115 by Ned Deily (Miss 
Islington (bot)) in branch '3.7':
[3.7] bpo-29673: fix gdb scripts pystack and pystackv (GH-6126) (GH-6399)
https://github.com/python/cpython/commit/3c193cf8afce525b1283986f113de0e16f23e115


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29673] Some gdb macros are broken in 3.6

[miss-islington]

Change by miss-islington :


--
pull_requests: +6106

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29673] Some gdb macros are broken in 3.6

[miss-islington]

Change by miss-islington :


--
pull_requests: +6105

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29673] Some gdb macros are broken in 3.6

[Ned Deily]

Ned Deily  added the comment:


New changeset 3a9ccee0e5dbf7d67f5ab79f6095755969db117c by Ned Deily (Marcel 
Plch) in branch 'master':
bpo-29673: fix gdb scripts pystack and pystackv (GH-6126)
https://github.com/python/cpython/commit/3a9ccee0e5dbf7d67f5ab79f6095755969db117c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29673] Some gdb macros are broken in 3.6

[Ned Deily]

Ned Deily  added the comment:

Thanks for the PR and the ping.  I've sent an email to the python-dev list 
requesting review help for gdb issues including this one.

--
nosy: +ned.deily
versions: +Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29673] Some gdb macros are broken in 3.6

[Charalampos Stratakis]

Charalampos Stratakis  added the comment:

A PR has been filed, could someone take a look?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29673] Some gdb macros are broken in 3.6

[Charalampos Stratakis]

Change by Charalampos Stratakis :


--
nosy: +cstratak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29673] Some gdb macros are broken in 3.6

[Skip Montanaro]

Change by Skip Montanaro :


--
nosy:  -skip.montanaro

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29673] Some gdb macros are broken in 3.6

[Marcel Plch]

Marcel Plch  added the comment:

I have created a PR here - https://github.com/python/cpython/pull/6126

The problem was, indeed, change in the code structure. The macro checked for 
presence inside of PyEval_EvalFrame() using address of a neighbouring function.
Also, arguments to PyEval_EvalFrame() were changed, so the macro responsible 
for printing of the frame needed a little tweak.

--
nosy: +Dormouse759

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29673] Some gdb macros are broken in 3.6

[Marcel Plch]

Change by Marcel Plch :


--
keywords: +patch
pull_requests: +5888
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29673] Some gdb macros are broken in 3.6

[STINNER Victor]

Changes by STINNER Victor :


--
nosy: +haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29673] Some gdb macros are broken in 3.6

[Skip Montanaro]

Skip Montanaro added the comment:

Note that these macros were always expected to be fragile. They depend to a 
great extent on the layout of the functions in Python/ceval.c. I've had to 
tweak them a couple times over the years.

I'm pretty sure the gdb instance I have available to me at work wasn't 
configured --with-python, and corporate policies would prevent me from 
downloading the source and building my own private version. For me, 
Misc/gdbinit is likely to be the best I can do for the foreseeable future. 

If the layout of ceval.c has changed sufficiently between Python 2.x and 3.x, 
perhaps two versions of gdbinit are warranted, with the version delivered for 
Python 3 being appropriate for the current release.

--
nosy: +skip.montanaro

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29673] Some gdb macros are broken in 3.6

[Alexander Belopolsky]

Alexander Belopolsky added the comment:

I tried to simply replace  _PyUnicode_AsString with PyUnicode_AsUTF8, but it 
looks like code structure has changed and the pyframe and pystack macros don't 
work anymore.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29673] Some gdb macros are broken in 3.6

[Alexander Belopolsky]

New submission from Alexander Belopolsky:

Some gdb macros defined in Misc/gdbinit got broken when _PyUnicode_AsString was 
renamed to PyUnicode_AsUTF8.

(gdb) pystack
No symbol "_PyUnicode_AsString" in current context.

--
messages: 288684
nosy: belopolsky
priority: normal
severity: normal
status: open
title: Some gdb macros are broken in 3.6
versions: Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com