[issue29898] PYTHONLEGACYWINDOWSIOENCODING isn't implemented

[Berker Peksag]

Berker Peksag added the comment:


New changeset 0d267041c40a3ab655676b885c0ba35ed9685848 by Berker Peksag in 
branch '3.6':
bpo-29898: Fix incorrect env variable name (GH-1576)
https://github.com/python/cpython/commit/0d267041c40a3ab655676b885c0ba35ed9685848


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29898] PYTHONLEGACYWINDOWSIOENCODING isn't implemented

[Berker Peksag]

Changes by Berker Peksag :


--
resolution:  -> fixed
stage: backport needed -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29898] PYTHONLEGACYWINDOWSIOENCODING isn't implemented

[Berker Peksag]

Changes by Berker Peksag :


--
pull_requests: +1700

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29898] PYTHONLEGACYWINDOWSIOENCODING isn't implemented

[Berker Peksag]

Changes by Berker Peksag :


--
stage: test needed -> backport needed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29898] PYTHONLEGACYWINDOWSIOENCODING isn't implemented

[Berker Peksag]

Berker Peksag added the comment:


New changeset 87fa8a780e9045a26c735f085c07bba4b2d0be60 by Berker Peksag in 
branch 'master':
bpo-29898: Fix incorrect env variable name (GH-1576)
https://github.com/python/cpython/commit/87fa8a780e9045a26c735f085c07bba4b2d0be60


--
nosy: +berker.peksag

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29898] PYTHONLEGACYWINDOWSIOENCODING isn't implemented

[Berker Peksag]

Changes by Berker Peksag :


--
pull_requests: +1669

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29898] PYTHONLEGACYWINDOWSIOENCODING isn't implemented

[Steve Dower]

Steve Dower added the comment:

Sure, but you're proposing a change to a correctly documented (apart from the 
variable name) and released behavior. It can't be changed in 3.6, and I don't 
see a compelling reason to have different behavior in 3.7.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29898] PYTHONLEGACYWINDOWSIOENCODING isn't implemented

[Eryk Sun]

Eryk Sun added the comment:

I prefer the name PYTHONLEGACYWINDOWSIOENCODING for symmetry with both 
PYTHONIOENCODING and PYTHONLEGACYWINDOWSFSENCODING, but I suppose you changed 
it to make it more visually distinguished from the latter.

I discovered this issue due to the modified behavior of PYTHONIOENCODING. It's 
not really a disruptive change, but it looks wrong based solely on the --help 
text description of PYTHONIOENCODING. An alternative would be to set 
Py_LegacyWindowsStdioFlag in _Py_InitializeEx_Private either when 
PYTHONLEGACYWINDOWSSTDIO is set or when PYTHONIOENCODING isn't a 
case-insensitive match for "utf-8" with an optional :errors spec. That way 
people get exactly what they asked for, even if it's mojibake nonsense given 
the console's current input and output codepages.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29898] PYTHONLEGACYWINDOWSIOENCODING isn't implemented

[Steve Dower]

Steve Dower added the comment:

It's actually called "PYTHONLEGACYWINDOWSSTDIO" in Python/pylifecycle.c, which 
is also what PEP 528 says it should be, so this is a docs issue.

You're correct that PYTHONIOENCODING is overridden by detection of a real 
console, however, PYTHONIOENCODING doesn't currently set a flag anywhere, and 
the (required for compatibility) defaults on Windows would make it look like 
it's always been set to something else.

In my opinion, you should set PYTHONLEGACYWINDOWSSTDIO to indicate that even 
though we know the incoming encoding (Unicode from an interactive console), you 
don't care and you want to override it with a default value. Then use 
PYTHONIOENCODING to set that default value. This is most consistent with the 
existing use of PYTHONIOENCODING (it's the default unless you know exactly 
which encoding you are getting).

--
assignee:  -> docs@python
components: +Documentation
nosy: +docs@python

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29898] PYTHONLEGACYWINDOWSIOENCODING isn't implemented

[Eryk Sun]

New submission from Eryk Sun:

The environment variable PYTHONLEGACYWINDOWSIOENCODING is documented here:

https://docs.python.org/3/using/cmdline.html#envvar-PYTHONLEGACYWINDOWSIOENCODING

but not actually implemented. Also, I think setting PYTHONIOENCODING to 
anything except UTF-8 should disable using io._WindowsConsoleIO.

--
components: IO, Unicode, Windows
messages: 290240
nosy: eryksun, ezio.melotti, haypo, paul.moore, steve.dower, tim.golden, 
zach.ware
priority: normal
severity: normal
stage: test needed
status: open
title: PYTHONLEGACYWINDOWSIOENCODING isn't implemented
type: behavior
versions: Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com