[issue29941] Confusion between asserts and Py_DEBUG

Change by Thomas Wouters : -- stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue29941] Confusion between asserts and Py_DEBUG

Changes by Thomas Wouters : -- pull_requests: +1829 ___ Python tracker ___ ___

[issue29941] Confusion between asserts and Py_DEBUG

Changes by Thomas Wouters : -- pull_requests: +1821 ___ Python tracker ___ ___

[issue29941] Confusion between asserts and Py_DEBUG

STINNER Victor added the comment: > since the commit a00c3fd12d421e41b769debd7df717d17b0deed5 *or later* (who > knows?)... Hum, my sentence is unclear: I mean that I am not sure that this commit is related to issue #30169 crash. -- ___ Python

[issue29941] Confusion between asserts and Py_DEBUG

STINNER Victor added the comment: Please see the issue #30169 "test_multiprocessing_spawn crashed on AMD64 Windows8.1 Non-Debug 3.x buildbot", a mysterious and random bug on Windows which started to occur since the commit a00c3fd12d421e41b769debd7df717d17b0deed5 *or later* (who knows?)...

[issue29941] Confusion between asserts and Py_DEBUG

Thomas Wouters added the comment: PR #980 adds a configure flag (--with-assertions), defaulting to the old behaviour (no assertions by default, except when --with-pydebug is passed). I would like to backport that to (at least) 3.6 so that we can set up a buildbot with it, to prevent

[issue29941] Confusion between asserts and Py_DEBUG

Changes by Thomas Wouters : -- pull_requests: +1153 ___ Python tracker ___ ___

[issue29941] Confusion between asserts and Py_DEBUG

Thomas Wouters added the comment: New changeset 553275d125478a6563dde7523f4f28c92f1861b4 by T. Wouters in branch '3.5': bpo-29941: Assert fixes (#886) (#956) https://github.com/python/cpython/commit/553275d125478a6563dde7523f4f28c92f1861b4 -- ___

[issue29941] Confusion between asserts and Py_DEBUG

Thomas Wouters added the comment: New changeset 90e3518225bafaff01469ed48c472ae7db5686f0 by T. Wouters in branch '3.6': bpo-29941: Assert fixes (#886) (#955) https://github.com/python/cpython/commit/90e3518225bafaff01469ed48c472ae7db5686f0 -- ___

[issue29941] Confusion between asserts and Py_DEBUG

Changes by Thomas Wouters : -- pull_requests: +1138 ___ Python tracker ___ ___

[issue29941] Confusion between asserts and Py_DEBUG

Changes by Thomas Wouters : -- pull_requests: +1137 ___ Python tracker ___ ___

[issue29941] Confusion between asserts and Py_DEBUG

Changes by Thomas Wouters : -- pull_requests: +1119 ___ Python tracker ___ ___

[issue29941] Confusion between asserts and Py_DEBUG

Changes by Thomas Wouters : -- pull_requests: +1118 ___ Python tracker ___ ___

[issue29941] Confusion between asserts and Py_DEBUG

Zachary Ware added the comment: Buildbots are happy, thanks! -- ___ Python tracker ___ ___ Python-bugs-list

[issue29941] Confusion between asserts and Py_DEBUG

Thomas Wouters added the comment: FYI, buildbot issues should be fixed by PR #930. -- ___ Python tracker ___

[issue29941] Confusion between asserts and Py_DEBUG

Changes by Thomas Wouters : -- pull_requests: +1115 ___ Python tracker ___ ___

[issue29941] Confusion between asserts and Py_DEBUG

Changes by Thomas Wouters : -- pull_requests: +1114 ___ Python tracker ___ ___

[issue29941] Confusion between asserts and Py_DEBUG

Zachary Ware added the comment: This seems to have seriously broken a few buildbots: http://buildbot.python.org/all/builders/AMD64%20Debian%20PGO%203.x/builds/539 http://buildbot.python.org/all/builders/AMD64%20FreeBSD%20CURRENT%20Non-Debug%203.x/builds/120

[issue29941] Confusion between asserts and Py_DEBUG

Thomas Wouters added the comment: This needs some measure of backporting, now that it's just build-time fixes. I'll take a look. -- ___ Python tracker

[issue29941] Confusion between asserts and Py_DEBUG

Thomas Wouters added the comment: New changeset a00c3fd12d421e41b769debd7df717d17b0deed5 by T. Wouters in branch 'master': bpo-29941: Assert fixes (#886) https://github.com/python/cpython/commit/a00c3fd12d421e41b769debd7df717d17b0deed5 -- ___

[issue29941] Confusion between asserts and Py_DEBUG

Thomas Wouters added the comment: Dropped the Py_DEBUG guards from the dubious asserts in the PR. -- ___ Python tracker ___

[issue29941] Confusion between asserts and Py_DEBUG

Tim Peters added the comment: So there's more than one issue here. First, should asserts be supported in the absence of Py_DEBUG? It seems, so far, everyone agrees they should be. Second, ...? I'm really not following your argument. It _appears_ to be something along the lines that code

[issue29941] Confusion between asserts and Py_DEBUG

Thomas Wouters added the comment: What happens when you don't have the assert depends on whether the new function call raises an exception or not, and keep in mind *this is what most people see anyway*: if the new call does not raise an exception, a SystemError is raised, with the original

[issue29941] Confusion between asserts and Py_DEBUG

Serhiy Storchaka added the comment: Perhaps it would be better to raise SystemError for errors in user extensions and left assert() only for checking invariants that can't be broken by user code. But checking the condition takes time, assert() is cheaper. Perhaps it would be better to replace

[issue29941] Confusion between asserts and Py_DEBUG

Tim Peters added the comment: I think we should certainly support asserts regardless of whether Py_DEBUG is in force (although Py_DEBUG should imply asserts run too). And I wish you had stuck to just that much ;-) The argument against, e.g., 'assert(!PyErr_Occurred())', seems exceedingly

[issue29941] Confusion between asserts and Py_DEBUG

Changes by Serhiy Storchaka : -- nosy: +haypo, serhiy.storchaka ___ Python tracker ___

[issue29941] Confusion between asserts and Py_DEBUG

Thomas Wouters added the comment: Ugh, I logged in with the wrong OpenID without noticing; that was supposed to be me ;-P -- nosy: +twouters ___ Python tracker

[issue29941] Confusion between asserts and Py_DEBUG

New submission from Thomas Wouters: There is a bit of confusion in the CPython source between Py_DEBUG and (C) asserts. By default Python builds without Py_DEBUG and without asserts (definining NDEBUG to disable them). Turning on Py_DEBUG also enables asserts. However, it *is* possible to