[issue29981] Update Index for set, dict, and generator 'comprehensions'

[Inada Naoki]

Change by Inada Naoki :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions:  -Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29981] Update Index for set, dict, and generator 'comprehensions'

[miss-islington]

miss-islington  added the comment:


New changeset 229eaf20694006c03af0f4740abdf8ae5579 by Miss Skeleton (bot) 
in branch '3.9':
bpo-29981: Add examples and update index for set, dict, and generator 
comprehensions'(GH-20272)
https://github.com/python/cpython/commit/229eaf20694006c03af0f4740abdf8ae5579


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29981] Update Index for set, dict, and generator 'comprehensions'

[miss-islington]

miss-islington  added the comment:


New changeset 60bef61f717dde915058b03159b2c2e97d765858 by Miss Skeleton (bot) 
in branch '3.8':
bpo-29981: Add examples and update index for set, dict, and generator 
comprehensions'(GH-20272)
https://github.com/python/cpython/commit/60bef61f717dde915058b03159b2c2e97d765858


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29981] Update Index for set, dict, and generator 'comprehensions'

[A.M. Kuchling]

A.M. Kuchling  added the comment:


New changeset 2d55aa9e37c9c84f4f6a8135d0326da0bcd8f38b by Florian Dahlitz in 
branch 'master':
bpo-29981: Add examples and update index for set, dict, and generator 
comprehensions'(GH-20272)
https://github.com/python/cpython/commit/2d55aa9e37c9c84f4f6a8135d0326da0bcd8f38b


--
nosy: +akuchling

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29981] Update Index for set, dict, and generator 'comprehensions'

[miss-islington]

Change by miss-islington :


--
keywords: +patch
nosy: +miss-islington
nosy_count: 6.0 -> 7.0
pull_requests: +21790
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/22836

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29981] Update Index for set, dict, and generator 'comprehensions'

[miss-islington]

Change by miss-islington :


--
pull_requests: +21791
pull_request: https://github.com/python/cpython/pull/22837

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29981] Update Index for set, dict, and generator 'comprehensions'

[Florian Dahlitz]

Florian Dahlitz  added the comment:

I guess it would have been good if I waited submitting a PR until you replied 
to my message. This way, I would have known that two separate PRs would be 
better suited here - sorry for that.

Nevertheless, I read the discussions here and in PR #995 and I'm pretty sure 
that the proposed changes do fit into the documentation (pretty similar to 
those from PR #995).

I'm eager to hear your or other people's feedback - thanks!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29981] Update Index for set, dict, and generator 'comprehensions'

[Terry J. Reedy]

Terry J. Reedy  added the comment:

I wrote the above before your PR was listed here.  I will review it a piece at 
a time.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29981] Update Index for set, dict, and generator 'comprehensions'

[Terry J. Reedy]

Terry J. Reedy  added the comment:

The issue is still open. The basic idea is to treat list, set, and dict in 
parallel fashions in the docs, mostly copying what is done with lists for the 
other two.  In my original post, the title and items 1 to 3 are about index 
entries in Reference chapter 6, Expressions (reference/expressions.rst).  I 
tacked on item 4 about adding entries to the Glossary (glossary.rst).  These 
could easily be and for easier review should be separate PRs.

The original PR, opened relatively soon after githup went public, was reviewed 
by 5 different committers, which is an unusually large number.
It included both indexing and glossary changes, and added changes to the 
Library chapter on built-in types (stdtypes.rst).  The last was the most 
controversial and definitely needed to be a followup PR.

In June 2017, after much discussion and revision, Louie Lu switched his github 
account from 'louisom' to 'louielu' and ceased working on this.  Some later, 
louisom/cpython was deleted and the PR closed for inactivity.

> We don't *call* generator expressions 'generator comprehensions',

A subsequent pydev discussion approved of 'generator comprehension' and I 
believe some doc changes followed*.  So I expect that the previous PR is 
somewhat obsolete.  Pick either indexing Expressions or new Glossary entries 
and see what change you think is still needed and consider any discussion of 
that change on PR 995. Note: I am not sure that I reviewed (and approved) the 
index part of the patch, as I likely focused on other parts.   You can propose 
(and justify) changes here before making a PR.

* Any changes may or may not have been backported to 3.7, so it may or may not 
be possible to easily backport any new changes (with the robot).

--
keywords:  -patch
stage: patch review -> needs patch
versions: +Python 3.10, Python 3.8, Python 3.9 -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29981] Update Index for set, dict, and generator 'comprehensions'

[Florian Dahlitz]

Change by Florian Dahlitz :


--
keywords: +patch
pull_requests: +19552
pull_request: https://github.com/python/cpython/pull/20272

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29981] Update Index for set, dict, and generator 'comprehensions'

[Florian Dahlitz]

Florian Dahlitz  added the comment:

I would like to work on this issue if it is still open.

--
nosy: +DahlitzFlorian

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29981] Update Index for set, dict, and generator 'comprehensions'

[R. David Murray]

R. David Murray added the comment:

On the PR Berker wrote:

   I'm wondering if we should still advertise the use of set([...]). We 
replaced all instances of it with set literals in the stdlib.

set([...]) is part of the language, and the python documentation is also a 
specification of the language, so I think the reference *must* stay.

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29981] Update Index for set, dict, and generator 'comprehensions'

[Mariatta Wijaya]

Changes by Mariatta Wijaya :


--
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29981] Update Index for set, dict, and generator 'comprehensions'

[Louie Lu]

Changes by Louie Lu :


--
pull_requests: +1170

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29981] Update Index for set, dict, and generator 'comprehensions'

[Louie Lu]

Changes by Louie Lu :


--
nosy: +louielu

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29981] Update Index for set, dict, and generator 'comprehensions'

[Terry J. Reedy]

Terry J. Reedy added the comment:

See #29983 for expanding the title of the 'atoms' section containing 
subsections on comprehensions.

--
title: Update Index set, dict, and generator 'comprehensions' -> Update Index 
for set, dict, and generator 'comprehensions'

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com