[issue30061] Check if PyObject_Size() raised an error

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue30061] Check if PyObject_Size() raised an error

Serhiy Storchaka added the comment: New changeset 64aa4df8502ca5d0a8ffb767ff97f625625c758c by Serhiy Storchaka in branch '2.7': [2.7] bpo-30061: Check if PyObject_Size()/PySequence_Size()/PyMapping_Size() (GH-1096) (GH-1180) (#1183)

[issue30061] Check if PyObject_Size() raised an error

Serhiy Storchaka added the comment: New changeset e63af29c87b44bb7ada5783cd0ff6ee6d4f9c17c by Serhiy Storchaka in branch '3.5': [3.5] bpo-30061: Check if PyObject_Size()/PySequence_Size()/PyMapping_Size() (GH-1096) (GH-1180) (#1182)

[issue30061] Check if PyObject_Size() raised an error

Changes by Serhiy Storchaka : -- pull_requests: +1312 ___ Python tracker ___ ___

[issue30061] Check if PyObject_Size() raised an error

Changes by Serhiy Storchaka : -- pull_requests: +1311 ___ Python tracker ___ ___

[issue30061] Check if PyObject_Size() raised an error

Serhiy Storchaka added the comment: New changeset 680fea4067537a9b9c79aadd44a3a19e83cd2dbf by Serhiy Storchaka in branch '3.6': bpo-30061: Check if PyObject_Size()/PySequence_Size()/PyMapping_Size() (#1096) (#1180)

[issue30061] Check if PyObject_Size() raised an error

Changes by Serhiy Storchaka : -- pull_requests: +1308 ___ Python tracker ___ ___

[issue30061] Check if PyObject_Size() raised an error

Serhiy Storchaka added the comment: New changeset bf623ae8843dc30b28c574bec8d29fc14be59d86 by Serhiy Storchaka in branch 'master': bpo-30061: Check if PyObject_Size()/PySequence_Size()/PyMapping_Size() (#1096) https://github.com/python/cpython/commit/bf623ae8843dc30b28c574bec8d29fc14be59d86

[issue30061] Check if PyObject_Size() raised an error

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___

[issue30061] Check if PyObject_Size() raised an error

Changes by Serhiy Storchaka : -- pull_requests: +1294 ___ Python tracker ___ ___

[issue30061] Check if PyObject_Size() raised an error

Serhiy Storchaka added the comment: Raymond, could you please look at the change in Objects/setobject.c? It makes the code slightly faster (by avoiding few function calls: PyObject_Size(), PySequence_Size()/PyMapping_Size() and sq_length/mp_length), but the main purpose is making clear that

[issue30061] Check if PyObject_Size() raised an error

Changes by Xiang Zhang : -- nosy: +xiang.zhang ___ Python tracker ___ ___ Python-bugs-list

[issue30061] Check if PyObject_Size() raised an error

Changes by Serhiy Storchaka : -- pull_requests: +1239 ___ Python tracker ___ ___

[issue30061] Check if PyObject_Size() raised an error

Changes by Serhiy Storchaka : -- stage: -> patch review ___ Python tracker ___

[issue30061] Check if PyObject_Size() raised an error

New submission from Serhiy Storchaka: PyObject_Size(), PySequence_Size() and PyMapping_Size() can raise an exception. But not always this is checked after using them. This can lead to a crash. For example: >>> import io >>> class R(io.IOBase): ... def readline(self): return None ... >>>