[issue30109] make reindent failed.

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue30109] make reindent failed.

Serhiy Storchaka added the comment: New changeset 17cec70a38b297779b8fd3f081fb041d45ae1dff by Serhiy Storchaka in branch '2.7': bpo-30109: Fix reindent.py for non-ASCII files. (#5637) https://github.com/python/cpython/commit/17cec70a38b297779b8fd3f081fb041d45ae1dff -- __

[issue30109] make reindent failed.

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +5437 stage: backport needed -> patch review ___ Python tracker ___ _

[issue30109] make reindent failed.

Serhiy Storchaka added the comment: 2.7 needs different solution. The side effect of issue10639 in 2.7 was changing input and output files for the reindenter to Unicode files. This was not correct. Standard streams stdin/stdout in 2.7 are binary files, and the tokenizer needs the stream of b

[issue30109] make reindent failed.

Change by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30109] make reindent failed.

Mariatta Wijaya added the comment: make reindent is still failing on 2.7 branch, but I haven't had chance to look into the fix. Not really sure if we want to bother? Anyways, I've unassigned myself so if someone else want to look into it, they can. Not sure if it's worth the effort. (not a lot

[issue30109] make reindent failed.

Mariatta Wijaya added the comment: Thanks for the ping. Almost forgotten about this issue. This can't be cherry-picked cleanly. I need to first backport the new testcase to 2.7, and see if it passes. If the test failed in 2.7 then I need to work on actually backporting the change. I should h

[issue30109] make reindent failed.

Cheryl Sabella added the comment: Does this just need to be cherry-picked to 2.7 to be able to close it? -- nosy: +csabella ___ Python tracker ___ _

[issue30109] make reindent failed.

Mariatta Wijaya added the comment: New changeset 430020500c56259d31e07d32771f017952bad4e0 by Mariatta in branch '3.6': [3.6] bpo-30109: Fix reindent.py (GH-1207) (GH-1208) https://github.com/python/cpython/commit/430020500c56259d31e07d32771f017952bad4e0 -- ___

[issue30109] make reindent failed.

Mariatta Wijaya added the comment: New changeset 60d27f42a07d0b9d4a2c3fb160cac1683e91f196 by Mariatta in branch '3.5': [3.5] bpo-30109: Fix reindent.py (GH-1207) (GH-1209) https://github.com/python/cpython/commit/60d27f42a07d0b9d4a2c3fb160cac1683e91f196 -- ___

[issue30109] make reindent failed.

Serhiy Storchaka added the comment: I don't know whether the fix for 2.7 is needed. The interface of tokenize is different in 2.7. Just run the new test and see if it fails. -- nosy: +serhiy.storchaka ___ Python tracker

[issue30109] make reindent failed.

Changes by Mariatta Wijaya : -- stage: patch review -> backport needed versions: +Python 2.7, Python 3.5, Python 3.6 ___ Python tracker ___ __

[issue30109] make reindent failed.

Changes by Mariatta Wijaya : -- pull_requests: +1330 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue30109] make reindent failed.

Changes by Mariatta Wijaya : -- pull_requests: +1331 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue30109] make reindent failed.

Mariatta Wijaya added the comment: New changeset 58f3c9dc8f5626abe09ac9738c34f6ba99ce2972 by Mariatta in branch 'master': bpo-30109: Fix reindent.py (GH-1207) https://github.com/python/cpython/commit/58f3c9dc8f5626abe09ac9738c34f6ba99ce2972 -- ___

[issue30109] make reindent failed.

Changes by Mariatta Wijaya : -- assignee: -> Mariatta nosy: +Mariatta stage: -> patch review ___ Python tracker ___ ___ Python-bugs-

[issue30109] make reindent failed.

Changes by Mariatta Wijaya : -- pull_requests: +1329 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue30109] make reindent failed.

Changes by Dong-hee Na : -- type: -> behavior versions: +Python 3.7 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue30109] make reindent failed.

New submission from Dong-hee Na: When I try to `make reindent` It was failed with this messages. ./python.exe ./Tools/scripts/reindent.py -r ./Lib Traceback (most recent call last): File "/Users/corona10/cpython/Lib/tokenize.py", line 404, in find_cookie codec = lookup(encoding) Look