[issue3015] tkinter with wantobjects=False has been broken for some time

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue3015] tkinter with wantobjects=False has been broken for some time

Lita Cho added the comment: That's perfect. I agree that this issue is closed! :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3015 ___ ___

[issue3015] tkinter with wantobjects=False has been broken for some time

Roundup Robot added the comment: New changeset c69e8ea3bf10 by Serhiy Storchaka in branch 'default': Issue #3015: _tkinter.create() now creates tkapp object with wantobject=1 by http://hg.python.org/cpython/rev/c69e8ea3bf10 -- ___ Python tracker

[issue3015] tkinter with wantobjects=False has been broken for some time

Serhiy Storchaka added the comment: Lita Cho, originally reported issue is fixed. I asked Martin (and Guilherme if he is here). Are you agree to close this issue? See issue21585 about extending testing. -- ___ Python tracker rep...@bugs.python.org

[issue3015] tkinter with wantobjects=False has been broken for some time

Lita Cho added the comment: Serhiy, does that mean this is fixed the way it is? Do I need to do anything else to close out this issue? It looks like wantobjects is set to False, currently. -- ___ Python tracker rep...@bugs.python.org

[issue3015] tkinter with wantobjects=False has been broken for some time

Jessica McKellar added the comment: @Lita.Cho: (I'd like to this on the web but the links are still broken after the website port) if you search for `wantobjects` in `Doc/whatsnew/2.3.rst`, there's a description of why the parameter was added. --

[issue3015] tkinter with wantobjects=False has been broken for some time

Serhiy Storchaka added the comment: Now I think we shouldn't deprecate and remove wantobjects=False. Tkinter was partially broken with wantobjects=False, on other hand, it was partially broken with wantobjects=True. Many bugs was fixed last months, all tests now work with wantobjects=False,

[issue3015] tkinter with wantobjects=False has been broken for some time

Changes by Lita Cho lita@gmail.com: -- nosy: +Lita.Cho, jesstess ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3015 ___ ___ Python-bugs-list

[issue3015] tkinter with wantobjects=False has been broken for some time

Lita Cho added the comment: I am in the process of reviewing this patch, but I don't know what wantobjects does. I can make a guess, I think it is a hack to make tcl objects work in Python. I am guessing this is less needed in Python 3.4, but still has some dependencies. If we can add in

[issue3015] tkinter with wantobjects=False has been broken for some time

Changes by Serhiy Storchaka storch...@gmail.com: -- assignee: - serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3015 ___ ___

[issue3015] tkinter with wantobjects=False has been broken for some time

Roundup Robot added the comment: New changeset 08c45e18e7b2 by Serhiy Storchaka in branch '3.3': Issue #3015: Fixed tkinter with wantobject=False. Any Tcl command call http://hg.python.org/cpython/rev/08c45e18e7b2 New changeset 65dd0de6b4a5 by Serhiy Storchaka in branch 'default': Issue #3015:

[issue3015] tkinter with wantobjects=False has been broken for some time

Serhiy Storchaka added the comment: Here is a patch which change the default value for the wantobjects parameter of _tkinter.create() and adds deprecation warnings. -- stage: - patch review type: - behavior versions: -Python 3.3 ___ Python

[issue3015] tkinter with wantobjects=False has been broken for some time

Arfrever Frehtes Taifersar Arahesis added the comment: Here is a patch You again forgot to attach a patch :) . -- nosy: +Arfrever ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3015 ___

[issue3015] tkinter with wantobjects=False has been broken for some time

Serhiy Storchaka added the comment: Oh, thanks Arfrever. -- Added file: http://bugs.python.org/file31827/tkinter_deprecate_wantobjects.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3015

[issue3015] tkinter with wantobjects=False has been broken for some time

Serhiy Storchaka added the comment: Looks as issue18877 is related to this. I have proposed for it a little different patch than first Guilherme's patch. As for removing wantobjects, we perhaps can do this only in 3.4. -- nosy: +serhiy.storchaka versions: +Python 3.3, Python 3.4

[issue3015] tkinter with wantobjects=False has been broken for some time

Changes by Andrew Svetlov andrew.svet...@gmail.com: -- nosy: +asvetlov ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3015 ___ ___ Python-bugs-list

[issue3015] tkinter with wantobjects=False has been broken for some time

Guilherme Polo [EMAIL PROTECTED] added the comment: I will agree that wantobjects=False should go, it is also discouraged to use Tcl_GetStringResult because it may lose information. But something should be done at FromObj since it accesses Tcl_Obj fields directly, and it may end up not using

[issue3015] tkinter with wantobjects=False has been broken for some time

Guilherme Polo [EMAIL PROTECTED] added the comment: I've removed wantobjects and substituted some internalRep usage too. Added file: http://bugs.python.org/file10484/remove_wantobjects_internalRep.diff ___ Python tracker [EMAIL PROTECTED]

[issue3015] tkinter with wantobjects=False has been broken for some time

New submission from Guilherme Polo [EMAIL PROTECTED]: This affects only py3k, but apparently tkinter has been in this situation for more than 9 months now. I see these lines at _tkinter.c: const char *s = Tcl_GetStringResult(self-interp); const char *p = s; res = PyUnicode_FromStringAndSize(s,

[issue3015] tkinter with wantobjects=False has been broken for some time

Martin v. Löwis [EMAIL PROTECTED] added the comment: I think in Python 3, the whole wantobjects=False case should go. It was a compatibility measure to support applications that didn't expect Tcl objects; for Python 3, only a single case should be supported. -- nosy: +loewis