[issue30157] csv.Sniffer.sniff() regex error

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Thank you for your contribution Jake!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30157] csv.Sniffer.sniff() regex error

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 504f19145ca5738162d6a720fa45b364ac8c0384 by Serhiy Storchaka in 
branch '3.6':
[3.6] bpo-30157: Fix csv.Sniffer.sniff() regex pattern. (GH-5601) (GH-5603)
https://github.com/python/cpython/commit/504f19145ca5738162d6a720fa45b364ac8c0384


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30157] csv.Sniffer.sniff() regex error

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset e7197936c987bdf31b6b7b1dab275d1a762e03b3 by Serhiy Storchaka in 
branch '2.7':
[2.7] bpo-30157: Fix csv.Sniffer.sniff() regex pattern. (GH-5601) (GH-5604)
https://github.com/python/cpython/commit/e7197936c987bdf31b6b7b1dab275d1a762e03b3


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30157] csv.Sniffer.sniff() regex error

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 2ef69a1d45de8aa41c45d32d9ee1ff227bb1a566 by Serhiy Storchaka 
(Miss Islington (bot)) in branch '3.7':
bpo-30157: Fix csv.Sniffer.sniff() regex pattern. (GH-5601) (GH-5602)
https://github.com/python/cpython/commit/2ef69a1d45de8aa41c45d32d9ee1ff227bb1a566


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30157] csv.Sniffer.sniff() regex error

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
pull_requests: +5416

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30157] csv.Sniffer.sniff() regex error

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
pull_requests: +5415

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30157] csv.Sniffer.sniff() regex error

[miss-islington]

Change by miss-islington :


--
pull_requests: +5414

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30157] csv.Sniffer.sniff() regex error

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 2411292ba8155327125d8a1da8a4c9fa003d5909 by Serhiy Storchaka in 
branch 'master':
bpo-30157: Fix csv.Sniffer.sniff() regex pattern. (GH-5601)
https://github.com/python/cpython/commit/2411292ba8155327125d8a1da8a4c9fa003d5909


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30157] csv.Sniffer.sniff() regex error

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
versions: +Python 3.8 -Python 3.3, Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30157] csv.Sniffer.sniff() regex error

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
keywords: +patch
pull_requests: +5413
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30157] csv.Sniffer.sniff() regex error

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Since the original author didn't respond for long time I have recreated PR 1273 
as PR 5601.

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30157] csv.Sniffer.sniff() regex error

[Jake Davis]

Jake Davis added the comment:

I've added some unittests for Sniffer._guess_quote_and_delimiter(); they should 
prevent regression.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30157] csv.Sniffer.sniff() regex error

[Jake Davis]

Jake Davis added the comment:

Will do! I will try to get a regression proof test into test_csv.py in the next 
24 hours. Essentially I will make sure that the sniffer returns a positive 
match for each of the patterns that the regex is intended to hit.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30157] csv.Sniffer.sniff() regex error

[R. David Murray]

R. David Murray added the comment:

If it is a bug that indicates there is at least one missing unit test :)  Maybe 
the OP will contribute a test.

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30157] csv.Sniffer.sniff() regex error

[STINNER Victor]

STINNER Victor added the comment:

Can you please try to write a unit test to check for non-regression? Or at 
least give an example?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30157] csv.Sniffer.sniff() regex error

[Matthew Barnett]

Matthew Barnett added the comment:

There are 4 patterns. They try to determine the delimiter and quote by looking 
for matches. Each pattern supposedly covers one of 4 cases:

1. Delimiter, quote, value, quote, delimiter.

2. Start of line/text, quote, value, quote, delimiter.

3. Delimiter, quote, value, quote, end of line/text.

4. Start of line/text, quote, value, quote, end of line/text.

On that basis, case 3 looks wrong because the pattern for delimiter is:

>[^\w\n"\']

instead of the expected:

[^\w\n"\']

Looks like a bug to me.

--
nosy: +mrabarnett

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30157] csv.Sniffer.sniff() regex error

[STINNER Victor]

STINNER Victor added the comment:

What is the consequence of this change? Does it change the syntax of the 
parser? Which kind of format wasn't parsed correctly?

--
nosy: +haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30157] csv.Sniffer.sniff() regex error

[Louie Lu]

Changes by Louie Lu :


--
title: csn.Sniffer.sniff() regex error -> csv.Sniffer.sniff() regex error

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com