[issue30271] Make sqlite3 statement cache optional

[Aviv Palivoda]

Aviv Palivoda  added the comment:

I think we can close this issue and open a different one that will disable the 
cache implicitly on `set_authorizer()`.

--
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30271] Make sqlite3 statement cache optional

[Berker Peksag]

Change by Berker Peksag :


--
resolution:  -> rejected

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30271] Make sqlite3 statement cache optional

[Raymond Hettinger]

Raymond Hettinger  added the comment:

> I do believe we should allow the user to disable the cache.

Why?

--
nosy: +rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30271] Make sqlite3 statement cache optional

[Berker Peksag]

Berker Peksag  added the comment:

I'd prefer disabling statement cache implicitly when set_authorizer() is 
called. There's no need to expose this to end users.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30271] Make sqlite3 statement cache optional

[Aviv Palivoda]

Aviv Palivoda  added the comment:

I don't have any specific use case for making the statement cache optional. I 
expected that by changing the cache size to 0 there will be no statement cache. 
I think that this is a common assumption as can be seen in 
https://github.com/ghaering/pysqlite/issues/126#issue-346189937.

rogerbinns did give a use case where we would like to disable the statement 
cache in 
https://github.com/ghaering/pysqlite/issues/126#issuecomment-410030910. I think 
that statement cache should be disable implicitly in that case as you suggest. 
The code change will be very similar and I do believe we should allow the user 
to disable the cache. I will be happy to open a new PR once this is merged that 
will disable the statement cache implicitly when calling `set_authorizer()`

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30271] Make sqlite3 statement cache optional

[Berker Peksag]

Berker Peksag  added the comment:

Thanks for the report. What is your use case for making the statement caching 
optional? Did you notice any performance improvement when you use it with newer 
SQLite versions?

--
stage:  -> patch review
versions: +Python 3.8 -Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30271] Make sqlite3 statement cache optional

[Aviv Palivoda]

Changes by Aviv Palivoda :


--
pull_requests: +1560

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30271] Make sqlite3 statement cache optional

[Aviv Palivoda]

New submission from Aviv Palivoda:

Currently the minimum size of the statement cache is 10. I suggest that it will 
be any value above 1 or no cache at all if the size is set to 0.

--
components: Extension Modules
messages: 293006
nosy: berker.peksag, ghaering, palaviv
priority: normal
severity: normal
status: open
title: Make sqlite3 statement cache optional
type: enhancement
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com