[issue30645] imp.py: load_package() appends to its own loop variable

Changes by Brett Cannon : -- resolution: -> fixed stage: -> resolved status: open -> closed versions: +Python 3.5 ___ Python tracker

[issue30645] imp.py: load_package() appends to its own loop variable

Brett Cannon added the comment: New changeset 599ff020b308113f3709fd4e623d9f0d08511706 by Brett Cannon in branch '3.5': [3.5] bpo-30645: don't append to an inner loop path in imp.load_package() (GH-2268) (GH-2365)

[issue30645] imp.py: load_package() appends to its own loop variable

Brett Cannon added the comment: New changeset 9db3ae045dd462a2da2e016c44231de1befd1f87 by Brett Cannon in branch '3.6': [3.6] bpo-30645: don't append to an inner loop path in imp.load_package() (GH-2268) (#2364) https://github.com/python/cpython/commit/9db3ae045dd462a2da2e016c44231de1befd1f87

[issue30645] imp.py: load_package() appends to its own loop variable

Changes by Brett Cannon : -- pull_requests: +2414 ___ Python tracker ___ ___

[issue30645] imp.py: load_package() appends to its own loop variable

Changes by Brett Cannon : -- pull_requests: +2413 ___ Python tracker ___ ___

[issue30645] imp.py: load_package() appends to its own loop variable

Brett Cannon added the comment: New changeset c38e32a10061a7c6d54e7e53ffabf7af7998f045 by Brett Cannon (Alexandru Ardelean) in branch 'master': bpo-30645: don't append to an inner loop path in imp.load_package() (GH-2268)

[issue30645] imp.py: load_package() appends to its own loop variable

Alexandru Ardelean added the comment: Admittedly, that PR refers to `imp.load_module()` But, `imp.load_modules()` also calls `imp.load_package()` -- ___ Python tracker

[issue30645] imp.py: load_package() appends to its own loop variable

Alexandru Ardelean added the comment: FWIW, I took a look over the virtualenv repo. There's an issue raised there https://github.com/pypa/virtualenv/issues/955 And a PR to address it https://github.com/pypa/virtualenv/pull/947 Though, it seems like they still want to keep `imp.load_package()`

[issue30645] imp.py: load_package() appends to its own loop variable

Changes by Alexandru Ardelean : -- pull_requests: +2318 ___ Python tracker ___ ___

[issue30645] imp.py: load_package() appends to its own loop variable

Brett Cannon added the comment: Yes, we're as corporate as an open source project that doesn't have enough funding to be able to defend against a lawsuit but is big enough that simply shutting down would really suck for millions of people. ;) Anyway, your CLA signing came through so now we

[issue30645] imp.py: load_package() appends to its own loop variable

R. David Murray added the comment: Yes, that's all you needed to do. She updated your status in the tracker (you now have the CLA signed '*' next to your name). -- ___ Python tracker

[issue30645] imp.py: load_package() appends to its own loop variable

Alexandru Ardelean added the comment: I already completed those steps. Question is: what do I do with the output from that eSign ? Or, how do I use it ? It only mentions "Finally, click the "eSign" button to have the form sent to the PSF Secretary, Ewa Jodlowska." It's unclear from there-on

[issue30645] imp.py: load_package() appends to its own loop variable

SylvainDe added the comment: Alexandru: You'll find the PSF Contributor Agreement at https://www.python.org/psf/contrib/contrib-form/ . -- nosy: +SylvainDe ___ Python tracker

[issue30645] imp.py: load_package() appends to its own loop variable

Alexandru Ardelean added the comment: Damn. You guys are more corporate than... ... anyway. Please tell me, how to send you my signed CLA. Not sure if posting the link or PDF is fine here, but I'd be fine with that too. To resolve your first 2 notes: I am not using the imp module, nor the

[issue30645] imp.py: load_package() appends to its own loop variable

Changes by Brett Cannon : -- title: imp.py: load_package: function has a buggy loop with `path = os.path.join(path, '__init__'+extension)` -> imp.py: load_package() appends to its own loop variable ___ Python tracker