[issue30701] Exception parsing certain invalid email address headers

[Irit Katriel]

Change by Irit Katriel :


--
resolution:  -> out of date
stage:  -> resolved
status: pending -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30701] Exception parsing certain invalid email address headers

[Irit Katriel]

Irit Katriel  added the comment:

I don't see the error now, I think this has been fixed.

--
nosy: +iritkatriel
status: open -> pending

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30701] Exception parsing certain invalid email address headers

[Tim Bell]

Tim Bell  added the comment:

This appears to be the same issue as subsequently reported in #34155.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30701] Exception parsing certain invalid email address headers

[Karthikeyan Singaravelan]

Change by Karthikeyan Singaravelan :


--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30701] Exception parsing certain invalid email address headers

[Nick Coghlan]

Changes by Nick Coghlan :


--
nosy: +ncoghlan

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30701] Exception parsing certain invalid email address headers

[Tim Bell]

Tim Bell added the comment:

I'm using the email package to ingest a firehose of spam; spammers aren't known 
for following norms or standards, so it's not surprising that I'm discovering 
lots of edge cases.

I'll supply fixes for what I find where I can, time permitting.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30701] Exception parsing certain invalid email address headers

[R. David Murray]

R. David Murray added the comment:

Yep, you found an edge case I didn't write a test for.  The defect should get 
added to the header object during parsing.  (Those are supposed to get copied 
to the message object...)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30701] Exception parsing certain invalid email address headers

[Tim Bell]

New submission from Tim Bell:

According to RFC 5322, an email address like this isn't valid:

u...@example.com 

(The display-name "u...@example.com" contains "@", which isn't in the set of 
atext characters used to form an atom.)

How it's handled by the email package varies by policy:

>>> import email
>>> from email.policy import default
>>> email.message_from_bytes(b'To: u...@example.com ')['to']
'u...@example.com '
>>> email.message_from_bytes(b'To: u...@example.com ', 
>>> policy=default)['to']
'u...@example.com'
>>> email.message_from_bytes(b'To: u...@example.com ', 
>>> policy=default).defects
[]

The difference between the behaviour under the compat32 vs "default" policy may 
or may not be significant.

However, if coupled with a further invalid feature, namely a space after the 
">", here's what happens:

>>> email.message_from_bytes(b'To: u...@example.com  ')['to']
'u...@example.com  '
>>> email.message_from_bytes(b'To: u...@example.com  ', 
>>> policy=default)['to']
Traceback (most recent call last):
  File "", line 1, in 
  File 
"/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/email/message.py",
 line 391, in __getitem__
return self.get(name)
  File 
"/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/email/message.py",
 line 471, in get
return self.policy.header_fetch_parse(k, v)
  File 
"/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/email/policy.py",
 line 162, in header_fetch_parse
return self.header_factory(name, value)
  File 
"/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/email/headerregistry.py",
 line 586, in __call__
return self[name](name, value)
  File 
"/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/email/headerregistry.py",
 line 197, in __new__
cls.parse(value, kwds)
  File 
"/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/email/headerregistry.py",
 line 337, in parse
kwds['parse_tree'] = address_list = cls.value_parser(value)
  File 
"/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/email/headerregistry.py",
 line 328, in value_parser
address_list, value = parser.get_address_list(value)
  File 
"/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/email/_header_value_parser.py",
 line 2368, in get_address_list
token, value = get_invalid_mailbox(value, ',')
  File 
"/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/email/_header_value_parser.py",
 line 2166, in get_invalid_mailbox
token, value = get_phrase(value)
  File 
"/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/email/_header_value_parser.py",
 line 1770, in get_phrase
token, value = get_word(value)
  File 
"/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/email/_header_value_parser.py",
 line 1745, in get_word
if value[0]=='"':
IndexError: string index out of range
>>> email.message_from_bytes(b'To: u...@example.com  ', 
>>> policy=default).defects
[]

I believe that the preferred behaviour would be to add a defect to the message 
object during parsing instead of throwing an exception when the invalid header 
value is accessed.

--
components: email
messages: 296309
nosy: barry, r.david.murray, timb07
priority: normal
severity: normal
status: open
title: Exception parsing certain invalid email address headers
type: behavior
versions: Python 3.5, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com