[issue30728] IDLE: Modernize configdialog code.

2017-07-24 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- dependencies: -test_bsddb3 crash on x86 Windows XP 2.7 ___ Python tracker ___

[issue30728] IDLE: Modernize configdialog code.

2017-06-26 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 938e73809d10f6073c85ecd330c88a85c6095530 by terryjreedy in branch '3.6': [3.6] bpo-30728: IDLE: Refactor configdialog to PEP8 names (GH-2307) (#2421) https://github.com/python/cpython/commit/938e73809d10f6073c85ecd330c88a85c6095530 --

[issue30728] IDLE: Modernize configdialog code.

2017-06-26 Thread Terry J. Reedy
Terry J. Reedy added the comment: I decided that most other changes should be separate issues that are dependencies of this one. 30779 Docstrings and comments 28523 Colour to color 30779 Factor out Changes class 30780 Test GUI - depends on 30779 30781 Switch to ttk - depends on 30780

[issue30728] IDLE: Modernize configdialog code.

2017-06-26 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- pull_requests: +2471 ___ Python tracker ___ ___

[issue30728] IDLE: Modernize configdialog code.

2017-06-26 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset bac7d3363b099d0cdef3e541f8581859edfddc85 by terryjreedy (csabella) in branch 'master': bpo-30728: IDLE: Refactor configdialog to PEP8 names (#2307) https://github.com/python/cpython/commit/bac7d3363b099d0cdef3e541f8581859edfddc85 --

[issue30728] IDLE: Modernize configdialog code.

2017-06-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: I reviewed IDLE issues with patches. I will post my updated issues list on the roadmap issue, #30422. Of relevance to this issue is that config related patches are split between config, configdialog, and config_key, and limited to 3 or 4 each. I decided

[issue30728] IDLE: Modernize configdialog code.

2017-06-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: Yes, I intend to add the expanded list, further edited, to the roadmap, or something not tied to one issue. I should add changing messagebox and font imports. Except for switching to ttk widgets, the changes listed are invisible to users. The purpose of

[issue30728] IDLE: Modernize configdialog code.

2017-06-22 Thread Cheryl Sabella
Cheryl Sabella added the comment: Hi Terry, I don't have a script for the renaming. Since I was reading the code for the docstrings at the same time, I just made the changes as I went along. However, my primary intent is to save you time and work, not cause more, so I will prepare the

[issue30728] IDLE: Modernize configdialog code.

2017-06-21 Thread Terry J. Reedy
Terry J. Reedy added the comment: I moved PR 2307 here. I made trivial PR 2322 for the config_key typo. Cheryl, how did you do the name changes? Did you prepare a rename mapping or script that could be applied to other patch files? If so, please upload. If sensibly possible, I would like

[issue30728] IDLE: Modernize configdialog code.

2017-06-21 Thread Cheryl Sabella
Changes by Cheryl Sabella : -- pull_requests: +2370 ___ Python tracker ___ ___

[issue30728] IDLE: Modernize configdialog code.

2017-06-21 Thread Terry J. Reedy
New submission from Terry J. Reedy: Depending on the file, modernizing includes: * Add docstrings. * Change non-class names with caps to PEP8 no-caps names; this often means, for example, changing embedded 'A' to '_a'. * Make most comments be sentences, like this sentence. * Review and