[issue30830] test_logging leaks dangling threads on FreeBSD

STINNER Victor added the comment: Ok, the main bugs have been fixed by the following socketserver fix. commit b8f4163da30e16c7cd58fe04f4b17e38d53cd57e Author: Victor Stinner Date: Wed Sep 13 01:47:22 2017 -0700 bpo-31233:

[issue30830] test_logging leaks dangling threads on FreeBSD

STINNER Victor added the comment: New changeset 97d7e65dfed1d42d40d9bc2f630af56240555f02 by Victor Stinner in branch 'master': bpo-30830: logging.config.listen() calls server_close() (#3524) https://github.com/python/cpython/commit/97d7e65dfed1d42d40d9bc2f630af56240555f02 --

[issue30830] test_logging leaks dangling threads on FreeBSD

STINNER Victor added the comment: While testing PR 3138 (stricter threading_cleanup) with PR 3523 (socketserver joins threads), I got the following warning: test_listen_config_1_ok (test.test_logging.ConfigDictTest) ... Warning -- threading_cleanup() detected 1 leaked threads (count: 1,

[issue30830] test_logging leaks dangling threads on FreeBSD

Changes by STINNER Victor : -- pull_requests: +3523 ___ Python tracker ___ ___

[issue30830] test_logging leaks dangling threads on FreeBSD

Changes by STINNER Victor : -- keywords: +patch pull_requests: +3522 stage: -> patch review ___ Python tracker ___

[issue30830] test_logging leaks dangling threads on FreeBSD

STINNER Victor added the comment: > New changeset 6966960468327c958b03391f71f24986bd697307 by Victor Stinner in > branch 'master': > bpo-30830: test_logging uses threading_setup/cleanup (#3137) With this commit, test_logging should detect better bugs in the code. The commit also skips all

[issue30830] test_logging leaks dangling threads on FreeBSD

STINNER Victor added the comment: New changeset 6966960468327c958b03391f71f24986bd697307 by Victor Stinner in branch 'master': bpo-30830: test_logging uses threading_setup/cleanup (#3137) https://github.com/python/cpython/commit/6966960468327c958b03391f71f24986bd697307 --

[issue30830] test_logging leaks dangling threads on FreeBSD

STINNER Victor added the comment: I opened bpo-31233: socketserver.ThreadingMixIn leaks running threads after server_close(). -- dependencies: +socketserver.ThreadingMixIn leaks running threads after server_close() ___ Python tracker

[issue30830] test_logging leaks dangling threads on FreeBSD

Changes by STINNER Victor : -- pull_requests: +3171 ___ Python tracker ___ ___

[issue30830] test_logging leaks dangling threads on FreeBSD

STINNER Victor added the comment: > Example: > > 10-STABLE-amd64% ./python -m test -v test_logging --fail-env-changed -F -m > test.test_logging.DatagramHandlerTest.test_output -m > test.test_logging.ConfigDictTest.test_listen_config_10_ok >

[issue30830] test_logging leaks dangling threads on FreeBSD

STINNER Victor added the comment: The problem is that socketserver.ThreadingMixIn spawns threads without waiting for their completion in server_close(). For example, the following two tests use socketserver.ThreadingMixIn and so can leak a running thread: *

[issue30830] test_logging leaks dangling threads on FreeBSD

Changes by STINNER Victor : -- pull_requests: +3170 ___ Python tracker ___ ___

[issue30830] test_logging leaks dangling threads on FreeBSD

STINNER Victor added the comment: http://buildbot.python.org/all/builders/AMD64%20FreeBSD%2010.x%20Shared%203.x/builds/698/steps/test/logs/stdio test_output (test.test_logging.UnixDatagramHandlerTest) ... ok test_output (test.test_logging.UnixSysLogHandlerTest) ... ok test__all__

[issue30830] test_logging leaks dangling threads on FreeBSD

Changes by STINNER Victor : -- title: test_logging leaks a "dangling" threads on FreeBSD -> test_logging leaks dangling threads on FreeBSD ___ Python tracker