[issue30900] IDLE: Fix configdialog should use wm_withdraw

2017-07-11 Thread Terry J. Reedy
Terry J. Reedy added the comment: I first beat my head against event_generate two or three years ago. So I appreciate you taking a whack at it. It is nice that Variable.set and invoke can be used for tests, but it would really be nice to have e_v work too. --

[issue30900] IDLE: Fix configdialog should use wm_withdraw

2017-07-11 Thread Louie Lu
Louie Lu added the comment: Hmmm, I think it is a mistake of my test, it is something inside configdialog __init__ make unittest can't do event_generate, but not this one `self.withdraw`. -- resolution: -> not a bug stage: -> resolved status: open -> closed

[issue30900] IDLE: Fix configdialog should use wm_withdraw

2017-07-11 Thread Terry J. Reedy
Terry J. Reedy added the comment: Color me dubious ;-). The change was made because tkinter.__init__, line 1990 has this line withdraw = wm_withdraw There is a similar line for all of the around 30 wm_xyz functions. Prefixing the names of methods of class Wm is an unusual redundancy. I

[issue30900] IDLE: Fix configdialog should use wm_withdraw

2017-07-11 Thread Louie Lu
Changes by Louie Lu : -- pull_requests: +2729 ___ Python tracker ___ ___ Python-bugs-list

[issue30900] IDLE: Fix configdialog should use wm_withdraw

2017-07-11 Thread Louie Lu
New submission from Louie Lu: Introduce in #30728, commit bac7d3363b099d, `self.wm_withdraw` has been changed into `self.withdraw`. This make #30870 un-testable since it using `self.withdraw` will block out `event_generate`. This issue revert `self.widthdraw` to `self.wm_withdraw`.