[issue31002] IDLE: Add tests for configdialog keys tab

2017-08-15 Thread Terry J. Reedy
Terry J. Reedy added the comment: Lines not yet covered in keys group, other than deactivate_current_config and activate_config_changes functions: def save_new_key_set if not idleConf.userCfg['keys'].has_section(keyset_name): # never false - minor issue def delete_custom_keys if not

[issue31002] IDLE: Add tests for configdialog keys tab

2017-08-14 Thread Terry J. Reedy
Terry J. Reedy added the comment: Great work. Thank you. Next: #31205, #31001, #31206, then ... -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker

[issue31002] IDLE: Add tests for configdialog keys tab

2017-08-14 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset a31459008c5b3230363d155a2e8616664dc4f0c6 by Terry Jan Reedy in branch '3.6': [3.6] bpo-31002: IDLE: Add tests for configdialog keys tab (GH-2996) (#3092) https://github.com/python/cpython/commit/a31459008c5b3230363d155a2e8616664dc4f0c6

[issue31002] IDLE: Add tests for configdialog keys tab

2017-08-14 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- pull_requests: +3132 ___ Python tracker ___ ___

[issue31002] IDLE: Add tests for configdialog keys tab

2017-08-14 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 2f8964634918bdf09107c49a2d5ca62460091e54 by Terry Jan Reedy (Cheryl Sabella) in branch 'master': bpo-31002: IDLE: Add tests for configdialog keys tab (#2996) https://github.com/python/cpython/commit/2f8964634918bdf09107c49a2d5ca62460091e54

[issue31002] IDLE: Add tests for configdialog keys tab

2017-08-10 Thread Terry J. Reedy
Terry J. Reedy added the comment: I have thought about factoring out common test code into helper functions either within test_configdialog or in a new module. One example: simulate a click on a listbox, with common before and after code. Another: Testing the group of selection widgets on

[issue31002] IDLE: Add tests for configdialog keys tab

2017-08-10 Thread Terry J. Reedy
Terry J. Reedy added the comment: I am not sure I agree with all your suggested name changes. But I am looking as more substantive issues first. -- ___ Python tracker

[issue31002] IDLE: Add tests for configdialog keys tab

2017-08-03 Thread Cheryl Sabella
Cheryl Sabella added the comment: I tried to minimize the changes to configdialog. There were more I wanted to make, like reorganizing the order of the functions, but I didn't want to make the diff too crazy. I changed some variable names because all of them had 'keys' in it and I couldn't

[issue31002] IDLE: Add tests for configdialog keys tab

2017-08-03 Thread Cheryl Sabella
Changes by Cheryl Sabella : -- pull_requests: +3032 ___ Python tracker ___ ___

[issue31002] IDLE: Add tests for configdialog keys tab

2017-08-02 Thread Cheryl Sabella
Cheryl Sabella added the comment: I'm making good progress on this. I should be able to open the PR tomorrow. It's definitely non-trivial, but using your font and general tests as a guide has been invaluable. -- ___ Python tracker

[issue31002] IDLE: Add tests for configdialog keys tab

2017-08-01 Thread Terry J. Reedy
Terry J. Reedy added the comment: Great. It is non-trivial, so I don't expect perfection first try. Please revise docstring with explanation of how page works, like with Font and General pages. I finished tests using those explanations as a guide. They are also a guide for review.

[issue31002] IDLE: Add tests for configdialog keys tab

2017-08-01 Thread Cheryl Sabella
New submission from Cheryl Sabella: I'm working on the tests for this. -- nosy: +csabella ___ Python tracker ___

[issue31002] IDLE: Add tests for configdialog keys tab

2017-07-24 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- assignee: terry.reedy components: IDLE nosy: terry.reedy priority: normal severity: normal stage: needs patch status: open title: IDLE: Add tests for configdialog keys tab type: enhancement versions: Python 3.6, Python 3.7