[issue31146] Docs: On non-public translations, language picker fallback to "English"

[Julien Palard]

Change by Julien Palard :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31146] Docs: On non-public translations, language picker fallback to "English"

[miss-islington]

miss-islington  added the comment:


New changeset df6374e15aadff7eb547fc210c0f4f28bbff7010 by Miss Islington (bot) 
in branch '3.7':
bpo-31146: Don't fallback switcher to english on not-yet pusblished languages. 
(GH-10558)
https://github.com/python/cpython/commit/df6374e15aadff7eb547fc210c0f4f28bbff7010


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31146] Docs: On non-public translations, language picker fallback to "English"

[miss-islington]

miss-islington  added the comment:


New changeset c487cf9261c61f0db4e5d1df3c83a60384b330db by Miss Islington (bot) 
in branch '3.6':
bpo-31146: Don't fallback switcher to english on not-yet pusblished languages. 
(GH-10558)
https://github.com/python/cpython/commit/c487cf9261c61f0db4e5d1df3c83a60384b330db


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31146] Docs: On non-public translations, language picker fallback to "English"

[miss-islington]

miss-islington  added the comment:


New changeset fcbcebadff46f907b38fcf2d79adb3209c5a205d by Miss Islington (bot) 
in branch '2.7':
bpo-31146: Don't fallback switcher to english on not-yet pusblished languages. 
(GH-10558)
https://github.com/python/cpython/commit/fcbcebadff46f907b38fcf2d79adb3209c5a205d


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31146] Docs: On non-public translations, language picker fallback to "English"

[miss-islington]

Change by miss-islington :


--
pull_requests: +9854

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31146] Docs: On non-public translations, language picker fallback to "English"

[miss-islington]

Change by miss-islington :


--
pull_requests: +9853

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31146] Docs: On non-public translations, language picker fallback to "English"

[Julien Palard]

Julien Palard  added the comment:


New changeset 6b73bb523a176123a819e4ebac3727d31d861515 by Julien Palard in 
branch 'master':
bpo-31146: Don't fallback switcher to english on not-yet pusblished languages. 
(GH-10558)
https://github.com/python/cpython/commit/6b73bb523a176123a819e4ebac3727d31d861515


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31146] Docs: On non-public translations, language picker fallback to "English"

[miss-islington]

Change by miss-islington :


--
pull_requests: +9852

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31146] Docs: On non-public translations, language picker fallback to "English"

[Julien Palard]

Change by Julien Palard :


--
keywords: +patch
pull_requests: +9804
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31146] Docs: On non-public translations, language picker fallback to "English"

[Karthikeyan Singaravelan]

Change by Karthikeyan Singaravelan :


--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31146] Docs: On non-public translations, language picker fallback to "English"

[Ned Deily]

Changes by Ned Deily :


--
nosy: +ned.deily

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31146] Docs: On non-public translations, language picker fallback to "English"

[Julien Palard]

New submission from Julien Palard:

As, by default, "english" is selected, and as we're building translations far 
before rendering them public by adding them to the language switcher, there's a 
timespan where a human can voluntarily land on a translation with a language 
switcher unaware of this language.

The language switcher currently defaults to english, so english is selected. As 
"english" is already selected, one can't select "english" to navigate to the 
english version.

Solutions may be to just hide the select element on unknown translations, or 
display the unknown language tag. With more work and a "predicted" list of 
tags-names, it may be possible to also display the name of the language.


Code is here: 
https://github.com/python/cpython/blob/master/Doc/tools/static/switchers.js

I'll take a look, but if some want to do it, let me know.

--
assignee: docs@python
components: Documentation
messages: 299932
nosy: docs@python, mdk
priority: normal
severity: normal
status: open
title: Docs: On non-public translations, language picker fallback to "English"
type: enhancement
versions: Python 2.7, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com